Use allowlist for dap validation

[khewonc]

What does this PR do?

Use allowlist for dap validation

Motivation

New features are not denied automatically
https://datadoghq.atlassian.net/browse/CONTP-1451

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

• Agent: vX.Y.Z
• Cluster Agent: vX.Y.Z

Describe your test plan

With DAP enabled in the operator, create a DAP that configures a config field that's not in the allowlist:

    config:
      override:
        nodeAgent:
          nodeSelector:
            disktype: ssd

You should see the the error component node selector override is not supported in the DAP status:

status:
  conditions:
    - type: Valid
      status: "False"
      reason: Invalid
      message: "profile spec is invalid: component node selector override is not supported"
    - type: Applied
      status: Unknown

Checklist

• PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
• PR has a milestone or the qa/skip-qa label
• All commits are signed (see: signing commits)

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a79a7ad3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Remove APM from the profile feature allowlist

When a DatadogAgentProfile sets spec.config.features.apm, this allowlist entry makes validation return nil even though DAP feature validation was previously limited to GPU and the new reflection test still expects APM to be rejected. I checked go test ./api/datadoghq/v1alpha1 -run TestValidateDatadogAgentProfileFeaturesAllowlist, and it fails on the APM subtest because this line accepts an unsupported profile feature; unsupported APM profile settings can now be reconciled instead of being rejected.

Useful? React with 👍 / 👎.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.35%. Comparing base (08348c6) to head (5a79a7a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3130   +/-   ##
=======================================
  Coverage   43.35%   43.35%           
=======================================
  Files         354      354           
  Lines       30080    30080           
=======================================
  Hits        13042    13042           
  Misses      16165    16165           
  Partials      873      873           

Flag	Coverage Δ
unittests	43.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08348c6...5a79a7a. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[datadog-datadog-prod-us1-2]

 

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-operator | build_operator_check_image_amd64     

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 43.63% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5a79a7a | Docs | Datadog PR Page | Give us feedback!}