Migrate integration tests from static API key secret to dd-sts - #985
Open
chouetz wants to merge 1 commit into
Open
Migrate integration tests from static API key secret to dd-sts#985chouetz wants to merge 1 commit into
chouetz wants to merge 1 commit into
Conversation
Replace DD_TEST_CLIENT_API_KEY and DD_TEST_CLIENT_APP_KEY secrets with short-lived credentials from dd-sts-action, and switch DD_TEST_CLIENT_USER to a repo variable (non-secret).
chouetz
added
changelog/no-changelog
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
chouetz
added
ci/integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/ACIX-1817
Summary
DD_TEST_CLIENT_API_KEYandDD_TEST_CLIENT_APP_KEYsecrets with short-lived credentials fetched viadd-sts-actionid-token: writepermission required for OIDC token federationDD_TEST_CLIENT_USERfrom a secret to a repo variable (vars.DD_TEST_CLIENT_USER)This depends on the dd-source policy
datadogpy-integration-testsbeing merged and deployed before this workflow is enabled.Test plan
DD_TEST_CLIENT_USERas a repo variable in GitHub settingsDD_TEST_CLIENT_API_KEYandDD_TEST_CLIENT_APP_KEYsecrets from repo settings once confirmed workingci/integrationslabel to a PR and verify credentials are fetched successfullyreplaces #981