Added catching of single job id exceptions to deal broken redirect in resource manager #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @johan-g! We'll review it soon and either merge it or get back to you with some additional feedback! 😄 |
|
Thanks, I pushed one more update to this as sometimes JSONDecodeError is raised due to this race condition too |
johan-g
force-pushed
the
catch_exceptions
branch
from
3496d30 to
1428e48
Compare
… resource manager
johan-g
force-pushed
the
catch_exceptions
branch
from
1428e48 to
786199c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the redirect for finished queries in resource manager to mapreduce history server is broken (faulty addresses are generated), a quick workaround to still collect metrics from the jobs still running is to catch the exceptions within the loop