Allow multiple gauge values within the same MetricAggregator instance. #2700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the provided timestamp to the metric instance's context.
Use of multiple gauge values for a single metric requires the timestamps to be passed explicitly.
Problem:
Currently calling self.gauge() with the same metric name, hostname, and tags but different timestamp only retains the last call's value.
Use case:
Upstream API that provides data has a variable delay before values are available. When data is available, it provides multiple values for different timestamps all at once.
Proposed solution:
Includes the provided timestamp as part of the metric instance's context to allow multiple instances that differ only by timestamp.
Notes about solution:
This technically affects all metrics, potentially changing the way the previous metric instance is selected. The updated code only affects previous implementations if and only if the timestamp parameter is specified. The timestamp parameter is currently only used by the gauge metric.