Skip to content

Added support of asterisk pbx software. #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mafairnet
Copy link

@masci
Copy link
Contributor

masci commented Oct 17, 2016

Hi @mafairnet thanks for your code, I worked with asterisk a while ago and this seems a very interesting integration!

That said, we are moving to a new way of shipping integration checks, so your PR won't be merged here but on the integrations-extra repository, see this article for more info on the subject.

Before moving this PR to the other repo, would you mind to fix the tests? It seems a minor issue related to flake8, you can have a look at Travis for all the details.

@masci
Copy link
Contributor

masci commented Jan 30, 2017

Hi @mafairnet ,

Thanks again for your contribution, always very much appreciated. We're currently transitioning our checks to a new SDK-based model for the agent. An unfortunate side-effect is that we have to impose a freeze on the dd-agent repo. The SDK consists of two repositories https://github.com/DataDog/integrations-core and https://github.com/DataDog/integrations-extras, where all of our checks will reside. This PR would belong in the core/extras repository. Would you be so kind as to re-open the PR there? We have facilitated some tools to help you with the SDK development that should help you get up and running in no time: sdk guide datadog sdk gem. We are very sorry for the inconvenience caused.

Thank you for your patience as we make this transition!

@truthbk
Copy link
Member

truthbk commented Jan 31, 2017

@mafairnet, @masci and I, we've taken the liberty of opening a PR here to help you transition to the SDK DataDog/integrations-extras#36

We created a patch of your work and dropped it that PR. Please feel free to continue your work there. 🙇

@irabinovitch
Copy link
Contributor

@mafairnet,

Thanks for this PR! As Jaime and Massi mentioned we're currently in the process migrating agent checks out this repo and into new https://github.com/DataDog/integrations-core and https://github.com/DataDog/integrations-extras repos. This change would fit into the https://github.com/DataDog/integrations-extras repo.

The migration will enable a new release process that allows us to test, merge, and release integrations individually rather than waiting on a full dd-agent release. We believe this will result in a better experience for everone and will improve the contribution process for our OSS projects.

To help make the migration smoother we have migrated this PR for you to DataDog/integrations-extras#36. Would it be OK if we close this PR and and track further discussion in DataDog/integrations-extras#36 ?

To help ease integration development and migration to the new release model we have developed some tools and documentation:

Thank you for your patience as we have been working through this transition. If you have any questions, we are happy to discuss here in this PR or on Slack in #integrations. Our next community office hours and code review is tomorrow at 10:30am PT and we'd be happy to review a PR with you there if you'd like to join us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants