RUM-17613: timeseries [2/5] Using updated timeseries schema from rum_event_schema - #3712
RUM-17613: timeseries [2/5] Using updated timeseries schema from rum_event_schema#3712satween wants to merge 1 commit into
timeseries [2/5] Using updated timeseries schema from rum_event_schema#3712Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🔄 Datadog auto-retried 1 job - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 40fa7af | Docs | Datadog PR Page | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 40fa7af to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## tvaleev/feature/RUM-17613-1-collector-rename #3712 +/- ##
=============================================================================
Coverage 73.23% 73.23%
=============================================================================
Files 1011 1011
Lines 36866 36866
Branches 6366 6366
=============================================================================
Hits 26997 26997
Misses 8049 8049
Partials 1820 1820 🚀 New features to boost your workflow:
|
c932d24 to
e6e92e4
Compare
212abc3 to
a90a51b
Compare
e6e92e4 to
1c35566
Compare
1c35566 to
a2fbff9
Compare
satween
changed the title
71b5db2 to
412744d
Compare
a2fbff9 to
27abec6
Compare
satween
changed the title
satween
changed the title
timeseries [2/4] Using updated timeseries schema from rum_event_schema
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27abec6bff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| datadogContext: DatadogContext, | ||
| rumContext: RumContext, | ||
| dataPoints: List<DataPoint<Double>>, | ||
| customAttributes: Map<String, Any?> |
There was a problem hiding this comment.
When an app sets global RUM attributes, Pipeline snapshots them and passes them here, but this factory never uses customAttributes when constructing the event, so every CPU timeseries event silently loses its user-provided context; MemoryEventFactory has the same omission. Populate the generated event's context from this map instead of discarding it.
Useful? React with 👍 / 👎.
Derive the CPU and memory timeseries schemas from _common-schema.json and replace the hand-written JSON serializers with typed event factories that populate the full common event shape (os, device, dd, ddtags). Restrict collection through TimeseriesConfiguration.collectOnly. Ref: RUM-17613
de0ab41 to
4ce57a5
Compare
27abec6 to
40fa7af
Compare
satween
changed the title
timeseries [2/4] Using updated timeseries schema from rum_event_schematimeseries [2/5] Using updated timeseries schema from rum_event_schema
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40fa7af15b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
What does this PR do?
Uses latest rum-schema for the timeseries
Review checklist (to be filled by reviewers)
Ref: RUM-17613