Skip to content

RUM-18007 Sanitize vital and fatal-error RUM events before writing - #3133

Open
barboraplasovska wants to merge 6 commits into
developfrom
bplasovska/RUM-18007/sanitize-events
Open

RUM-18007 Sanitize vital and fatal-error RUM events before writing#3133
barboraplasovska wants to merge 6 commits into
developfrom
bplasovska/RUM-18007/sanitize-events

Conversation

@barboraplasovska

@barboraplasovska barboraplasovska commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

What and why?

A few RUM event types were not going through RUMEventSanitizer before being written :

  • RUMVitalAppLaunchEvent (TTID app-launch vital)
  • RUMVitalOperationStepEvent (feature-operation vital steps)
  • RUMErrorEvent from crash reports (CrashReportReceiver)
  • RUMErrorEvent from watchdog terminations (WatchdogTerminationReporter)

@barboraplasovska
barboraplasovska marked this pull request as ready for review August 12, 2026 11:40
@barboraplasovska
barboraplasovska requested review from a team as code owners August 12, 2026 11:40
@barboraplasovska barboraplasovska self-assigned this Aug 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f448506dd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@DataDog DataDog deleted a comment from chatgpt-codex-connector Bot Aug 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e26e9b3f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread DatadogRUM/Sources/Integrations/CrashReportReceiver.swift
@sbarrio
sbarrio requested a review from arroz August 13, 2026 07:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c401d64e7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread DatadogRUM/Sources/Integrations/CrashReportReceiver.swift Outdated
@barboraplasovska
barboraplasovska force-pushed the bplasovska/RUM-18007/sanitize-events branch from fdedab6 to 819c90f Compare August 13, 2026 08:08

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 819c90fdfb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread DatadogRUM/Sources/Integrations/CrashReportReceiver.swift Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3de681378

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread DatadogInternal/Sources/Attributes/AttributesSanitizer.swift Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants