Add support for Microsoft.Data.SqlClient 7.0.0#8345
Closed
Conversation
bouwkast
added
the
area:automatic-instrumentation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8345) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (76ms) : 73, 78
master - mean (76ms) : 73, 78
section Bailout
This PR (8345) - mean (80ms) : 78, 82
master - mean (81ms) : 78, 83
section CallTarget+Inlining+NGEN
This PR (8345) - mean (1,101ms) : 1058, 1144
master - mean (1,102ms) : 1065, 1140
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (119ms) : 115, 123
master - mean (120ms) : 116, 123
section Bailout
This PR (8345) - mean (120ms) : 118, 123
master - mean (120ms) : 117, 123
section CallTarget+Inlining+NGEN
This PR (8345) - mean (769ms) : 738, 800
master - mean (766ms) : 733, 799
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (106ms) : 103, 109
master - mean (105ms) : 101, 108
section Bailout
This PR (8345) - mean (106ms) : 102, 109
master - mean (106ms) : 104, 109
section CallTarget+Inlining+NGEN
This PR (8345) - mean (750ms) : 707, 793
master - mean (751ms) : 711, 791
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (104ms) : 99, 109
master - mean (105ms) : 100, 109
section Bailout
This PR (8345) - mean (104ms) : 102, 106
master - mean (106ms) : 103, 108
section CallTarget+Inlining+NGEN
This PR (8345) - mean (689ms) : 663, 716
master - mean (695ms) : 669, 720
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (200ms) : 190, 211
master - mean (197ms) : 190, 204
section Bailout
This PR (8345) - mean (202ms) : 194, 209
master - mean (202ms) : 194, 209
section CallTarget+Inlining+NGEN
This PR (8345) - mean (1,165ms) : 1112, 1219
master - mean (1,169ms) : 1092, 1247
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (282ms) : 274, 291
master - mean (279ms) : 272, 285
section Bailout
This PR (8345) - mean (282ms) : 276, 287
master - mean (279ms) : 275, 283
section CallTarget+Inlining+NGEN
This PR (8345) - mean (908ms) : 873, 943
master - mean (906ms) : 873, 939
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (272ms) : 267, 278
master - mean (274ms) : 266, 281
section Bailout
This PR (8345) - mean (274ms) : 267, 281
master - mean (273ms) : 268, 278
section CallTarget+Inlining+NGEN
This PR (8345) - mean (946ms) : 903, 989
master - mean (943ms) : 905, 980
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8345) - mean (273ms) : 267, 278
master - mean (272ms) : 266, 278
section Bailout
This PR (8345) - mean (276ms) : 265, 287
master - mean (272ms) : 268, 277
section CallTarget+Inlining+NGEN
This PR (8345) - mean (854ms) : 814, 894
master - mean (848ms) : 816, 879
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-03-19 19:40:10 Comparing candidate commit b5a25e4 in PR branch Found 8 performance improvements and 10 performance regressions! Performance is the same for 162 metrics, 12 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
|
Collaborator
Author
|
Closing in favor of #8346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds support for V7 of
Microsoft.Data.SqlClientas it just released a new major version.Just a simple version bump was needed
Reason for change
Microsoft.Data.SqlClient 7.0.0 just released on the 17th and we don't support it and would like to.
Implementation details
Bumped the version, ran
tracer/build.ps1 GeneratePackageVersions -IncludePackages Microsoft.Data.SqlClient, ran testsTest coverage
I manually ran the tests locally against V7 for: .NET Framework 4.8, .NET 8.0, .NET 9.0, .NET 10.0 and all passed
Other details
Utilized the AutoInstrumentationGenerator.CLI tool to grab the latest version and compare our current methods to the new methods and it reported that there are not changes with the methods that we instrument. See: #8313
Was able to use
tracer/build.ps1 GeneratePackageVersions -IncludePackages Microsoft.Data.SqlClientand it only included the necessary changes 😃 🚀