Update Testcontainers to v4 and migrate to ICollectionFixture by bouwkast · Pull Request #8350 · DataDog/dd-trace-dotnet

bouwkast · 2026-03-20T15:44:25Z

Summary of changes

This upgrades Testcontainers to v4 in preparation for more migration of integration tests to use this over normal docker compose files.

This also removes the ContainersRegistry and instead just uses xUnit's ICollectionFixture as previously the actual containers were not being disposed of (in CI they do get cleaned up after the job ends from my understanding) but locally the container would just stay running.

Reason for change

I find it tedious to have to do a docker compose up .... every time that I want to run integration tests locally I would much rather just get to a point where we just can run the test and let the infrastructure handle everything else. This sets us up to start doing that.

Implementation details

Bumped Testcontainers version, fixed build errors / API changes
Add Newtonsoft.Json reference to TestHelpers.AutoInstrumentation as it was complaining that it wasn't there
Migrated AerospikeTests to be the new way

Test coverage

Ran locally before/after there are no differences (outside of the fact that the container is properly disposed now)

Other details

I'll be plugging away at the other integrations

pr-commenter · 2026-03-20T16:27:04Z

Benchmarks

Benchmark execution time: 2026-03-24 19:59:20

Comparing candidate commit 31eb9a6 in PR branch steven/update-test-containers-4 with baseline commit 1bb5b79 in branch master.

Found 7 performance improvements and 10 performance regressions! Performance is the same for 260 metrics, 11 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟩 execution_time [-90.266ms; -90.077ms] or [-44.689%; -44.595%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟩 execution_time [-19.498ms; -14.180ms] or [-12.373%; -8.998%]
🟩 throughput [+159.978op/s; +216.786op/s] or [+10.499%; +14.227%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

🟥 execution_time [+182.266µs; +192.054µs] or [+9.192%; +9.685%]
🟥 throughput [-44.575op/s; -42.399op/s] or [-8.839%; -8.408%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

🟥 execution_time [+84.531µs; +91.135µs] or [+6.084%; +6.560%]
🟥 throughput [-44.460op/s; -41.147op/s] or [-6.177%; -5.717%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

🟩 execution_time [-21.338ms; -17.544ms] or [-10.694%; -8.793%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

🟥 throughput [-49221.781op/s; -35801.105op/s] or [-7.865%; -5.720%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

🟥 allocated_mem [+16.330KB; +16.354KB] or [+6.380%; +6.390%]
🟩 throughput [+100.038op/s; +277.093op/s] or [+5.126%; +14.198%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

🟥 throughput [-3332.206op/s; -1489.398op/s] or [-13.971%; -6.245%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

🟩 execution_time [-33.629ms; -32.349ms] or [-16.820%; -16.180%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

🟥 execution_time [+9.458ms; +11.237ms] or [+10.836%; +12.873%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

🟥 throughput [-15899531.475op/s; -14751667.991op/s] or [-6.587%; -6.112%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

🟥 execution_time [+13.490ms; +18.908ms] or [+6.766%; +9.483%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

🟩 throughput [+40221.192op/s; +46616.966op/s] or [+5.953%; +6.900%]

dd-trace-dotnet-ci-bot · 2026-03-20T16:32:20Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8350) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	69.31 ± (69.54 - 69.99) ms	68.94 ± (68.96 - 69.22) ms	-0.5%	✅
.NET Framework 4.8 - Bailout
duration	73.09 ± (73.02 - 73.28) ms	72.82 ± (72.72 - 73.06) ms	-0.4%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1044.03 ± (1046.70 - 1054.47) ms	1046.93 ± (1050.29 - 1059.67) ms	+0.3%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	21.90 ± (21.87 - 21.94) ms	21.86 ± (21.83 - 21.88) ms	-0.2%	✅
process.time_to_main_ms	79.85 ± (79.68 - 80.03) ms	80.26 ± (80.09 - 80.43) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.89 ± (10.89 - 10.89) MB	10.90 ± (10.90 - 10.91) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	21.88 ± (21.85 - 21.91) ms	21.92 ± (21.88 - 21.96) ms	+0.2%	✅⬆️
process.time_to_main_ms	81.31 ± (81.16 - 81.45) ms	81.46 ± (81.29 - 81.62) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.94 ± (10.93 - 10.94) MB	10.94 ± (10.93 - 10.94) MB	-0.0%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	220.38 ± (219.28 - 221.48) ms	217.09 ± (216.13 - 218.05) ms	-1.5%	✅
process.time_to_main_ms	472.68 ± (472.05 - 473.32) ms	471.59 ± (471.05 - 472.14) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.24 ± (47.21 - 47.27) MB	47.24 ± (47.21 - 47.26) MB	-0.0%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.4%	✅
.NET 6 - Baseline
process.internal_duration_ms	20.78 ± (20.75 - 20.81) ms	20.73 ± (20.70 - 20.76) ms	-0.2%	✅
process.time_to_main_ms	69.91 ± (69.76 - 70.07) ms	69.51 ± (69.39 - 69.64) ms	-0.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.62 ± (10.62 - 10.62) MB	10.63 ± (10.63 - 10.63) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.52 ± (20.50 - 20.54) ms	20.67 ± (20.64 - 20.70) ms	+0.7%	✅⬆️
process.time_to_main_ms	70.16 ± (70.07 - 70.26) ms	70.37 ± (70.26 - 70.49) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.73 ± (10.73 - 10.74) MB	10.74 ± (10.74 - 10.74) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	206.33 ± (204.11 - 208.56) ms	205.16 ± (202.95 - 207.37) ms	-0.6%	✅
process.time_to_main_ms	473.56 ± (472.71 - 474.41) ms	471.85 ± (471.20 - 472.50) ms	-0.4%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.03 ± (48.97 - 49.10) MB	49.01 ± (48.95 - 49.07) MB	-0.0%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	-0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	18.85 ± (18.82 - 18.88) ms	18.94 ± (18.92 - 18.96) ms	+0.5%	✅⬆️
process.time_to_main_ms	68.63 ± (68.48 - 68.77) ms	68.77 ± (68.63 - 68.90) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.69 ± (7.68 - 7.69) MB	7.68 ± (7.67 - 7.69) MB	-0.1%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	18.88 ± (18.86 - 18.91) ms	18.93 ± (18.90 - 18.96) ms	+0.2%	✅⬆️
process.time_to_main_ms	69.67 ± (69.55 - 69.79) ms	69.80 ± (69.67 - 69.92) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.74 ± (7.73 - 7.75) MB	7.75 ± (7.74 - 7.77) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	157.63 ± (156.77 - 158.48) ms	157.79 ± (156.77 - 158.80) ms	+0.1%	✅⬆️
process.time_to_main_ms	451.64 ± (451.12 - 452.16) ms	450.45 ± (449.92 - 450.99) ms	-0.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	36.53 ± (36.51 - 36.55) MB	36.54 ± (36.52 - 36.56) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.1%	✅⬆️

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	195.58 ± (195.53 - 196.34) ms	194.21 ± (194.64 - 195.55) ms	-0.7%	✅
.NET Framework 4.8 - Bailout
duration	197.34 ± (197.14 - 197.92) ms	202.67 ± (201.89 - 202.88) ms	+2.7%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1143.98 ± (1144.38 - 1151.56) ms	1169.81 ± (1173.37 - 1182.96) ms	+2.3%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	188.27 ± (187.94 - 188.59) ms	190.75 ± (190.25 - 191.25) ms	+1.3%	✅⬆️
process.time_to_main_ms	80.90 ± (80.73 - 81.08) ms	82.18 ± (81.87 - 82.48) ms	+1.6%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.14 ± (16.10 - 16.17) MB	16.06 ± (16.03 - 16.08) MB	-0.5%	✅
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (20 - 20)	+0.1%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	188.05 ± (187.62 - 188.48) ms	192.84 ± (192.36 - 193.31) ms	+2.5%	✅⬆️
process.time_to_main_ms	82.62 ± (82.44 - 82.80) ms	84.50 ± (84.27 - 84.73) ms	+2.3%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.09 ± (16.07 - 16.12) MB	16.10 ± (16.09 - 16.12) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	21 ± (20 - 21)	21 ± (21 - 21)	+0.4%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	397.34 ± (395.60 - 399.08) ms	399.54 ± (397.88 - 401.19) ms	+0.6%	✅⬆️
process.time_to_main_ms	474.27 ± (473.58 - 474.95) ms	480.25 ± (479.53 - 480.97) ms	+1.3%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	57.93 ± (57.78 - 58.08) MB	58.23 ± (58.14 - 58.31) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.2%	✅
.NET 6 - Baseline
process.internal_duration_ms	192.60 ± (192.19 - 193.00) ms	193.20 ± (192.86 - 193.55) ms	+0.3%	✅⬆️
process.time_to_main_ms	70.45 ± (70.24 - 70.66) ms	70.63 ± (70.44 - 70.82) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.15 ± (16.02 - 16.28) MB	16.33 ± (16.26 - 16.40) MB	+1.1%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 19)	19 ± (19 - 19)	+2.5%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	191.69 ± (191.36 - 192.03) ms	192.94 ± (192.65 - 193.23) ms	+0.7%	✅⬆️
process.time_to_main_ms	71.18 ± (71.06 - 71.30) ms	71.63 ± (71.50 - 71.75) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.17 ± (16.04 - 16.31) MB	16.07 ± (15.92 - 16.21) MB	-0.7%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	19 ± (19 - 20)	-1.8%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	428.23 ± (426.42 - 430.04) ms	429.12 ± (427.16 - 431.09) ms	+0.2%	✅⬆️
process.time_to_main_ms	476.18 ± (475.42 - 476.94) ms	478.02 ± (477.19 - 478.85) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	60.22 ± (60.15 - 60.29) MB	60.19 ± (60.11 - 60.28) MB	-0.0%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	31 ± (30 - 31)	+0.5%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	190.84 ± (190.41 - 191.27) ms	191.11 ± (190.76 - 191.46) ms	+0.1%	✅⬆️
process.time_to_main_ms	70.21 ± (70.00 - 70.43) ms	70.24 ± (70.07 - 70.42) ms	+0.0%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.77 ± (11.74 - 11.79) MB	11.75 ± (11.73 - 11.77) MB	-0.1%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	+0.1%	✅⬆️
.NET 8 - Bailout
process.internal_duration_ms	190.29 ± (189.98 - 190.61) ms	190.14 ± (189.85 - 190.42) ms	-0.1%	✅
process.time_to_main_ms	70.94 ± (70.81 - 71.06) ms	71.20 ± (71.06 - 71.33) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.85 ± (11.82 - 11.88) MB	11.82 ± (11.79 - 11.85) MB	-0.3%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.4%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	351.91 ± (350.56 - 353.26) ms	358.70 ± (357.49 - 359.90) ms	+1.9%	✅⬆️
process.time_to_main_ms	452.69 ± (452.09 - 453.29) ms	457.20 ± (456.59 - 457.80) ms	+1.0%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	48.41 ± (48.36 - 48.45) MB	48.41 ± (48.37 - 48.45) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.1%	✅

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (69ms)  : 67, 71
    master - mean (70ms)  : 66, 73

    section Bailout
    This PR (8350) - mean (73ms)  : 71, 75
    master - mean (73ms)  : 72, 74

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,055ms)  : 987, 1123
    master - mean (1,051ms)  : 995, 1106

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (108ms)  : 105, 111
    master - mean (107ms)  : 104, 111

    section Bailout
    This PR (8350) - mean (109ms)  : 106, 111
    master - mean (109ms)  : 107, 110

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (725ms)  : 701, 748
    master - mean (730ms)  : 711, 750

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (95ms)  : 93, 98
    master - mean (96ms)  : 93, 99

    section Bailout
    This PR (8350) - mean (96ms)  : 95, 98
    master - mean (96ms)  : 94, 98

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (705ms)  : 660, 749
    master - mean (709ms)  : 668, 751

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (95ms)  : 92, 98
    master - mean (94ms)  : 92, 97

    section Bailout
    This PR (8350) - mean (95ms)  : 93, 97
    master - mean (95ms)  : 93, 97

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (639ms)  : 611, 666
    master - mean (641ms)  : 615, 667

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (195ms)  : 189, 201
    master - mean (196ms)  : 191, 201

    section Bailout
    This PR (8350) - mean (202ms)  : 195, 210
    master - mean (198ms)  : 194, 201

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (1,178ms)  : 1109, 1248
    master - mean (1,148ms)  : 1097, 1199

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (282ms)  : 274, 290
    master - mean (277ms)  : 273, 282

    section Bailout
    This PR (8350) - mean (286ms)  : 275, 297
    master - mean (279ms)  : 274, 284

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (913ms)  : 880, 946
    master - mean (903ms)  : 876, 929

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (272ms)  : 267, 277
    master - mean (272ms)  : 266, 277

    section Bailout
    This PR (8350) - mean (273ms)  : 268, 277
    master - mean (271ms)  : 267, 275

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (939ms)  : 910, 968
    master - mean (936ms)  : 909, 963

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8350) - mean (271ms)  : 265, 278
    master - mean (271ms)  : 263, 278

    section Bailout
    This PR (8350) - mean (271ms)  : 267, 275
    master - mean (271ms)  : 266, 275

    section CallTarget+Inlining+NGEN
    This PR (8350) - mean (845ms)  : 817, 874
    master - mean (835ms)  : 814, 855

bouwkast requested review from a team as code owners March 20, 2026 15:44

bouwkast mentioned this pull request Mar 20, 2026

Dispose TestContainer containers after tests run #7741

Closed

github-actions bot added the area:tests unit tests, integration tests label Mar 20, 2026

Dispose Testcontainers and update to V4

31eb9a6

bouwkast force-pushed the steven/update-test-containers-4 branch from 0e15422 to 31eb9a6 Compare March 24, 2026 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Testcontainers to v4 and migrate to ICollectionFixture#8350

Update Testcontainers to v4 and migrate to ICollectionFixture#8350
bouwkast wants to merge 1 commit intomasterfrom
steven/update-test-containers-4

bouwkast commented Mar 20, 2026

Uh oh!

pr-commenter bot commented Mar 20, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 20, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

bouwkast commented Mar 20, 2026

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

pr-commenter bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 20, 2026

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pr-commenter bot commented Mar 20, 2026 •

edited

Loading