Fix the integration name for several IAST Sqlite bytecode instrumentations by zacharycmontoya · Pull Request #8361 · DataDog/dd-trace-dotnet

zacharycmontoya · 2026-03-24T15:33:20Z

Summary of changes

Changes the integration name from SqlClient to Sqlite for several instrumentations

Reason for change

The surrounding IAST instrumentations all have the Sqlite integration name, so the previous name seems like an error.

Implementation details

Updates two AdoNetClientInstrumentMethodsAttribute

Test coverage

No tests added, this refactor should rely on existing tests

Other details

N/A

…tions

andrewlock

Thanks!

dd-trace-dotnet-ci-bot · 2026-03-31T22:26:55Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8361) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	71.81 ± (71.93 - 72.30) ms	71.69 ± (71.74 - 72.05) ms	-0.2%	✅
.NET Framework 4.8 - Bailout
duration	76.24 ± (76.12 - 76.53) ms	75.98 ± (75.88 - 76.23) ms	-0.3%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1078.95 ± (1077.87 - 1083.64) ms	1061.73 ± (1062.46 - 1067.70) ms	-1.6%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.19 ± (22.15 - 22.23) ms	22.16 ± (22.11 - 22.20) ms	-0.2%	✅
process.time_to_main_ms	83.90 ± (83.73 - 84.07) ms	83.21 ± (83.04 - 83.37) ms	-0.8%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.91 ± (10.91 - 10.92) MB	10.91 ± (10.91 - 10.92) MB	-0.0%	✅
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.17 ± (22.13 - 22.21) ms	22.00 ± (21.97 - 22.04) ms	-0.7%	✅
process.time_to_main_ms	85.26 ± (85.05 - 85.47) ms	84.40 ± (84.21 - 84.58) ms	-1.0%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.95 ± (10.94 - 10.95) MB	10.95 ± (10.94 - 10.95) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	223.40 ± (222.33 - 224.47) ms	221.60 ± (220.61 - 222.60) ms	-0.8%	✅
process.time_to_main_ms	533.34 ± (531.92 - 534.76) ms	514.95 ± (513.74 - 516.15) ms	-3.4%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.24 ± (48.20 - 48.27) MB	47.91 ± (47.87 - 47.95) MB	-0.7%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅
.NET 6 - Baseline
process.internal_duration_ms	20.94 ± (20.91 - 20.98) ms	21.12 ± (21.09 - 21.15) ms	+0.9%	✅⬆️
process.time_to_main_ms	72.12 ± (71.94 - 72.29) ms	72.94 ± (72.78 - 73.11) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.61 ± (10.61 - 10.62) MB	10.64 ± (10.64 - 10.65) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.95 ± (20.91 - 20.98) ms	21.02 ± (20.98 - 21.06) ms	+0.3%	✅⬆️
process.time_to_main_ms	73.35 ± (73.17 - 73.52) ms	73.77 ± (73.58 - 73.96) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.73 ± (10.72 - 10.73) MB	10.75 ± (10.75 - 10.75) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	387.24 ± (384.76 - 389.73) ms	384.83 ± (382.26 - 387.40) ms	-0.6%	✅
process.time_to_main_ms	535.73 ± (534.82 - 536.64) ms	518.93 ± (518.10 - 519.76) ms	-3.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	50.31 ± (50.28 - 50.33) MB	49.99 ± (49.96 - 50.01) MB	-0.6%	✅
runtime.dotnet.threads.count	29 ± (28 - 29)	28 ± (28 - 28)	-0.6%	✅
.NET 8 - Baseline
process.internal_duration_ms	19.33 ± (19.30 - 19.37) ms	19.27 ± (19.23 - 19.31) ms	-0.3%	✅
process.time_to_main_ms	72.07 ± (71.90 - 72.24) ms	71.62 ± (71.47 - 71.78) ms	-0.6%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.66 ± (7.66 - 7.67) MB	7.67 ± (7.66 - 7.68) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.47 ± (19.42 - 19.52) ms	19.22 ± (19.17 - 19.26) ms	-1.3%	✅
process.time_to_main_ms	73.19 ± (73.04 - 73.34) ms	72.60 ± (72.47 - 72.73) ms	-0.8%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.70 ± (7.69 - 7.71) MB	7.73 ± (7.72 - 7.74) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	307.28 ± (304.90 - 309.65) ms	309.25 ± (307.35 - 311.14) ms	+0.6%	✅⬆️
process.time_to_main_ms	493.96 ± (493.08 - 494.84) ms	477.44 ± (476.60 - 478.28) ms	-3.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.25 ± (37.23 - 37.27) MB	36.92 ± (36.90 - 36.95) MB	-0.9%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.1%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	215.23 ± (215.04 - 216.06) ms	206.61 ± (206.20 - 207.29) ms	-4.0%	✅
.NET Framework 4.8 - Bailout
duration	220.21 ± (219.93 - 220.95) ms	210.45 ± (209.89 - 210.94) ms	-4.4%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1271.69 ± (1266.88 - 1274.50) ms	1206.53 ± (1204.12 - 1210.88) ms	-5.1%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	211.38 ± (210.78 - 211.98) ms	199.75 ± (199.30 - 200.20) ms	-5.5%	✅
process.time_to_main_ms	91.81 ± (91.50 - 92.11) ms	86.91 ± (86.62 - 87.20) ms	-5.3%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.89 ± (15.87 - 15.92) MB	16.02 ± (16.00 - 16.04) MB	+0.8%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-1.5%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	211.44 ± (210.90 - 211.98) ms	199.99 ± (199.51 - 200.47) ms	-5.4%	✅
process.time_to_main_ms	93.48 ± (93.19 - 93.78) ms	88.21 ± (87.92 - 88.50) ms	-5.6%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.93 ± (15.91 - 15.95) MB	16.08 ± (16.06 - 16.11) MB	+0.9%	✅⬆️
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (20 - 21)	-2.1%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	423.31 ± (421.62 - 424.99) ms	411.62 ± (410.00 - 413.23) ms	-2.8%	✅
process.time_to_main_ms	575.20 ± (573.79 - 576.60) ms	535.19 ± (533.81 - 536.57) ms	-7.0%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	59.12 ± (59.07 - 59.17) MB	58.54 ± (58.47 - 58.60) MB	-1.0%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.7%	✅
.NET 6 - Baseline
process.internal_duration_ms	216.76 ± (216.28 - 217.24) ms	205.06 ± (204.59 - 205.53) ms	-5.4%	✅
process.time_to_main_ms	79.90 ± (79.65 - 80.14) ms	75.54 ± (75.28 - 75.81) ms	-5.4%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.15 ± (16.13 - 16.17) MB	16.32 ± (16.29 - 16.35) MB	+1.1%	✅⬆️
runtime.dotnet.threads.count	20 ± (19 - 20)	19 ± (19 - 19)	-1.5%	✅
.NET 6 - Bailout
process.internal_duration_ms	220.57 ± (219.88 - 221.26) ms	205.25 ± (204.82 - 205.68) ms	-6.9%	✅
process.time_to_main_ms	82.24 ± (82.00 - 82.48) ms	76.64 ± (76.42 - 76.86) ms	-6.8%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.15 ± (16.13 - 16.16) MB	16.35 ± (16.33 - 16.38) MB	+1.3%	✅⬆️
runtime.dotnet.threads.count	21 ± (20 - 21)	20 ± (20 - 20)	-0.9%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	601.95 ± (599.82 - 604.07) ms	595.83 ± (593.42 - 598.24) ms	-1.0%	✅
process.time_to_main_ms	577.34 ± (575.78 - 578.91) ms	543.04 ± (542.01 - 544.07) ms	-5.9%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.77 ± (61.67 - 61.87) MB	61.62 ± (61.52 - 61.71) MB	-0.2%	✅
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	-0.7%	✅
.NET 8 - Baseline
process.internal_duration_ms	215.63 ± (215.12 - 216.14) ms	205.18 ± (204.70 - 205.66) ms	-4.8%	✅
process.time_to_main_ms	79.84 ± (79.58 - 80.11) ms	76.06 ± (75.81 - 76.30) ms	-4.7%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.52 ± (11.50 - 11.55) MB	11.66 ± (11.64 - 11.68) MB	+1.2%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-1.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	214.53 ± (214.02 - 215.05) ms	204.82 ± (204.40 - 205.23) ms	-4.5%	✅
process.time_to_main_ms	80.66 ± (80.40 - 80.92) ms	76.92 ± (76.72 - 77.12) ms	-4.6%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.59 ± (11.57 - 11.61) MB	11.70 ± (11.69 - 11.72) MB	+1.0%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-1.2%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	585.45 ± (577.93 - 592.97) ms	539.15 ± (532.34 - 545.95) ms	-7.9%	✅
process.time_to_main_ms	532.58 ± (531.22 - 533.93) ms	498.38 ± (497.45 - 499.31) ms	-6.4%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	51.52 ± (51.43 - 51.62) MB	50.75 ± (50.67 - 50.83) MB	-1.5%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (72ms)  : 70, 74
    master - mean (72ms)  : 69, 75

    section Bailout
    This PR (8361) - mean (76ms)  : 74, 78
    master - mean (76ms)  : 73, 79

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (1,065ms)  : 1027, 1103
    master - mean (1,081ms)  : 1039, 1122

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (112ms)  : 109, 115
    master - mean (113ms)  : 109, 117

    section Bailout
    This PR (8361) - mean (113ms)  : 111, 116
    master - mean (114ms)  : 111, 117

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (775ms)  : 755, 795
    master - mean (796ms)  : 777, 816

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (100ms)  : 98, 103
    master - mean (99ms)  : 96, 103

    section Bailout
    This PR (8361) - mean (101ms)  : 99, 103
    master - mean (101ms)  : 98, 103

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (931ms)  : 893, 969
    master - mean (952ms)  : 915, 988

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (99ms)  : 96, 101
    master - mean (99ms)  : 96, 102

    section Bailout
    This PR (8361) - mean (100ms)  : 97, 102
    master - mean (101ms)  : 99, 103

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (817ms)  : 786, 848
    master - mean (831ms)  : 797, 864

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (207ms)  : 200, 213
    master - mean (216ms)  : 211, 220

    section Bailout
    This PR (8361) - mean (210ms)  : 205, 216
    master - mean (220ms)  : 215, 226

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (1,208ms)  : 1156, 1259
    master - mean (1,271ms)  : 1220, 1321

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (296ms)  : 288, 304
    master - mean (313ms)  : 304, 322

    section Bailout
    This PR (8361) - mean (297ms)  : 291, 304
    master - mean (315ms)  : 306, 324

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (990ms)  : 966, 1014
    master - mean (1,041ms)  : 1006, 1077

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (290ms)  : 283, 297
    master - mean (306ms)  : 298, 313

    section Bailout
    This PR (8361) - mean (291ms)  : 284, 297
    master - mean (312ms)  : 297, 328

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (1,173ms)  : 1131, 1215
    master - mean (1,213ms)  : 1165, 1261

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8361) - mean (292ms)  : 283, 301
    master - mean (307ms)  : 300, 314

    section Bailout
    This PR (8361) - mean (292ms)  : 286, 297
    master - mean (306ms)  : 299, 313

    section CallTarget+Inlining+NGEN
    This PR (8361) - mean (1,072ms)  : 969, 1175
    master - mean (1,150ms)  : 1029, 1270

Fix the integration name for several IAST Sqlite bytecode instrumenta…

8c4ddc7

…tions

zacharycmontoya requested review from a team as code owners March 24, 2026 15:33

NachoEchevarria approved these changes Mar 25, 2026

View reviewed changes

andrewlock approved these changes Mar 30, 2026

View reviewed changes

lucaspimentel approved these changes Mar 30, 2026

View reviewed changes

Merge branch 'master' into zach.montoya/fixup-integration-name

afdde29

zacharycmontoya merged commit de2deda into master Mar 31, 2026
137 of 141 checks passed

zacharycmontoya deleted the zach.montoya/fixup-integration-name branch March 31, 2026 23:48

github-actions bot added this to the vNext-v3 milestone Mar 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the integration name for several IAST Sqlite bytecode instrumentations#8361

Fix the integration name for several IAST Sqlite bytecode instrumentations#8361
zacharycmontoya merged 2 commits intomasterfrom
zach.montoya/fixup-integration-name

zacharycmontoya commented Mar 24, 2026

Uh oh!

andrewlock left a comment

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 31, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zacharycmontoya commented Mar 24, 2026

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 31, 2026

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants