Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8403) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (72ms) : 70, 75
master - mean (72ms) : 70, 75
section Bailout
This PR (8403) - mean (76ms) : 74, 78
master - mean (77ms) : 74, 79
section CallTarget+Inlining+NGEN
This PR (8403) - mean (1,065ms) : 1012, 1117
master - mean (1,063ms) : 1013, 1113
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (113ms) : 110, 116
master - mean (113ms) : 109, 116
section Bailout
This PR (8403) - mean (115ms) : 112, 118
master - mean (114ms) : 112, 117
section CallTarget+Inlining+NGEN
This PR (8403) - mean (777ms) : 757, 796
master - mean (775ms) : 756, 793
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (99ms) : 95, 103
master - mean (99ms) : 96, 102
section Bailout
This PR (8403) - mean (100ms) : 98, 103
master - mean (100ms) : 97, 104
section CallTarget+Inlining+NGEN
This PR (8403) - mean (927ms) : 897, 958
master - mean (930ms) : 895, 966
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (98ms) : 95, 100
master - mean (99ms) : 94, 103
section Bailout
This PR (8403) - mean (99ms) : 98, 101
master - mean (98ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8403) - mean (810ms) : 778, 842
master - mean (809ms) : 770, 849
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (189ms) : 185, 192
master - mean (189ms) : 186, 192
section Bailout
This PR (8403) - mean (192ms) : 191, 194
master - mean (192ms) : 191, 194
section CallTarget+Inlining+NGEN
This PR (8403) - mean (1,138ms) : 1076, 1200
master - mean (1,134ms) : 1071, 1197
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (271ms) : 267, 275
master - mean (272ms) : 267, 276
section Bailout
This PR (8403) - mean (272ms) : 269, 274
master - mean (272ms) : 269, 274
section CallTarget+Inlining+NGEN
This PR (8403) - mean (923ms) : 893, 953
master - mean (919ms) : 884, 954
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (264ms) : 261, 268
master - mean (265ms) : 261, 269
section Bailout
This PR (8403) - mean (265ms) : 263, 267
master - mean (265ms) : 262, 267
section CallTarget+Inlining+NGEN
This PR (8403) - mean (1,128ms) : 1080, 1176
master - mean (1,124ms) : 1068, 1179
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8403) - mean (263ms) : 260, 267
master - mean (264ms) : 260, 268
section Bailout
This PR (8403) - mean (263ms) : 261, 265
master - mean (264ms) : 261, 266
section CallTarget+Inlining+NGEN
This PR (8403) - mean (1,020ms) : 985, 1054
master - mean (1,012ms) : 962, 1061
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
left a comment
There was a problem hiding this comment.
LGTM as long as tests pass
This pull request updates one-pipeline to a newer version.
Recent changes:
Add CA certificates to SSI images using BusyBox, to prevent TLS failures
(See https://github.com/DataDog/libdatadog-build/pull/194)
Some of these changes may have already applied depending on your previous version of one-pipeline. See the libdatadog-build repository for all changes