Revert "switch process tags on by default (#8296)" by andrewlock · Pull Request #8405 · DataDog/dd-trace-dotnet

andrewlock · 2026-04-02T12:18:29Z

Summary of changes

This reverts commit b68393d.

Reason for change

Master is broken - all the debugger tests are broken

Implementation details

Reverts the commit so it can be addressed separately

This reverts commit b68393d.

github-actions · 2026-04-02T12:19:22Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

4 occurrences of :

-        "_dd.tags.process": "entrypoint.basedir:VALUE,entrypoint.name:VALUE,entrypoint.workdir:VALUE,svc.auto:VALUE",

vandonr

it saddens me but I can only approve

dd-trace-dotnet-ci-bot · 2026-04-02T13:04:26Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8405) and master.

⚠️ Potential regressions detected

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	188.83 ± (188.81 - 189.47) ms	208.06 ± (207.52 - 208.35) ms	+10.2%	❌⬆️
.NET Framework 4.8 - Bailout
duration	192.84 ± (192.62 - 192.99) ms	213.02 ± (212.92 - 213.94) ms	+10.5%	❌⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1133.72 ± (1135.38 - 1142.68) ms	1214.66 ± (1216.35 - 1224.67) ms	+7.1%	❌⬆️

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	72.04 ± (72.10 - 72.43) ms	75.37 ± (75.35 - 75.74) ms	+4.6%	✅⬆️
.NET Framework 4.8 - Bailout
duration	76.09 ± (75.98 - 76.39) ms	79.07 ± (78.99 - 79.38) ms	+3.9%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1060.67 ± (1062.47 - 1067.55) ms	1093.30 ± (1093.43 - 1101.03) ms	+3.1%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.43 ± (22.39 - 22.48) ms	22.98 ± (22.92 - 23.04) ms	+2.4%	✅⬆️
process.time_to_main_ms	83.51 ± (83.32 - 83.70) ms	87.91 ± (87.69 - 88.14) ms	+5.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.92 ± (10.91 - 10.92) MB	10.92 ± (10.92 - 10.93) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.29 ± (22.25 - 22.32) ms	23.00 ± (22.94 - 23.05) ms	+3.2%	✅⬆️
process.time_to_main_ms	84.58 ± (84.40 - 84.75) ms	89.36 ± (89.17 - 89.55) ms	+5.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.96 ± (10.95 - 10.96) MB	10.95 ± (10.94 - 10.95) MB	-0.1%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	224.48 ± (223.12 - 225.84) ms	232.20 ± (230.97 - 233.43) ms	+3.4%	✅⬆️
process.time_to_main_ms	513.89 ± (512.64 - 515.13) ms	532.04 ± (530.54 - 533.54) ms	+3.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.78 ± (47.75 - 47.82) MB	47.74 ± (47.70 - 47.78) MB	-0.1%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.9%	✅
.NET 6 - Baseline
process.internal_duration_ms	21.02 ± (20.99 - 21.06) ms	21.66 ± (21.63 - 21.70) ms	+3.0%	✅⬆️
process.time_to_main_ms	72.43 ± (72.25 - 72.61) ms	76.23 ± (76.03 - 76.42) ms	+5.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.63 ± (10.63 - 10.63) MB	10.63 ± (10.63 - 10.63) MB	-0.0%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.01 ± (20.97 - 21.04) ms	21.43 ± (21.37 - 21.49) ms	+2.0%	✅⬆️
process.time_to_main_ms	73.10 ± (72.92 - 73.28) ms	76.41 ± (76.21 - 76.62) ms	+4.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.73 ± (10.73 - 10.73) MB	10.74 ± (10.74 - 10.74) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	385.73 ± (383.81 - 387.65) ms	383.03 ± (381.05 - 385.01) ms	-0.7%	✅
process.time_to_main_ms	517.89 ± (516.96 - 518.83) ms	534.62 ± (533.62 - 535.61) ms	+3.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.95 ± (49.92 - 49.98) MB	49.72 ± (49.69 - 49.75) MB	-0.5%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	19.34 ± (19.30 - 19.38) ms	19.87 ± (19.82 - 19.91) ms	+2.7%	✅⬆️
process.time_to_main_ms	71.95 ± (71.80 - 72.11) ms	75.04 ± (74.88 - 75.21) ms	+4.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.68 ± (7.68 - 7.69) MB	7.67 ± (7.66 - 7.67) MB	-0.2%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.36 ± (19.32 - 19.40) ms	20.04 ± (19.99 - 20.09) ms	+3.5%	✅⬆️
process.time_to_main_ms	72.94 ± (72.76 - 73.12) ms	76.76 ± (76.58 - 76.94) ms	+5.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.76 ± (7.75 - 7.77) MB	7.72 ± (7.72 - 7.73) MB	-0.4%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	305.98 ± (303.89 - 308.08) ms	309.17 ± (307.11 - 311.23) ms	+1.0%	✅⬆️
process.time_to_main_ms	476.96 ± (476.22 - 477.71) ms	493.95 ± (492.99 - 494.92) ms	+3.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.02 ± (37.00 - 37.04) MB	37.01 ± (36.98 - 37.03) MB	-0.0%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	+0.2%	✅⬆️

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	188.83 ± (188.81 - 189.47) ms	208.06 ± (207.52 - 208.35) ms	+10.2%	❌⬆️
.NET Framework 4.8 - Bailout
duration	192.84 ± (192.62 - 192.99) ms	213.02 ± (212.92 - 213.94) ms	+10.5%	❌⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1133.72 ± (1135.38 - 1142.68) ms	1214.66 ± (1216.35 - 1224.67) ms	+7.1%	❌⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	184.52 ± (184.24 - 184.80) ms	204.32 ± (203.82 - 204.83) ms	+10.7%	✅⬆️
process.time_to_main_ms	79.26 ± (79.06 - 79.47) ms	88.41 ± (88.15 - 88.66) ms	+11.5%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.14 ± (16.11 - 16.17) MB	15.87 ± (15.85 - 15.89) MB	-1.7%	✅
runtime.dotnet.threads.count	19 ± (19 - 20)	20 ± (20 - 20)	+3.0%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	183.91 ± (183.70 - 184.12) ms	204.60 ± (204.08 - 205.11) ms	+11.2%	✅⬆️
process.time_to_main_ms	80.70 ± (80.60 - 80.81) ms	90.33 ± (90.10 - 90.57) ms	+11.9%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.16 ± (16.13 - 16.19) MB	15.97 ± (15.94 - 15.99) MB	-1.2%	✅
runtime.dotnet.threads.count	20 ± (20 - 21)	21 ± (21 - 21)	+2.0%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	389.69 ± (388.22 - 391.17) ms	413.33 ± (411.87 - 414.78) ms	+6.1%	✅⬆️
process.time_to_main_ms	498.56 ± (497.26 - 499.86) ms	544.31 ± (542.72 - 545.90) ms	+9.2%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	57.89 ± (57.67 - 58.12) MB	58.70 ± (58.66 - 58.73) MB	+1.4%	✅⬆️
runtime.dotnet.threads.count	30 ± (29 - 30)	30 ± (30 - 30)	+0.7%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	188.38 ± (188.11 - 188.65) ms	211.89 ± (211.33 - 212.45) ms	+12.5%	✅⬆️
process.time_to_main_ms	69.16 ± (69.01 - 69.31) ms	78.14 ± (77.86 - 78.43) ms	+13.0%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	15.62 ± (15.44 - 15.80) MB	16.20 ± (16.18 - 16.22) MB	+3.7%	✅⬆️
runtime.dotnet.threads.count	18 ± (17 - 18)	20 ± (19 - 20)	+11.1%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	187.58 ± (187.43 - 187.73) ms	210.89 ± (210.36 - 211.42) ms	+12.4%	✅⬆️
process.time_to_main_ms	69.94 ± (69.89 - 69.99) ms	79.29 ± (79.04 - 79.54) ms	+13.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	15.50 ± (15.33 - 15.67) MB	16.23 ± (16.21 - 16.25) MB	+4.7%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 19)	20 ± (20 - 21)	+10.9%	✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	596.91 ± (593.58 - 600.24) ms	596.68 ± (594.09 - 599.28) ms	-0.0%	✅
process.time_to_main_ms	503.78 ± (502.96 - 504.60) ms	549.37 ± (548.36 - 550.38) ms	+9.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.53 ± (61.44 - 61.62) MB	61.33 ± (61.23 - 61.43) MB	-0.3%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	31 ± (31 - 31)	+1.5%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	186.03 ± (185.83 - 186.24) ms	208.65 ± (208.11 - 209.19) ms	+12.2%	✅⬆️
process.time_to_main_ms	68.37 ± (68.19 - 68.54) ms	77.37 ± (77.12 - 77.62) ms	+13.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.78 ± (11.70 - 11.86) MB	11.65 ± (11.63 - 11.66) MB	-1.1%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	19 ± (19 - 19)	+5.6%	✅⬆️
.NET 8 - Bailout
process.internal_duration_ms	185.75 ± (185.57 - 185.93) ms	208.95 ± (208.46 - 209.45) ms	+12.5%	✅⬆️
process.time_to_main_ms	69.36 ± (69.31 - 69.41) ms	78.79 ± (78.56 - 79.02) ms	+13.6%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.92 ± (11.89 - 11.95) MB	11.70 ± (11.68 - 11.72) MB	-1.8%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	20 ± (20 - 20)	+4.6%	✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	520.81 ± (518.20 - 523.42) ms	557.84 ± (550.14 - 565.53) ms	+7.1%	✅⬆️
process.time_to_main_ms	461.17 ± (460.51 - 461.84) ms	507.15 ± (506.22 - 508.07) ms	+10.0%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.66 ± (50.63 - 50.69) MB	50.97 ± (50.87 - 51.07) MB	+0.6%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.5%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (76ms)  : 73, 78
    master - mean (72ms)  : 70, 75

    section Bailout
    This PR (8405) - mean (79ms)  : 77, 81
    master - mean (76ms)  : 74, 78

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (1,097ms)  : 1040, 1154
    master - mean (1,065ms)  : 1029, 1101

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (118ms)  : 114, 122
    master - mean (113ms)  : 109, 117

    section Bailout
    This PR (8405) - mean (119ms)  : 117, 122
    master - mean (113ms)  : 111, 116

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (803ms)  : 785, 821
    master - mean (778ms)  : 754, 802

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (105ms)  : 100, 109
    master - mean (100ms)  : 96, 103

    section Bailout
    This PR (8405) - mean (105ms)  : 102, 107
    master - mean (100ms)  : 98, 103

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (946ms)  : 912, 979
    master - mean (931ms)  : 899, 964

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (103ms)  : 100, 106
    master - mean (99ms)  : 96, 103

    section Bailout
    This PR (8405) - mean (105ms)  : 102, 107
    master - mean (100ms)  : 98, 102

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (834ms)  : 802, 867
    master - mean (814ms)  : 778, 849

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (208ms)  : 204, 212
    master - mean (189ms)  : 186, 192

    section Bailout
    This PR (8405) - mean (213ms)  : crit, 209, 218
    master - mean (193ms)  : 191, 195

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (1,221ms)  : crit, 1157, 1284
    master - mean (1,139ms)  : 1085, 1193

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (303ms)  : 294, 311
    master - mean (272ms)  : 268, 276

    section Bailout
    This PR (8405) - mean (304ms)  : crit, 298, 311
    master - mean (272ms)  : 270, 275

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (1,001ms)  : crit, 979, 1023
    master - mean (921ms)  : 899, 943

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (299ms)  : 293, 306
    master - mean (266ms)  : 261, 271

    section Bailout
    This PR (8405) - mean (299ms)  : crit, 291, 308
    master - mean (265ms)  : 263, 268

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (1,178ms)  : 1139, 1217
    master - mean (1,131ms)  : 1083, 1179

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8405) - mean (297ms)  : 290, 304
    master - mean (264ms)  : 259, 268

    section Bailout
    This PR (8405) - mean (298ms)  : crit, 292, 304
    master - mean (264ms)  : 261, 268

    section CallTarget+Inlining+NGEN
    This PR (8405) - mean (1,097ms)  : crit, 983, 1210
    master - mean (1,014ms)  : 974, 1055

vandonr

fixed in #8406

Revert "switch process tags on by default (#8296)"

307995d

This reverts commit b68393d.

andrewlock requested review from a team as code owners April 2, 2026 12:18

andrewlock added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Apr 2, 2026

andrewlock requested review from a team as code owners April 2, 2026 12:18

andrewlock added the area:configuration label Apr 2, 2026

andrewlock requested a review from a team as a code owner April 2, 2026 12:18

vandonr approved these changes Apr 2, 2026

View reviewed changes

bouwkast approved these changes Apr 2, 2026

View reviewed changes

vandonr requested changes Apr 2, 2026

View reviewed changes

andrewlock closed this Apr 2, 2026

andrewlock deleted the andrew/revert-process-tags branch April 2, 2026 15:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "switch process tags on by default (#8296)"#8405

Revert "switch process tags on by default (#8296)"#8405
andrewlock wants to merge 1 commit intomasterfrom
andrew/revert-process-tags

andrewlock commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

vandonr left a comment

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

vandonr left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andrewlock commented Apr 2, 2026

Summary of changes

Reason for change

Implementation details

Uh oh!

github-actions bot commented Apr 2, 2026

Snapshots difference summary

Uh oh!

vandonr left a comment

Choose a reason for hiding this comment

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026

Execution-Time Benchmarks Report ⏱️

⚠️ Potential regressions detected

HttpMessageHandler

FakeDbCommand

HttpMessageHandler

Uh oh!

vandonr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants