Skip to content

scrub process tags from debugger snapshots #8406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vandonr merged 1 commit into from
Apr 2, 2026
+4 −1
Merged

scrub process tags from debugger snapshots #8406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracer/test/Datadog.Trace.Debugger.IntegrationTests/Helpers/Approver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ internal static class Approver
{
private static readonly string[] _typesToScrub = { nameof(IntPtr), nameof(Guid) };
private static readonly string[] _knownPropertiesToReplace = { "duration", "timestamp", "dd.span_id", "dd.trace_id", "id", "lineNumber", "thread_name", "thread_id", "<>t__builder", "s_taskIdCounter", "<>u__1", "stack", "m_task" };
private static readonly string[] _knownPropertiesToRemove = { "CachedReusableFilters", "MaxStateDepth", "MaxValidationDepth" };
private static readonly string[] _knownPropertiesToRemove = { "CachedReusableFilters", "MaxStateDepth", "MaxValidationDepth", "process_tags" };

internal static async Task ApproveSnapshots(string[] snapshots, string testName, ITestOutputHelper output, string[] knownPropertiesToReplace = null, string[] knownPropertiesToRemove = null, string[] typesToScrub = null, bool orderPostScrubbing = false)
{
Expand Down
3 changes: 3 additions & 0 deletions tracer/test/Datadog.Trace.Debugger.IntegrationTests/ProbesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,9 @@ private void SanitizeSpanTags(IImmutableList<MockSpan> spans)

foreach (var span in spans)
{
// Remove process tags that can be injected on the first span in a payload
span.Tags.Remove(global::Datadog.Trace.Tags.ProcessTags);

var toSanitize = span.Tags.Where(tag => tag.Key.StartsWith(errorTagStartWith) && tag.Key.EndsWith(errorTagEndWith)).ToList();
foreach (var keyValuePair in toSanitize)
{
Expand Down
Loading