Conversation
github-actions
bot
added
the
area:builds
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66415cf72e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8412) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (76ms) : 74, 78
master - mean (76ms) : 73, 80
section Bailout
This PR (8412) - mean (80ms) : 77, 82
master - mean (80ms) : 78, 83
section CallTarget+Inlining+NGEN
This PR (8412) - mean (1,109ms) : 1065, 1153
master - mean (1,110ms) : 1070, 1150
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (121ms) : 114, 127
master - mean (119ms) : 115, 123
section Bailout
This PR (8412) - mean (120ms) : 117, 123
master - mean (120ms) : 117, 122
section CallTarget+Inlining+NGEN
This PR (8412) - mean (816ms) : 788, 845
master - mean (817ms) : 794, 839
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (106ms) : 101, 111
master - mean (105ms) : 101, 109
section Bailout
This PR (8412) - mean (107ms) : 103, 110
master - mean (106ms) : 102, 110
section CallTarget+Inlining+NGEN
This PR (8412) - mean (953ms) : 910, 995
master - mean (956ms) : 911, 1000
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (106ms) : 100, 111
master - mean (105ms) : 102, 109
section Bailout
This PR (8412) - mean (106ms) : 102, 110
master - mean (107ms) : 104, 110
section CallTarget+Inlining+NGEN
This PR (8412) - mean (839ms) : 802, 876
master - mean (841ms) : 812, 871
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (213ms) : 206, 221
master - mean (212ms) : 206, 217
section Bailout
This PR (8412) - mean (217ms) : 212, 221
master - mean (219ms) : 212, 225
section CallTarget+Inlining+NGEN
This PR (8412) - mean (1,247ms) : 1190, 1303
master - mean (1,251ms) : 1202, 1301
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (310ms) : 303, 317
master - mean (310ms) : 301, 319
section Bailout
This PR (8412) - mean (312ms) : 304, 319
master - mean (313ms) : 306, 320
section CallTarget+Inlining+NGEN
This PR (8412) - mean (1,018ms) : 989, 1047
master - mean (1,024ms) : 999, 1048
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (302ms) : 294, 309
master - mean (303ms) : 294, 312
section Bailout
This PR (8412) - mean (303ms) : 295, 311
master - mean (303ms) : 295, 311
section CallTarget+Inlining+NGEN
This PR (8412) - mean (1,192ms) : 1144, 1240
master - mean (1,193ms) : 1155, 1231
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8412) - mean (302ms) : 294, 310
master - mean (304ms) : 296, 313
section Bailout
This PR (8412) - mean (303ms) : 296, 310
master - mean (303ms) : 296, 309
section CallTarget+Inlining+NGEN
This PR (8412) - mean (1,126ms) : 1007, 1245
master - mean (1,116ms) : 1002, 1231
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details