maybe fix macos smoketests by vandonr · Pull Request #8413 · DataDog/dd-trace-dotnet

vandonr · 2026-04-02T19:21:14Z

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

vandonr · 2026-04-02T19:21:25Z

@codex review

chatgpt-codex-connector · 2026-04-02T19:23:06Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

dd-trace-dotnet-ci-bot · 2026-04-02T20:39:39Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8413) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	76.14 ± (76.14 - 76.56) ms	75.34 ± (75.49 - 75.97) ms	-1.0%	✅
.NET Framework 4.8 - Bailout
duration	80.23 ± (80.07 - 80.45) ms	79.85 ± (79.86 - 80.19) ms	-0.5%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1106.44 ± (1107.18 - 1112.74) ms	1102.63 ± (1103.06 - 1107.93) ms	-0.3%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	23.12 ± (23.06 - 23.17) ms	23.13 ± (23.08 - 23.19) ms	+0.1%	✅⬆️
process.time_to_main_ms	88.86 ± (88.65 - 89.08) ms	88.96 ± (88.74 - 89.18) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.91 ± (10.90 - 10.91) MB	10.91 ± (10.91 - 10.91) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.92 ± (22.87 - 22.98) ms	22.98 ± (22.92 - 23.04) ms	+0.2%	✅⬆️
process.time_to_main_ms	89.78 ± (89.56 - 90.01) ms	90.19 ± (89.97 - 90.41) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.94 ± (10.94 - 10.94) MB	10.93 ± (10.93 - 10.94) MB	-0.1%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	233.76 ± (232.69 - 234.83) ms	232.31 ± (231.14 - 233.48) ms	-0.6%	✅
process.time_to_main_ms	543.11 ± (541.95 - 544.26) ms	541.13 ± (539.81 - 542.45) ms	-0.4%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	47.81 ± (47.78 - 47.83) MB	47.75 ± (47.72 - 47.77) MB	-0.1%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.1%	✅
.NET 6 - Baseline
process.internal_duration_ms	21.70 ± (21.66 - 21.75) ms	21.68 ± (21.64 - 21.72) ms	-0.1%	✅
process.time_to_main_ms	76.65 ± (76.45 - 76.84) ms	75.93 ± (75.76 - 76.11) ms	-0.9%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.63 ± (10.62 - 10.63) MB	10.64 ± (10.63 - 10.64) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	21.79 ± (21.75 - 21.84) ms	21.87 ± (21.81 - 21.92) ms	+0.3%	✅⬆️
process.time_to_main_ms	77.72 ± (77.52 - 77.91) ms	78.24 ± (78.05 - 78.43) ms	+0.7%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.73 ± (10.73 - 10.73) MB	10.75 ± (10.74 - 10.75) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	387.69 ± (385.15 - 390.23) ms	387.92 ± (385.81 - 390.03) ms	+0.1%	✅⬆️
process.time_to_main_ms	539.81 ± (538.68 - 540.93) ms	540.48 ± (539.31 - 541.66) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.80 ± (49.77 - 49.83) MB	49.74 ± (49.71 - 49.78) MB	-0.1%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	20.16 ± (20.11 - 20.21) ms	19.97 ± (19.93 - 20.01) ms	-0.9%	✅
process.time_to_main_ms	76.60 ± (76.43 - 76.77) ms	76.28 ± (76.11 - 76.45) ms	-0.4%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.68 ± (7.67 - 7.68) MB	7.69 ± (7.68 - 7.69) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	20.21 ± (20.15 - 20.28) ms	19.96 ± (19.91 - 20.00) ms	-1.3%	✅
process.time_to_main_ms	78.13 ± (77.94 - 78.33) ms	77.30 ± (77.14 - 77.45) ms	-1.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.75 ± (7.74 - 7.76) MB	7.75 ± (7.74 - 7.75) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	308.80 ± (306.53 - 311.07) ms	306.85 ± (304.56 - 309.14) ms	-0.6%	✅
process.time_to_main_ms	501.85 ± (501.06 - 502.64) ms	500.90 ± (499.97 - 501.84) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.01 ± (36.99 - 37.04) MB	37.11 ± (37.08 - 37.15) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.5%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	211.80 ± (211.31 - 212.39) ms	213.03 ± (212.38 - 213.39) ms	+0.6%	✅⬆️
.NET Framework 4.8 - Bailout
duration	218.39 ± (218.17 - 219.30) ms	216.46 ± (216.17 - 217.00) ms	-0.9%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1250.10 ± (1247.99 - 1254.66) ms	1239.23 ± (1238.48 - 1246.24) ms	-0.9%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	208.40 ± (207.89 - 208.90) ms	207.84 ± (207.34 - 208.35) ms	-0.3%	✅
process.time_to_main_ms	91.40 ± (91.07 - 91.72) ms	90.65 ± (90.34 - 90.96) ms	-0.8%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.93 ± (15.91 - 15.95) MB	15.89 ± (15.87 - 15.92) MB	-0.2%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.3%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	209.81 ± (209.24 - 210.38) ms	208.07 ± (207.52 - 208.63) ms	-0.8%	✅
process.time_to_main_ms	93.23 ± (92.96 - 93.50) ms	91.97 ± (91.67 - 92.27) ms	-1.3%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.96 ± (15.93 - 15.98) MB	15.91 ± (15.89 - 15.93) MB	-0.3%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	+0.4%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	423.38 ± (421.67 - 425.10) ms	418.10 ± (416.79 - 419.42) ms	-1.2%	✅
process.time_to_main_ms	557.15 ± (555.59 - 558.71) ms	551.88 ± (550.17 - 553.59) ms	-0.9%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	58.80 ± (58.75 - 58.84) MB	58.69 ± (58.65 - 58.74) MB	-0.2%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.2%	✅
.NET 6 - Baseline
process.internal_duration_ms	214.62 ± (214.15 - 215.09) ms	214.11 ± (213.58 - 214.64) ms	-0.2%	✅
process.time_to_main_ms	79.40 ± (79.18 - 79.63) ms	79.13 ± (78.88 - 79.37) ms	-0.3%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.25 ± (16.23 - 16.27) MB	16.13 ± (16.11 - 16.16) MB	-0.7%	✅
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (19 - 20)	+0.1%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	213.14 ± (212.59 - 213.69) ms	214.69 ± (214.11 - 215.28) ms	+0.7%	✅⬆️
process.time_to_main_ms	80.77 ± (80.53 - 81.00) ms	80.54 ± (80.30 - 80.77) ms	-0.3%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.24 ± (16.22 - 16.27) MB	16.19 ± (16.17 - 16.21) MB	-0.3%	✅
runtime.dotnet.threads.count	21 ± (20 - 21)	21 ± (20 - 21)	+0.1%	✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	601.85 ± (599.50 - 604.21) ms	599.61 ± (596.89 - 602.34) ms	-0.4%	✅
process.time_to_main_ms	560.53 ± (559.21 - 561.86) ms	558.24 ± (557.11 - 559.37) ms	-0.4%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.37 ± (61.26 - 61.47) MB	61.32 ± (61.22 - 61.41) MB	-0.1%	✅
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	+0.0%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	213.96 ± (213.46 - 214.46) ms	212.23 ± (211.72 - 212.75) ms	-0.8%	✅
process.time_to_main_ms	79.32 ± (79.10 - 79.55) ms	78.78 ± (78.57 - 79.00) ms	-0.7%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.58 ± (11.57 - 11.60) MB	11.64 ± (11.63 - 11.66) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	+0.0%	✅⬆️
.NET 8 - Bailout
process.internal_duration_ms	211.96 ± (211.49 - 212.43) ms	211.85 ± (211.33 - 212.38) ms	-0.0%	✅
process.time_to_main_ms	80.03 ± (79.79 - 80.27) ms	79.98 ± (79.75 - 80.21) ms	-0.1%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.66 ± (11.63 - 11.68) MB	11.66 ± (11.64 - 11.69) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.5%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	567.65 ± (559.73 - 575.56) ms	559.35 ± (551.13 - 567.57) ms	-1.5%	✅
process.time_to_main_ms	514.04 ± (512.90 - 515.18) ms	513.55 ± (512.61 - 514.49) ms	-0.1%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	51.13 ± (51.03 - 51.23) MB	51.02 ± (50.93 - 51.11) MB	-0.2%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (76ms)  : 72, 79
    master - mean (76ms)  : 73, 80

    section Bailout
    This PR (8413) - mean (80ms)  : 78, 82
    master - mean (80ms)  : 78, 83

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (1,105ms)  : 1072, 1139
    master - mean (1,110ms)  : 1070, 1150

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (119ms)  : 115, 123
    master - mean (119ms)  : 115, 123

    section Bailout
    This PR (8413) - mean (120ms)  : 117, 124
    master - mean (120ms)  : 117, 122

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (813ms)  : 793, 833
    master - mean (817ms)  : 794, 839

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (104ms)  : 102, 107
    master - mean (105ms)  : 101, 109

    section Bailout
    This PR (8413) - mean (107ms)  : 104, 110
    master - mean (106ms)  : 102, 110

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (955ms)  : 922, 987
    master - mean (956ms)  : 911, 1000

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (104ms)  : 101, 107
    master - mean (105ms)  : 102, 109

    section Bailout
    This PR (8413) - mean (105ms)  : 103, 107
    master - mean (107ms)  : 104, 110

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (839ms)  : 804, 874
    master - mean (841ms)  : 812, 871

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (213ms)  : 207, 218
    master - mean (212ms)  : 206, 217

    section Bailout
    This PR (8413) - mean (217ms)  : 213, 221
    master - mean (219ms)  : 212, 225

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (1,242ms)  : 1185, 1300
    master - mean (1,251ms)  : 1202, 1301

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (308ms)  : 300, 316
    master - mean (310ms)  : 301, 319

    section Bailout
    This PR (8413) - mean (310ms)  : 301, 318
    master - mean (313ms)  : 306, 320

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (1,013ms)  : 989, 1037
    master - mean (1,024ms)  : 999, 1048

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (302ms)  : 296, 309
    master - mean (303ms)  : 294, 312

    section Bailout
    This PR (8413) - mean (304ms)  : 296, 313
    master - mean (303ms)  : 295, 311

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (1,189ms)  : 1142, 1236
    master - mean (1,193ms)  : 1155, 1231

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8413) - mean (302ms)  : 293, 311
    master - mean (304ms)  : 296, 313

    section Bailout
    This PR (8413) - mean (302ms)  : 295, 309
    master - mean (303ms)  : 296, 309

    section CallTarget+Inlining+NGEN
    This PR (8413) - mean (1,106ms)  : 983, 1229
    master - mean (1,116ms)  : 1002, 1231

maybe fix macos smoketests

bb29a73

github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 2, 2026

vandonr marked this pull request as ready for review April 2, 2026 19:29

vandonr requested a review from a team as a code owner April 2, 2026 19:29

bouwkast approved these changes Apr 2, 2026

View reviewed changes

bouwkast enabled auto-merge (squash) April 2, 2026 19:50

bouwkast disabled auto-merge April 2, 2026 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

maybe fix macos smoketests#8413

maybe fix macos smoketests#8413
vandonr wants to merge 1 commit intomasterfrom
vandonr/process3

vandonr commented Apr 2, 2026

Uh oh!

vandonr commented Apr 2, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 2, 2026

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vandonr commented Apr 2, 2026

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

vandonr commented Apr 2, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 2, 2026

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 2, 2026

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants