[DSM] Test: verify DSM produce checkpoints with ASB 7.18.0#8429
Draft
robcarlan-datadog wants to merge 1 commit intomasterfrom
Draft
[DSM] Test: verify DSM produce checkpoints with ASB 7.18.0#8429robcarlan-datadog wants to merge 1 commit intomasterfrom
robcarlan-datadog wants to merge 1 commit intomasterfrom
Conversation
Bump the DSM test sample to ASB 7.18.0 and enable the test in CI to verify whether DSM produce checkpoints are broken for this SDK version. - Bump Azure.Messaging.ServiceBus from 7.14.0 to 7.18.0 in DSM sample - Replace SkipInCI with RequiresDockerDependency/DockerGroup traits - Pre-create DSM entities in emulator config (admin API not available) - Skip admin API calls in sample app when using the emulator Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8429) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (78ms) : 74, 82
master - mean (78ms) : 76, 81
section Bailout
This PR (8429) - mean (83ms) : 79, 86
master - mean (83ms) : 81, 86
section CallTarget+Inlining+NGEN
This PR (8429) - mean (1,130ms) : 1069, 1190
master - mean (1,133ms) : 1088, 1177
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (121ms) : 117, 126
master - mean (124ms) : 120, 129
section Bailout
This PR (8429) - mean (124ms) : 119, 129
master - mean (125ms) : 121, 129
section CallTarget+Inlining+NGEN
This PR (8429) - mean (822ms) : 795, 850
master - mean (836ms) : 816, 856
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (108ms) : 104, 113
master - mean (110ms) : 104, 116
section Bailout
This PR (8429) - mean (108ms) : 103, 113
master - mean (111ms) : 106, 116
section CallTarget+Inlining+NGEN
This PR (8429) - mean (963ms) : 921, 1004
master - mean (969ms) : 924, 1013
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (106ms) : 102, 110
master - mean (108ms) : 104, 113
section Bailout
This PR (8429) - mean (108ms) : 105, 111
master - mean (109ms) : 105, 112
section CallTarget+Inlining+NGEN
This PR (8429) - mean (851ms) : 814, 889
master - mean (858ms) : 803, 912
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (211ms) : 207, 215
master - mean (213ms) : 207, 219
section Bailout
This PR (8429) - mean (216ms) : 211, 221
master - mean (217ms) : 213, 221
section CallTarget+Inlining+NGEN
This PR (8429) - mean (1,237ms) : 1167, 1307
master - mean (1,238ms) : 1179, 1296
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (306ms) : 299, 313
master - mean (310ms) : 303, 317
section Bailout
This PR (8429) - mean (308ms) : 301, 316
master - mean (313ms) : 305, 320
section CallTarget+Inlining+NGEN
This PR (8429) - mean (1,006ms) : 969, 1042
master - mean (1,021ms) : 989, 1053
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (301ms) : 291, 311
master - mean (304ms) : 297, 311
section Bailout
This PR (8429) - mean (300ms) : 292, 307
master - mean (304ms) : 297, 311
section CallTarget+Inlining+NGEN
This PR (8429) - mean (1,181ms) : 1142, 1219
master - mean (1,187ms) : 1153, 1221
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8429) - mean (301ms) : 293, 308
master - mean (301ms) : 293, 310
section Bailout
This PR (8429) - mean (301ms) : 294, 309
master - mean (303ms) : 295, 312
section CallTarget+Inlining+NGEN
This PR (8429) - mean (1,107ms) : 994, 1220
master - mean (1,120ms) : 993, 1246
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkipInCI)Motivation
We suspect DSM produce checkpoints may be broken for Azure Service Bus SDK 7.18.x+. The DSM test was previously hardcoded to 7.14.0 and skipped in CI, so there was no coverage.
If the
ValidateSpanTagstest fails (fewer than 9 spans withpathway.hash), it confirms the produce-side DSM checkpoint is broken and we need a fix.Test plan
DataStreamsMonitoringAzureServiceBusTeststo either pass (DSM works) or fail (confirms the bug)🤖 Generated with Claude Code