Extract `ContainsSpanId` to `SpanCollection` by andrewlock · Pull Request #8435 · DataDog/dd-trace-dotnet

andrewlock · 2026-04-09T22:08:14Z

Summary of changes

Extracts ContainsSpanId from TraceChunkModel to SpanCollection

Reason for change

I need to find a given span in a SpanCollection for client-side-stats. The algorithm used by TraceChunkModel does it "properly" (by stating from the last span when looking for a root span), so it seems to make sense to move this method to SpanCollection. Additionally, this essentially hides some of the internals about the SpanCollection type, so seems like a better place for it anyway.

Implementation details

Move the IndexOf() method from TraceChunkModel to SpanCollection
Switch it to Contains() instead, seeing as the index is never actually used AFAICT. It's easy to switch it back later if we do need it.

Test coverage

Added some unit tests for the method

Other details

Part of a stack

pr-commenter · 2026-04-09T23:46:43Z

Benchmarks

Benchmark execution time: 2026-04-09 23:46:40

Comparing candidate commit efd496f in PR branch andrew/client-side-stats/refactor-trace-chunk-model with baseline commit 549e87e in branch master.

Found 28 performance improvements and 39 performance regressions! Performance is the same for 211 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

🟩 throughput [+9314.553op/s; +11553.258op/s] or [+7.829%; +9.711%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

🟥 execution_time [+315.020ms; +317.482ms] or [+156.324%; +157.546%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟥 execution_time [+382.557ms; +384.375ms] or [+302.244%; +303.680%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟥 execution_time [+392.997ms; +396.313ms] or [+347.787%; +350.722%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

🟩 execution_time [-16.685ms; -12.493ms] or [-7.793%; -5.835%]
🟩 throughput [+8835.463op/s; +11637.042op/s] or [+6.449%; +8.494%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

🟩 throughput [+7247.955op/s; +9543.581op/s] or [+6.553%; +8.628%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

🟩 execution_time [-26.253ms; -21.396ms] or [-11.708%; -9.542%]
🟩 throughput [+91666.044op/s; +115977.953op/s] or [+9.793%; +12.390%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

🟩 throughput [+102572.620op/s; +119418.642op/s] or [+14.738%; +17.158%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

🟩 throughput [+8921.337op/s; +11951.648op/s] or [+5.676%; +7.605%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

🟩 throughput [+8186.127op/s; +10841.414op/s] or [+6.521%; +8.637%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

🟩 throughput [+271739.427op/s; +302614.557op/s] or [+9.061%; +10.090%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

🟩 execution_time [-17.881ms; -13.198ms] or [-8.243%; -6.084%]
🟩 throughput [+211765.489op/s; +268855.023op/s] or [+8.406%; +10.672%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

🟥 execution_time [+300.011ms; +300.883ms] or [+149.905%; +150.341%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

🟥 execution_time [+299.953ms; +303.344ms] or [+151.267%; +152.977%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

🟥 execution_time [+299.821ms; +302.427ms] or [+151.027%; +152.339%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

🟥 execution_time [+298.031ms; +299.060ms] or [+146.381%; +146.886%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

🟥 execution_time [+295.760ms; +297.844ms] or [+144.586%; +145.605%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

🟥 execution_time [+300.878ms; +302.122ms] or [+150.379%; +151.000%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

🟥 execution_time [+21.518µs; +45.103µs] or [+6.870%; +14.399%]
🟥 throughput [-421.018op/s; -222.532op/s] or [-13.124%; -6.937%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

🟥 execution_time [+299.799ms; +300.419ms] or [+149.630%; +149.940%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

🟩 throughput [+1049.505op/s; +1199.096op/s] or [+8.624%; +9.853%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

🟩 throughput [+688.772op/s; +890.441op/s] or [+6.668%; +8.620%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

🟥 allocated_mem [+2.830KB; +2.835KB] or [+5.028%; +5.037%]
🟥 throughput [-492.778op/s; -431.849op/s] or [-44.650%; -39.130%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟥 throughput [-745.215op/s; -661.785op/s] or [-49.706%; -44.141%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟥 execution_time [+352.239ms; +361.656ms] or [+210.680%; +216.312%]
🟥 throughput [-448.435op/s; -413.574op/s] or [-31.224%; -28.797%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

🟩 throughput [+25.900op/s; +37.013op/s] or [+5.113%; +7.307%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

🟥 throughput [-23106.846op/s; -19295.368op/s] or [-6.508%; -5.435%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

🟥 execution_time [+300.340ms; +301.818ms] or [+151.246%; +151.990%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

🟥 execution_time [+301.418ms; +302.205ms] or [+151.041%; +151.436%]
🟩 throughput [+43040.059op/s; +46984.168op/s] or [+6.786%; +7.408%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

🟥 execution_time [+301.127ms; +304.467ms] or [+151.273%; +152.951%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

🟥 execution_time [+302.523ms; +303.824ms] or [+151.917%; +152.570%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

🟥 execution_time [+298.381ms; +299.881ms] or [+147.536%; +148.278%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

🟥 execution_time [+302.213ms; +305.819ms] or [+153.175%; +155.003%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

🟥 execution_time [+300.385ms; +302.516ms] or [+150.766%; +151.836%]
🟥 throughput [-26471.516op/s; -23646.301op/s] or [-6.867%; -6.134%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

🟥 execution_time [+298.837ms; +300.949ms] or [+148.943%; +149.996%]
🟩 throughput [+60439.452op/s; +65513.864op/s] or [+12.001%; +13.009%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

🟥 execution_time [+300.530ms; +303.097ms] or [+149.511%; +150.788%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

🟩 execution_time [-15.845ms; -12.197ms] or [-7.368%; -5.672%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

🟩 allocated_mem [-27.204KB; -27.183KB] or [-9.923%; -9.916%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

🟥 execution_time [+6.827µs; +10.880µs] or [+16.136%; +25.717%]
🟥 throughput [-4898.786op/s; -3120.509op/s] or [-20.622%; -13.136%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

🟥 execution_time [+303.428ms; +305.297ms] or [+153.369%; +154.314%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

🟥 execution_time [+302.654ms; +304.838ms] or [+154.050%; +155.161%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

🟥 execution_time [+299.982ms; +301.991ms] or [+150.178%; +151.184%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

🟥 execution_time [+301.609ms; +303.519ms] or [+150.325%; +151.277%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

🟥 execution_time [+302.131ms; +307.535ms] or [+151.716%; +154.429%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

🟥 execution_time [+303.861ms; +306.206ms] or [+154.099%; +155.288%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

🟥 execution_time [+299.657ms; +300.323ms] or [+149.470%; +149.803%]
🟩 throughput [+65304617.117op/s; +65561660.322op/s] or [+47.559%; +47.746%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

🟥 execution_time [+426.700ms; +430.247ms] or [+530.677%; +535.089%]
🟩 throughput [+931.077op/s; +1104.918op/s] or [+7.198%; +8.542%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

🟥 execution_time [+299.793ms; +300.737ms] or [+149.530%; +150.001%]
🟩 throughput [+18355127.963op/s; +19306266.771op/s] or [+8.130%; +8.551%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

🟩 throughput [+67284.004op/s; +78195.955op/s] or [+6.282%; +7.301%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

🟩 throughput [+82292.620op/s; +112044.527op/s] or [+6.370%; +8.672%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

🟩 throughput [+78558.237op/s; +87581.090op/s] or [+7.802%; +8.698%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

🟩 throughput [+41926.395op/s; +48558.742op/s] or [+7.613%; +8.817%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

🟩 throughput [+23478.596op/s; +33151.914op/s] or [+5.255%; +7.420%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

🟩 throughput [+82009.521op/s; +99055.650op/s] or [+9.163%; +11.067%]

dd-trace-dotnet-ci-bot · 2026-04-09T23:53:08Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8435) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	71.64 ± (71.70 - 72.11) ms	71.20 ± (71.24 - 71.59) ms	-0.6%	✅
.NET Framework 4.8 - Bailout
duration	76.12 ± (75.87 - 76.26) ms	75.39 ± (75.36 - 75.76) ms	-1.0%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1062.39 ± (1066.52 - 1074.97) ms	1061.79 ± (1063.83 - 1070.54) ms	-0.1%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.12 ± (22.08 - 22.16) ms	22.33 ± (22.29 - 22.37) ms	+1.0%	✅⬆️
process.time_to_main_ms	83.51 ± (83.32 - 83.69) ms	83.22 ± (83.03 - 83.41) ms	-0.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.90 ± (10.90 - 10.91) MB	10.92 ± (10.92 - 10.93) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.24 ± (22.20 - 22.28) ms	22.20 ± (22.17 - 22.23) ms	-0.2%	✅
process.time_to_main_ms	85.17 ± (84.98 - 85.36) ms	84.59 ± (84.39 - 84.80) ms	-0.7%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.94 ± (10.93 - 10.94) MB	10.95 ± (10.94 - 10.95) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	225.10 ± (223.79 - 226.40) ms	224.66 ± (223.41 - 225.90) ms	-0.2%	✅
process.time_to_main_ms	513.91 ± (512.81 - 515.01) ms	517.01 ± (515.90 - 518.13) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.40 ± (48.36 - 48.44) MB	48.29 ± (48.26 - 48.32) MB	-0.2%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.4%	✅
.NET 6 - Baseline
process.internal_duration_ms	20.94 ± (20.91 - 20.98) ms	21.00 ± (20.97 - 21.02) ms	+0.2%	✅⬆️
process.time_to_main_ms	72.16 ± (72.00 - 72.33) ms	72.20 ± (72.05 - 72.36) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.60 ± (10.60 - 10.61) MB	10.62 ± (10.62 - 10.62) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.70 ± (20.66 - 20.74) ms	20.77 ± (20.75 - 20.80) ms	+0.4%	✅⬆️
process.time_to_main_ms	72.11 ± (71.98 - 72.24) ms	72.38 ± (72.22 - 72.53) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.65 ± (10.65 - 10.66) MB	10.67 ± (10.66 - 10.67) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	384.56 ± (382.46 - 386.65) ms	388.53 ± (386.22 - 390.83) ms	+1.0%	✅⬆️
process.time_to_main_ms	515.16 ± (514.33 - 515.99) ms	516.57 ± (515.62 - 517.51) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	49.93 ± (49.90 - 49.96) MB	49.75 ± (49.72 - 49.78) MB	-0.4%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.1%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	19.00 ± (18.97 - 19.03) ms	19.16 ± (19.14 - 19.19) ms	+0.9%	✅⬆️
process.time_to_main_ms	70.73 ± (70.58 - 70.88) ms	71.58 ± (71.41 - 71.74) ms	+1.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.68 ± (7.67 - 7.69) MB	7.68 ± (7.67 - 7.69) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.06 ± (19.03 - 19.09) ms	19.18 ± (19.15 - 19.21) ms	+0.6%	✅⬆️
process.time_to_main_ms	72.07 ± (71.93 - 72.20) ms	72.39 ± (72.22 - 72.56) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.75 ± (7.74 - 7.76) MB	7.73 ± (7.72 - 7.74) MB	-0.3%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	304.26 ± (302.29 - 306.23) ms	306.20 ± (304.29 - 308.11) ms	+0.6%	✅⬆️
process.time_to_main_ms	477.13 ± (476.39 - 477.87) ms	478.05 ± (477.21 - 478.89) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	36.99 ± (36.97 - 37.01) MB	38.10 ± (38.06 - 38.14) MB	+3.0%	✅⬆️
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.4%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	193.70 ± (193.65 - 194.31) ms	193.53 ± (193.46 - 194.35) ms	-0.1%	✅
.NET Framework 4.8 - Bailout
duration	197.67 ± (197.53 - 198.05) ms	196.70 ± (196.42 - 196.98) ms	-0.5%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1148.69 ± (1150.80 - 1159.08) ms	1140.35 ± (1140.42 - 1145.84) ms	-0.7%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	189.02 ± (188.75 - 189.30) ms	187.56 ± (187.24 - 187.88) ms	-0.8%	✅
process.time_to_main_ms	81.17 ± (80.97 - 81.37) ms	81.18 ± (80.96 - 81.41) ms	+0.0%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.12 ± (16.10 - 16.15) MB	16.13 ± (16.10 - 16.16) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (19 - 20)	-0.1%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	188.34 ± (188.07 - 188.61) ms	187.58 ± (187.26 - 187.89) ms	-0.4%	✅
process.time_to_main_ms	82.68 ± (82.58 - 82.79) ms	82.38 ± (82.22 - 82.54) ms	-0.4%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.10 ± (16.07 - 16.13) MB	16.13 ± (16.10 - 16.15) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	21 ± (20 - 21)	21 ± (20 - 21)	+0.0%	✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	393.64 ± (392.04 - 395.24) ms	394.16 ± (392.68 - 395.65) ms	+0.1%	✅⬆️
process.time_to_main_ms	505.54 ± (504.22 - 506.86) ms	511.22 ± (510.01 - 512.43) ms	+1.1%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	58.49 ± (58.27 - 58.70) MB	58.96 ± (58.80 - 59.11) MB	+0.8%	✅⬆️
runtime.dotnet.threads.count	29 ± (29 - 30)	30 ± (30 - 30)	+0.3%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	192.32 ± (192.06 - 192.59) ms	191.81 ± (191.55 - 192.07) ms	-0.3%	✅
process.time_to_main_ms	70.27 ± (70.14 - 70.41) ms	70.39 ± (70.25 - 70.54) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.12 ± (15.99 - 16.25) MB	16.02 ± (15.86 - 16.17) MB	-0.7%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 19)	+0.3%	✅⬆️
.NET 6 - Bailout
process.internal_duration_ms	191.54 ± (191.28 - 191.81) ms	191.26 ± (190.97 - 191.54) ms	-0.2%	✅
process.time_to_main_ms	71.18 ± (71.11 - 71.25) ms	71.33 ± (71.22 - 71.43) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.19 ± (16.05 - 16.32) MB	15.94 ± (15.78 - 16.10) MB	-1.5%	✅
runtime.dotnet.threads.count	19 ± (19 - 20)	19 ± (19 - 19)	-1.4%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	602.58 ± (599.75 - 605.41) ms	599.71 ± (597.11 - 602.30) ms	-0.5%	✅
process.time_to_main_ms	510.28 ± (509.52 - 511.03) ms	511.14 ± (510.31 - 511.96) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.49 ± (61.40 - 61.58) MB	61.52 ± (61.42 - 61.62) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.2%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	189.90 ± (189.65 - 190.15) ms	189.22 ± (188.94 - 189.50) ms	-0.4%	✅
process.time_to_main_ms	69.86 ± (69.72 - 70.00) ms	69.70 ± (69.54 - 69.85) ms	-0.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.78 ± (11.76 - 11.81) MB	11.83 ± (11.79 - 11.88) MB	+0.4%	✅⬆️
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	-0.1%	✅
.NET 8 - Bailout
process.internal_duration_ms	188.98 ± (188.73 - 189.24) ms	188.73 ± (188.47 - 188.99) ms	-0.1%	✅
process.time_to_main_ms	70.82 ± (70.74 - 70.89) ms	70.84 ± (70.74 - 70.93) ms	+0.0%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.75 ± (11.66 - 11.83) MB	11.78 ± (11.71 - 11.85) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	19 ± (18 - 19)	19 ± (19 - 19)	+0.3%	✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	520.74 ± (518.26 - 523.23) ms	524.10 ± (521.70 - 526.50) ms	+0.6%	✅⬆️
process.time_to_main_ms	470.49 ± (469.75 - 471.22) ms	469.44 ± (468.66 - 470.23) ms	-0.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	50.73 ± (50.70 - 50.76) MB	50.98 ± (50.94 - 51.01) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (71ms)  : 69, 74
    master - mean (72ms)  : 69, 75

    section Bailout
    This PR (8435) - mean (76ms)  : 73, 78
    master - mean (76ms)  : 74, 78

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (1,067ms)  : 1019, 1116
    master - mean (1,071ms)  : 1008, 1134

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (112ms)  : 109, 116
    master - mean (112ms)  : 109, 115

    section Bailout
    This PR (8435) - mean (113ms)  : 110, 116
    master - mean (114ms)  : 112, 117

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (780ms)  : 760, 801
    master - mean (776ms)  : 756, 796

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (99ms)  : 96, 103
    master - mean (99ms)  : 95, 103

    section Bailout
    This PR (8435) - mean (99ms)  : 96, 102
    master - mean (99ms)  : 96, 101

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (934ms)  : 895, 972
    master - mean (927ms)  : 893, 961

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (98ms)  : 94, 103
    master - mean (97ms)  : 94, 100

    section Bailout
    This PR (8435) - mean (99ms)  : 96, 102
    master - mean (99ms)  : 96, 101

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (817ms)  : 789, 845
    master - mean (811ms)  : 783, 840

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (194ms)  : 189, 198
    master - mean (194ms)  : 191, 197

    section Bailout
    This PR (8435) - mean (197ms)  : 194, 199
    master - mean (198ms)  : 195, 200

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (1,143ms)  : 1104, 1182
    master - mean (1,155ms)  : 1094, 1216

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (277ms)  : 272, 282
    master - mean (279ms)  : 275, 283

    section Bailout
    This PR (8435) - mean (278ms)  : 274, 283
    master - mean (279ms)  : 276, 282

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (933ms)  : 910, 955
    master - mean (927ms)  : 905, 949

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (270ms)  : 266, 275
    master - mean (271ms)  : 267, 275

    section Bailout
    This PR (8435) - mean (271ms)  : 267, 274
    master - mean (271ms)  : 268, 273

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (1,141ms)  : 1107, 1176
    master - mean (1,142ms)  : 1097, 1186

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8435) - mean (269ms)  : 265, 272
    master - mean (269ms)  : 266, 273

    section Bailout
    This PR (8435) - mean (269ms)  : 266, 272
    master - mean (269ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (8435) - mean (1,026ms)  : 992, 1059
    master - mean (1,024ms)  : 982, 1066

andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:refactor labels Apr 9, 2026

andrewlock force-pushed the andrew/client-side-stats/refactor-trace-chunk-model branch from d367d99 to efd496f Compare April 9, 2026 22:41

andrewlock force-pushed the andrew/client-side-stats/client-side-stats-1-2 branch from 46c887a to d2adf6e Compare April 9, 2026 22:41

andrewlock marked this pull request as ready for review April 10, 2026 08:20

andrewlock requested a review from a team as a code owner April 10, 2026 08:20

andrewlock mentioned this pull request Apr 10, 2026

Fix processing pipeline for client-side-stats #8436

Open

Extract ContainsSpanId to a public method

bda5853

andrewlock force-pushed the andrew/client-side-stats/refactor-trace-chunk-model branch from efd496f to bda5853 Compare April 10, 2026 12:29

andrewlock requested a review from a team as a code owner April 10, 2026 12:29

andrewlock force-pushed the andrew/client-side-stats/client-side-stats-1-2 branch from d2adf6e to f8a1a26 Compare April 10, 2026 12:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract `ContainsSpanId` to `SpanCollection`#8435

Extract `ContainsSpanId` to `SpanCollection`#8435
andrewlock wants to merge 1 commit intoandrew/client-side-stats/client-side-stats-1-2from
andrew/client-side-stats/refactor-trace-chunk-model

andrewlock commented Apr 9, 2026

Uh oh!

pr-commenter bot commented Apr 9, 2026

Explanation

More details about the CI and significant changes

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 9, 2026 •

edited

Loading

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

andrewlock commented Apr 9, 2026

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

pr-commenter bot commented Apr 9, 2026

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dd-trace-dotnet-ci-bot bot commented Apr 9, 2026 •

edited

Loading