Skip to content

Handle UuidToStringA failure in GenerateRuntimeId #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
link04 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Handle UuidToStringA failure in GenerateRuntimeId #9026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions shared/src/native-src/util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,12 @@ namespace shared
UUID uuid;
UuidCreate(&uuid);

unsigned char* str;
UuidToStringA(&uuid, &str);
unsigned char* str = nullptr;
if (UuidToStringA(&uuid, &str) != RPC_S_OK)
{
// str is left untouched on failure, so there is nothing to free
return GenerateUuidV4();
}

std::string s((char*) str);

Expand Down
Loading