Skip to content

[ASM] Log endpoints collection failures as warnings, not errors #9030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dromanol wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[ASM] Log endpoints collection failures as warnings, not errors #9030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
186e74f
[ASM] Log endpoints collection failures as warnings, not errors
dromanol Aug 12, 2026
2b5dfce
Narrow the warning to the third-party endpoint getter
dromanol Aug 12, 2026
f68775a
Trim the comment
dromanol Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...oInstrumentation/AspNetCore/EndpointsCollection/KestrelServerImplStartAsyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#if !NETFRAMEWORK

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Threading;
using Datadog.Trace.AppSec;
Expand Down Expand Up @@ -84,7 +85,20 @@ private static void GatherEndpoints(IKestrelServer kestrelServer)
return;
}

AppSec.EndpointsCollection.CollectEndpoints(endpointDataSource.Endpoints);
IReadOnlyList<object> endpoints;

try
{
endpoints = endpointDataSource.Endpoints;
}
catch (Exception ex)
{
// Evaluating this property runs third-party code, so a failure here isn't a tracer defect
Log.Warning(ex, "API Security: Endpoints collection: Failed to evaluate the EndpointDataSource endpoints.");
return;
}

AppSec.EndpointsCollection.CollectEndpoints(endpoints);
}
}

Expand Down
Loading