TEST spring kafka fix singledir #7649
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (this == o) return true; | |
| if (this == o) {return true}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
Comment on lines
+81
to
+85
| protected KafkaDecorator(String spanKind, CharSequence spanType, String serviceName) { | ||
| this.spanKind = spanKind; | ||
| this.spanType = spanType; | ||
| this.serviceName = serviceName; | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (o == null || getClass() != o.getClass()) return false; | |
| if (o == null || getClass() != o.getClass()) {return false}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.
See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 45 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.577 s) : 0, 1576722
Total [baseline] (11.866 s) : 0, 11865987
Agent [candidate] (1.574 s) : 0, 1573758
Total [candidate] (11.886 s) : 0, 11886182
section iast
Agent [baseline] (1.736 s) : 0, 1736244
Total [baseline] (12.525 s) : 0, 12525195
Agent [candidate] (1.74 s) : 0, 1739598
Total [candidate] (12.579 s) : 0, 12579188
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.743 s) : 0, 1742774
Total [baseline] (12.519 s) : 0, 12518699
Agent [candidate] (1.741 s) : 0, 1740777
Total [candidate] (12.562 s) : 0, 12562122
section iast_TELEMETRY_OFF
Agent [baseline] (1.73 s) : 0, 1729661
Total [baseline] (12.482 s) : 0, 12481734
Agent [candidate] (1.735 s) : 0, 1734783
Total [candidate] (12.553 s) : 0, 12553351
gantt
title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.01 s) : 0, 1009690
BytebuddyAgent [candidate] (1.009 s) : 0, 1008925
GlobalTracer [baseline] (460.121 ms) : 0, 460121
GlobalTracer [candidate] (460.906 ms) : 0, 460906
AppSec [baseline] (75.664 ms) : 0, 75664
AppSec [candidate] (73.069 ms) : 0, 73069
Remote Config [baseline] (829.724 µs) : 0, 830
Remote Config [candidate] (860.47 µs) : 0, 860
Telemetry [baseline] (10.009 ms) : 0, 10009
Telemetry [candidate] (9.594 ms) : 0, 9594
section iast
BytebuddyAgent [baseline] (1.162 s) : 0, 1162123
BytebuddyAgent [candidate] (1.167 s) : 0, 1167177
GlobalTracer [baseline] (437.911 ms) : 0, 437911
GlobalTracer [candidate] (439.051 ms) : 0, 439051
AppSec [baseline] (72.982 ms) : 0, 72982
AppSec [candidate] (71.227 ms) : 0, 71227
IAST [baseline] (32.758 ms) : 0, 32758
IAST [candidate] (31.338 ms) : 0, 31338
Remote Config [baseline] (788.094 µs) : 0, 788
Remote Config [candidate] (835.66 µs) : 0, 836
Telemetry [baseline] (9.363 ms) : 0, 9363
Telemetry [candidate] (9.497 ms) : 0, 9497
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.167 s) : 0, 1167452
BytebuddyAgent [candidate] (1.166 s) : 0, 1165942
GlobalTracer [baseline] (439.482 ms) : 0, 439482
GlobalTracer [candidate] (439.438 ms) : 0, 439438
AppSec [baseline] (74.136 ms) : 0, 74136
AppSec [candidate] (73.731 ms) : 0, 73731
IAST [baseline] (30.951 ms) : 0, 30951
IAST [candidate] (30.614 ms) : 0, 30614
Remote Config [baseline] (849.564 µs) : 0, 850
Remote Config [candidate] (884.486 µs) : 0, 884
Telemetry [baseline] (9.537 ms) : 0, 9537
Telemetry [candidate] (9.704 ms) : 0, 9704
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.157 s) : 0, 1156936
BytebuddyAgent [candidate] (1.163 s) : 0, 1163229
GlobalTracer [baseline] (437.872 ms) : 0, 437872
GlobalTracer [candidate] (439.071 ms) : 0, 439071
AppSec [baseline] (73.946 ms) : 0, 73946
AppSec [candidate] (70.683 ms) : 0, 70683
IAST [baseline] (29.678 ms) : 0, 29678
IAST [candidate] (29.322 ms) : 0, 29322
Remote Config [baseline] (1.577 ms) : 0, 1577
Remote Config [candidate] (789.25 µs) : 0, 789
Telemetry [baseline] (9.355 ms) : 0, 9355
Telemetry [candidate] (11.214 ms) : 0, 11214
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.571 s) : 0, 1570783
Total [baseline] (14.305 s) : 0, 14304765
Agent [candidate] (1.574 s) : 0, 1573504
Total [candidate] (14.374 s) : 0, 14374487
section appsec
Agent [baseline] (1.774 s) : 0, 1773716
Total [baseline] (14.673 s) : 0, 14673301
Agent [candidate] (1.77 s) : 0, 1770216
Total [candidate] (14.649 s) : 0, 14648558
section iast
Agent [baseline] (1.748 s) : 0, 1748247
Total [baseline] (14.863 s) : 0, 14862612
Agent [candidate] (1.736 s) : 0, 1735953
Total [candidate] (14.942 s) : 0, 14942406
section profiling
Agent [baseline] (1.899 s) : 0, 1898750
Total [baseline] (14.631 s) : 0, 14631136
Agent [candidate] (1.89 s) : 0, 1889848
Total [candidate] (14.517 s) : 0, 14516741
gantt
title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (1.005 s) : 0, 1005079
BytebuddyAgent [candidate] (1.007 s) : 0, 1007420
GlobalTracer [baseline] (459.169 ms) : 0, 459169
GlobalTracer [candidate] (461.809 ms) : 0, 461809
AppSec [baseline] (75.538 ms) : 0, 75538
AppSec [candidate] (73.408 ms) : 0, 73408
Remote Config [baseline] (817.625 µs) : 0, 818
Remote Config [candidate] (860.351 µs) : 0, 860
Telemetry [baseline] (9.893 ms) : 0, 9893
Telemetry [candidate] (9.598 ms) : 0, 9598
section appsec
BytebuddyAgent [baseline] (1.036 s) : 0, 1036373
BytebuddyAgent [candidate] (1.035 s) : 0, 1034625
GlobalTracer [baseline] (449.477 ms) : 0, 449477
GlobalTracer [candidate] (450.689 ms) : 0, 450689
AppSec [baseline] (241.857 ms) : 0, 241857
AppSec [candidate] (240.082 ms) : 0, 240082
IAST [baseline] (24.739 ms) : 0, 24739
IAST [candidate] (24.797 ms) : 0, 24797
Remote Config [baseline] (790.578 µs) : 0, 791
Remote Config [candidate] (793.576 µs) : 0, 794
Telemetry [baseline] (12.57 ms) : 0, 12570
Telemetry [candidate] (11.271 ms) : 0, 11271
section iast
BytebuddyAgent [baseline] (1.17 s) : 0, 1170127
BytebuddyAgent [candidate] (1.163 s) : 0, 1163178
GlobalTracer [baseline] (441.782 ms) : 0, 441782
GlobalTracer [candidate] (438.096 ms) : 0, 438096
AppSec [baseline] (74.372 ms) : 0, 74372
AppSec [candidate] (69.875 ms) : 0, 69875
IAST [baseline] (31.285 ms) : 0, 31285
IAST [candidate] (33.904 ms) : 0, 33904
Remote Config [baseline] (776.845 µs) : 0, 777
Remote Config [candidate] (959.718 µs) : 0, 960
Telemetry [baseline] (9.526 ms) : 0, 9526
Telemetry [candidate] (9.495 ms) : 0, 9495
section profiling
BytebuddyAgent [baseline] (1.001 s) : 0, 1001284
BytebuddyAgent [candidate] (997.496 ms) : 0, 997496
GlobalTracer [baseline] (590.76 ms) : 0, 590760
GlobalTracer [candidate] (588.802 ms) : 0, 588802
AppSec [baseline] (76.692 ms) : 0, 76692
AppSec [candidate] (73.565 ms) : 0, 73565
Remote Config [baseline] (824.729 µs) : 0, 825
Remote Config [candidate] (889.436 µs) : 0, 889
Telemetry [baseline] (9.631 ms) : 0, 9631
Telemetry [candidate] (9.629 ms) : 0, 9629
ProfilingAgent [baseline] (162.419 ms) : 0, 162419
ProfilingAgent [candidate] (162.487 ms) : 0, 162487
Profiling [baseline] (162.476 ms) : 0, 162476
Profiling [candidate] (162.544 ms) : 0, 162544
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section baseline
no_agent (1.335 ms) : 1315, 1354
. : milestone, 1335,
appsec (1.708 ms) : 1685, 1731
. : milestone, 1708,
appsec_no_iast (1.729 ms) : 1704, 1753
. : milestone, 1729,
iast (1.468 ms) : 1445, 1490
. : milestone, 1468,
profiling (1.465 ms) : 1440, 1490
. : milestone, 1465,
tracing (1.462 ms) : 1438, 1486
. : milestone, 1462,
section candidate
no_agent (1.339 ms) : 1320, 1359
. : milestone, 1339,
appsec (1.728 ms) : 1704, 1752
. : milestone, 1728,
appsec_no_iast (1.731 ms) : 1707, 1755
. : milestone, 1731,
iast (1.491 ms) : 1468, 1514
. : milestone, 1491,
profiling (1.481 ms) : 1458, 1504
. : milestone, 1481,
tracing (1.469 ms) : 1445, 1493
. : milestone, 1469,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section baseline
no_agent (371.421 µs) : 352, 391
. : milestone, 371,
iast (481.474 µs) : 460, 503
. : milestone, 481,
iast_FULL (549.866 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (507.388 µs) : 486, 529
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (498.962 µs) : 477, 521
. : milestone, 499,
iast_INACTIVE (444.445 µs) : 424, 465
. : milestone, 444,
iast_TELEMETRY_OFF (480.872 µs) : 458, 504
. : milestone, 481,
tracing (450.622 µs) : 429, 472
. : milestone, 451,
section candidate
no_agent (376.859 µs) : 357, 397
. : milestone, 377,
iast (486.641 µs) : 465, 508
. : milestone, 487,
iast_FULL (548.941 µs) : 528, 570
. : milestone, 549,
iast_GLOBAL (513.464 µs) : 491, 536
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (493.08 µs) : 471, 515
. : milestone, 493,
iast_INACTIVE (445.937 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (482.58 µs) : 459, 506
. : milestone, 483,
tracing (445.382 µs) : 425, 466
. : milestone, 445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1474
. : milestone, 1463,
appsec (2.331 ms) : 2291, 2372
. : milestone, 2331,
iast (2.041 ms) : 1992, 2089
. : milestone, 2041,
iast_GLOBAL (2.099 ms) : 2048, 2149
. : milestone, 2099,
profiling (1.922 ms) : 1882, 1961
. : milestone, 1922,
tracing (1.9 ms) : 1861, 1938
. : milestone, 1900,
section candidate
no_agent (1.461 ms) : 1449, 1472
. : milestone, 1461,
appsec (2.303 ms) : 2262, 2344
. : milestone, 2303,
iast (2.054 ms) : 2005, 2103
. : milestone, 2054,
iast_GLOBAL (2.083 ms) : 2033, 2132
. : milestone, 2083,
profiling (1.931 ms) : 1889, 1973
. : milestone, 1931,
tracing (1.906 ms) : 1868, 1944
. : milestone, 1906,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~6a59de1f20, baseline=1.40.0-SNAPSHOT~b4718bd887
dateFormat X
axisFormat %s
section baseline
no_agent (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
appsec (15.365 s) : 15365000, 15365000
. : milestone, 15365000,
iast (18.668 s) : 18668000, 18668000
. : milestone, 18668000,
iast_GLOBAL (18.03 s) : 18030000, 18030000
. : milestone, 18030000,
profiling (15.229 s) : 15229000, 15229000
. : milestone, 15229000,
tracing (15.254 s) : 15254000, 15254000
. : milestone, 15254000,
section candidate
no_agent (15.797 s) : 15797000, 15797000
. : milestone, 15797000,
appsec (15.315 s) : 15315000, 15315000
. : milestone, 15315000,
iast (18.85 s) : 18850000, 18850000
. : milestone, 18850000,
iast_GLOBAL (17.876 s) : 17876000, 17876000
. : milestone, 17876000,
profiling (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
tracing (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]