Support DD_TRACE_<INTEGRATION>_ENABLED #7718

mtoffl01 · 2024-10-02T21:28:11Z

What Does This Do

Adds support for disabling integrations via DD_TRACE_<integration-name>_ENABLED envvar. The new trace.<integration-name>.enabled config will take precedence over trace.integration.<name>.enabled and integration.<name>.enabled settings in that order.

Motivation

Config Consistency effort (RFC)

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-10-03T15:37:30Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/dd-integration-enabled
git_commit_date	1728056864	1728066060
git_commit_sha	`fd84e8c`	`ff768b5`
release_version	1.41.0-SNAPSHOT~fd84e8c84a	1.41.0-SNAPSHOT~ff768b5317

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1728068474	1728068474
ci_job_id	662308383	662308383
ci_pipeline_id	45867887	45867887
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 10 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:AppSec	worse [+2.008ms; +6.626ms] or [+3.753%; +12.386%]	57.813ms	53.496ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076088
Total [baseline] (10.451 s) : 0, 10450813
Agent [candidate] (1.078 s) : 0, 1078133
Total [candidate] (10.364 s) : 0, 10364454
section appsec
Agent [baseline] (1.202 s) : 0, 1202422
Total [baseline] (10.576 s) : 0, 10576063
Agent [candidate] (1.21 s) : 0, 1210095
Total [candidate] (10.586 s) : 0, 10586031
section iast
Agent [baseline] (1.205 s) : 0, 1205156
Total [baseline] (10.928 s) : 0, 10927601
Agent [candidate] (1.205 s) : 0, 1204709
Total [candidate] (10.965 s) : 0, 10965142
section profiling
Agent [baseline] (1.275 s) : 0, 1275099
Total [baseline] (10.659 s) : 0, 10658981
Agent [candidate] (1.287 s) : 0, 1287320
Total [candidate] (10.749 s) : 0, 10748920

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.076 s	-
Agent	appsec	1.202 s	126.334 ms (11.7%)
Agent	iast	1.205 s	129.068 ms (12.0%)
Agent	profiling	1.275 s	199.012 ms (18.5%)
Total	tracing	10.451 s	-
Total	appsec	10.576 s	125.25 ms (1.2%)
Total	iast	10.928 s	476.788 ms (4.6%)
Total	profiling	10.659 s	208.168 ms (2.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.078 s	-
Agent	appsec	1.21 s	131.962 ms (12.2%)
Agent	iast	1.205 s	126.576 ms (11.7%)
Agent	profiling	1.287 s	209.187 ms (19.4%)
Total	tracing	10.364 s	-
Total	appsec	10.586 s	221.577 ms (2.1%)
Total	iast	10.965 s	600.688 ms (5.8%)
Total	profiling	10.749 s	384.466 ms (3.7%)

gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.416 ms) : 0, 687416
BytebuddyAgent [candidate] (688.865 ms) : 0, 688865
GlobalTracer [baseline] (312.448 ms) : 0, 312448
GlobalTracer [candidate] (312.923 ms) : 0, 312923
AppSec [baseline] (54.122 ms) : 0, 54122
AppSec [candidate] (54.179 ms) : 0, 54179
Remote Config [baseline] (668.438 µs) : 0, 668
Remote Config [candidate] (671.488 µs) : 0, 671
Telemetry [baseline] (7.646 ms) : 0, 7646
Telemetry [candidate] (7.774 ms) : 0, 7774
section appsec
BytebuddyAgent [baseline] (698.353 ms) : 0, 698353
BytebuddyAgent [candidate] (703.716 ms) : 0, 703716
GlobalTracer [baseline] (307.197 ms) : 0, 307197
GlobalTracer [candidate] (308.279 ms) : 0, 308279
AppSec [baseline] (163.672 ms) : 0, 163672
AppSec [candidate] (165.074 ms) : 0, 165074
Remote Config [baseline] (635.612 µs) : 0, 636
Remote Config [candidate] (639.966 µs) : 0, 640
Telemetry [baseline] (8.144 ms) : 0, 8144
Telemetry [candidate] (8.23 ms) : 0, 8230
IAST [baseline] (21.485 ms) : 0, 21485
IAST [candidate] (20.889 ms) : 0, 20889
section iast
BytebuddyAgent [baseline] (803.665 ms) : 0, 803665
BytebuddyAgent [candidate] (803.333 ms) : 0, 803333
GlobalTracer [baseline] (301.322 ms) : 0, 301322
GlobalTracer [candidate] (300.746 ms) : 0, 300746
AppSec [baseline] (54.949 ms) : 0, 54949
AppSec [candidate] (58.178 ms) : 0, 58178
Remote Config [baseline] (613.971 µs) : 0, 614
Remote Config [candidate] (617.79 µs) : 0, 618
Telemetry [baseline] (7.859 ms) : 0, 7859
Telemetry [candidate] (7.22 ms) : 0, 7220
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (20.884 ms) : 0, 20884
section profiling
BytebuddyAgent [baseline] (680.42 ms) : 0, 680420
BytebuddyAgent [candidate] (686.788 ms) : 0, 686788
GlobalTracer [baseline] (395.053 ms) : 0, 395053
GlobalTracer [candidate] (397.814 ms) : 0, 397814
AppSec [baseline] (55.109 ms) : 0, 55109
AppSec [candidate] (55.576 ms) : 0, 55576
Remote Config [baseline] (664.549 µs) : 0, 665
Remote Config [candidate] (670.586 µs) : 0, 671
Telemetry [baseline] (7.593 ms) : 0, 7593
Telemetry [candidate] (13.163 ms) : 0, 13163
ProfilingAgent [baseline] (97.249 ms) : 0, 97249
ProfilingAgent [candidate] (94.145 ms) : 0, 94145
Profiling [baseline] (97.273 ms) : 0, 97273
Profiling [candidate] (94.169 ms) : 0, 94169

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072126
Total [baseline] (8.573 s) : 0, 8572505
Agent [candidate] (1.081 s) : 0, 1081054
Total [candidate] (8.628 s) : 0, 8627801
section iast
Agent [baseline] (1.197 s) : 0, 1196763
Total [baseline] (9.089 s) : 0, 9088923
Agent [candidate] (1.206 s) : 0, 1206426
Total [candidate] (9.095 s) : 0, 9094858
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.196 s) : 0, 1196126
Total [baseline] (9.09 s) : 0, 9089655
Agent [candidate] (1.2 s) : 0, 1199534
Total [candidate] (9.12 s) : 0, 9120392
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1193386
Total [baseline] (9.085 s) : 0, 9085158
Agent [candidate] (1.197 s) : 0, 1196964
Total [candidate] (9.101 s) : 0, 9101207

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.072 s	-
Agent	iast	1.197 s	124.637 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.196 s	123.999 ms (11.6%)
Agent	iast_TELEMETRY_OFF	1.193 s	121.259 ms (11.3%)
Total	tracing	8.573 s	-
Total	iast	9.089 s	516.417 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.09 s	517.149 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.085 s	512.653 ms (6.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.206 s	125.372 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.2 s	118.48 ms (11.0%)
Agent	iast_TELEMETRY_OFF	1.197 s	115.91 ms (10.7%)
Total	tracing	8.628 s	-
Total	iast	9.095 s	467.057 ms (5.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.12 s	492.592 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.101 s	473.407 ms (5.5%)

gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.416 ms) : 0, 683416
BytebuddyAgent [candidate] (689.569 ms) : 0, 689569
GlobalTracer [baseline] (312.515 ms) : 0, 312515
GlobalTracer [candidate] (314.213 ms) : 0, 314213
AppSec [baseline] (54.143 ms) : 0, 54143
AppSec [candidate] (54.96 ms) : 0, 54960
Remote Config [baseline] (669.895 µs) : 0, 670
Remote Config [candidate] (697.292 µs) : 0, 697
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (7.834 ms) : 0, 7834
section iast
BytebuddyAgent [baseline] (796.793 ms) : 0, 796793
BytebuddyAgent [candidate] (805.322 ms) : 0, 805322
GlobalTracer [baseline] (299.503 ms) : 0, 299503
GlobalTracer [candidate] (301.54 ms) : 0, 301540
AppSec [baseline] (51.845 ms) : 0, 51845
AppSec [candidate] (56.063 ms) : 0, 56063
Remote Config [baseline] (601.037 µs) : 0, 601
Remote Config [candidate] (594.192 µs) : 0, 594
Telemetry [baseline] (7.045 ms) : 0, 7045
Telemetry [candidate] (7.029 ms) : 0, 7029
IAST [baseline] (27.238 ms) : 0, 27238
IAST [candidate] (22.065 ms) : 0, 22065
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.979 ms) : 0, 795979
BytebuddyAgent [candidate] (799.012 ms) : 0, 799012
GlobalTracer [baseline] (299.995 ms) : 0, 299995
GlobalTracer [candidate] (300.316 ms) : 0, 300316
AppSec [baseline] (53.496 ms) : 0, 53496
AppSec [candidate] (57.813 ms) : 0, 57813
Remote Config [baseline] (605.942 µs) : 0, 606
Remote Config [candidate] (617.197 µs) : 0, 617
Telemetry [baseline] (7.014 ms) : 0, 7014
Telemetry [candidate] (7.196 ms) : 0, 7196
IAST [baseline] (25.254 ms) : 0, 25254
IAST [candidate] (20.838 ms) : 0, 20838
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.97 ms) : 0, 793970
BytebuddyAgent [candidate] (797.928 ms) : 0, 797928
GlobalTracer [baseline] (299.955 ms) : 0, 299955
GlobalTracer [candidate] (299.84 ms) : 0, 299840
AppSec [baseline] (54.42 ms) : 0, 54420
AppSec [candidate] (57.489 ms) : 0, 57489
Remote Config [baseline] (616.21 µs) : 0, 616
Remote Config [candidate] (615.826 µs) : 0, 616
Telemetry [baseline] (6.957 ms) : 0, 6957
Telemetry [candidate] (7.129 ms) : 0, 7129
IAST [baseline] (23.693 ms) : 0, 23693
IAST [candidate] (20.174 ms) : 0, 20174

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-10-04T18:31:52	2024-10-04T18:38:42
git_branch	master	mtoff/dd-integration-enabled
git_commit_date	1728056864	1728066060
git_commit_sha	`fd84e8c`	`ff768b5`
release_version	1.41.0-SNAPSHOT~fd84e8c84a	1.41.0-SNAPSHOT~ff768b5317
start_time	2024-10-04T18:31:38	2024-10-04T18:38:28

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1728067467	1728067467
ci_job_id	662308384	662308384
ci_pipeline_id	45867887	45867887
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1352
.   : milestone, 1332,
appsec (1.705 ms) : 1680, 1730
.   : milestone, 1705,
appsec_no_iast (1.703 ms) : 1679, 1727
.   : milestone, 1703,
iast (1.473 ms) : 1450, 1496
.   : milestone, 1473,
profiling (1.474 ms) : 1449, 1498
.   : milestone, 1474,
tracing (1.475 ms) : 1451, 1499
.   : milestone, 1475,
section candidate
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.705 ms) : 1683, 1728
.   : milestone, 1705,
appsec_no_iast (1.705 ms) : 1681, 1729
.   : milestone, 1705,
iast (1.48 ms) : 1458, 1502
.   : milestone, 1480,
profiling (1.487 ms) : 1463, 1512
.   : milestone, 1487,
tracing (1.448 ms) : 1423, 1472
.   : milestone, 1448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.332 ms [1.312 ms, 1.352 ms]	-
appsec	1.705 ms [1.68 ms, 1.73 ms]	372.829 µs (28.0%)
appsec_no_iast	1.703 ms [1.679 ms, 1.727 ms]	370.772 µs (27.8%)
iast	1.473 ms [1.45 ms, 1.496 ms]	140.714 µs (10.6%)
profiling	1.474 ms [1.449 ms, 1.498 ms]	141.44 µs (10.6%)
tracing	1.475 ms [1.451 ms, 1.499 ms]	143.112 µs (10.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.338 ms [1.319 ms, 1.357 ms]	-
appsec	1.705 ms [1.683 ms, 1.728 ms]	366.969 µs (27.4%)
appsec_no_iast	1.705 ms [1.681 ms, 1.729 ms]	366.824 µs (27.4%)
iast	1.48 ms [1.458 ms, 1.502 ms]	141.672 µs (10.6%)
profiling	1.487 ms [1.463 ms, 1.512 ms]	149.108 µs (11.1%)
tracing	1.448 ms [1.423 ms, 1.472 ms]	109.383 µs (8.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.543 µs) : 358, 397
.   : milestone, 378,
iast (483.742 µs) : 462, 505
.   : milestone, 484,
iast_FULL (545.902 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (509.392 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (485.171 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (447.47 µs) : 426, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (475.609 µs) : 454, 497
.   : milestone, 476,
tracing (444.689 µs) : 424, 465
.   : milestone, 445,
section candidate
no_agent (371.022 µs) : 352, 390
.   : milestone, 371,
iast (477.71 µs) : 457, 499
.   : milestone, 478,
iast_FULL (550.052 µs) : 529, 572
.   : milestone, 550,
iast_GLOBAL (504.76 µs) : 483, 526
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (479.877 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (445.53 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (473.761 µs) : 452, 495
.   : milestone, 474,
tracing (444.317 µs) : 424, 465
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.543 µs [357.585 µs, 397.5 µs]	-
iast	483.742 µs [462.278 µs, 505.206 µs]	106.2 µs (28.1%)
iast_FULL	545.902 µs [524.699 µs, 567.105 µs]	168.36 µs (44.6%)
iast_GLOBAL	509.392 µs [487.294 µs, 531.49 µs]	131.849 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED	485.171 µs [464.012 µs, 506.329 µs]	107.628 µs (28.5%)
iast_INACTIVE	447.47 µs [426.332 µs, 468.608 µs]	69.927 µs (18.5%)
iast_TELEMETRY_OFF	475.609 µs [454.356 µs, 496.863 µs]	98.067 µs (26.0%)
tracing	444.689 µs [424.242 µs, 465.136 µs]	67.147 µs (17.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.022 µs [351.68 µs, 390.365 µs]	-
iast	477.71 µs [456.727 µs, 498.694 µs]	106.688 µs (28.8%)
iast_FULL	550.052 µs [528.59 µs, 571.515 µs]	179.03 µs (48.3%)
iast_GLOBAL	504.76 µs [483.07 µs, 526.449 µs]	133.737 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED	479.877 µs [458.953 µs, 500.801 µs]	108.854 µs (29.3%)
iast_INACTIVE	445.53 µs [424.896 µs, 466.163 µs]	74.507 µs (20.1%)
iast_TELEMETRY_OFF	473.761 µs [452.263 µs, 495.258 µs]	102.738 µs (27.7%)
tracing	444.317 µs [423.859 µs, 464.775 µs]	73.294 µs (19.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/dd-integration-enabled
git_commit_date	1728056864	1728066060
git_commit_sha	`fd84e8c`	`ff768b5`
release_version	1.41.0-SNAPSHOT~fd84e8c84a	1.41.0-SNAPSHOT~ff768b5317

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1728067998	1728067998
ci_job_id	662308385	662308385
ci_pipeline_id	45867887	45867887
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.186 s) : 15186000, 15186000
.   : milestone, 15186000,
appsec (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
iast (19.185 s) : 19185000, 19185000
.   : milestone, 19185000,
iast_GLOBAL (18.122 s) : 18122000, 18122000
.   : milestone, 18122000,
profiling (15.816 s) : 15816000, 15816000
.   : milestone, 15816000,
tracing (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
section candidate
no_agent (15.803 s) : 15803000, 15803000
.   : milestone, 15803000,
appsec (15.243 s) : 15243000, 15243000
.   : milestone, 15243000,
iast (18.906 s) : 18906000, 18906000
.   : milestone, 18906000,
iast_GLOBAL (17.682 s) : 17682000, 17682000
.   : milestone, 17682000,
profiling (15.68 s) : 15680000, 15680000
.   : milestone, 15680000,
tracing (15.177 s) : 15177000, 15177000
.   : milestone, 15177000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.186 s [15.186 s, 15.186 s]	-
appsec	15.003 s [15.003 s, 15.003 s]	-183.0 ms (-1.2%)
iast	19.185 s [19.185 s, 19.185 s]	3.999 s (26.3%)
iast_GLOBAL	18.122 s [18.122 s, 18.122 s]	2.936 s (19.3%)
profiling	15.816 s [15.816 s, 15.816 s]	630.0 ms (4.1%)
tracing	15.12 s [15.12 s, 15.12 s]	-66.0 ms (-0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.803 s [15.803 s, 15.803 s]	-
appsec	15.243 s [15.243 s, 15.243 s]	-560.0 ms (-3.5%)
iast	18.906 s [18.906 s, 18.906 s]	3.103 s (19.6%)
iast_GLOBAL	17.682 s [17.682 s, 17.682 s]	1.879 s (11.9%)
profiling	15.68 s [15.68 s, 15.68 s]	-123.0 ms (-0.8%)
tracing	15.177 s [15.177 s, 15.177 s]	-626.0 ms (-4.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~ff768b5317, baseline=1.41.0-SNAPSHOT~fd84e8c84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.313 ms) : 2272, 2354
.   : milestone, 2313,
iast (2.064 ms) : 2012, 2116
.   : milestone, 2064,
iast_GLOBAL (2.114 ms) : 2061, 2166
.   : milestone, 2114,
profiling (2.421 ms) : 2233, 2608
.   : milestone, 2421,
tracing (1.908 ms) : 1869, 1947
.   : milestone, 1908,
section candidate
no_agent (1.46 ms) : 1449, 1471
.   : milestone, 1460,
appsec (2.304 ms) : 2263, 2345
.   : milestone, 2304,
iast (2.066 ms) : 2013, 2118
.   : milestone, 2066,
iast_GLOBAL (2.106 ms) : 2054, 2158
.   : milestone, 2106,
profiling (1.929 ms) : 1888, 1970
.   : milestone, 1929,
tracing (1.905 ms) : 1866, 1945
.   : milestone, 1905,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.459 ms [1.448 ms, 1.471 ms]	-
appsec	2.313 ms [2.272 ms, 2.354 ms]	853.256 µs (58.5%)
iast	2.064 ms [2.012 ms, 2.116 ms]	604.656 µs (41.4%)
iast_GLOBAL	2.114 ms [2.061 ms, 2.166 ms]	654.081 µs (44.8%)
profiling	2.421 ms [2.233 ms, 2.608 ms]	961.524 µs (65.9%)
tracing	1.908 ms [1.869 ms, 1.947 ms]	448.55 µs (30.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.46 ms [1.449 ms, 1.471 ms]	-
appsec	2.304 ms [2.263 ms, 2.345 ms]	844.141 µs (57.8%)
iast	2.066 ms [2.013 ms, 2.118 ms]	605.682 µs (41.5%)
iast_GLOBAL	2.106 ms [2.054 ms, 2.158 ms]	646.153 µs (44.3%)
profiling	1.929 ms [1.888 ms, 1.97 ms]	469.072 µs (32.1%)
tracing	1.905 ms [1.866 ms, 1.945 ms]	445.359 µs (30.5%)

internal-api/src/test/groovy/datadog/trace/api/InstrumenterConfigTest.groovy

mtoffl01 changed the title ~~Support DD_<INTEGRATION>_ENABLED~~ Support DD_TRACE_<INTEGRATION>_ENABLED Oct 3, 2024

mtoffl01 commented Oct 3, 2024

View reviewed changes

internal-api/src/test/groovy/datadog/trace/api/InstrumenterConfigTest.groovy Outdated Show resolved Hide resolved

mtoffl01 marked this pull request as ready for review October 3, 2024 18:50

mtoffl01 requested a review from a team as a code owner October 3, 2024 18:50

mtoffl01 requested a review from ygree October 3, 2024 18:50

mtoffl01 marked this pull request as draft October 4, 2024 15:06

Support and prioritize DD_TRACE_<INTEGRATION-NAME>_ENABLED feature

ff768b5

mtoffl01 force-pushed the mtoff/dd-integration-enabled branch from 3135dac to ff768b5 Compare October 4, 2024 18:22

mtoffl01 marked this pull request as ready for review October 4, 2024 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support DD_TRACE_<INTEGRATION>_ENABLED #7718

Support DD_TRACE_<INTEGRATION>_ENABLED #7718

mtoffl01 commented Oct 2, 2024 •

edited

Loading

pr-commenter bot commented Oct 3, 2024 •

edited

Loading

Support DD_TRACE_<INTEGRATION>_ENABLED #7718

Are you sure you want to change the base?

Support DD_TRACE_<INTEGRATION>_ENABLED #7718

Conversation

mtoffl01 commented Oct 2, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Oct 3, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

mtoffl01 commented Oct 2, 2024 •

edited

Loading

pr-commenter bot commented Oct 3, 2024 •

edited

Loading