rename the DebuggerProbe to TriggerProbe #7737
Draft
+67
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -226,7 +226,7 @@ public Configuration.Builder add(Collection<? extends ProbeDefinition> definitio | |||
| } | |||
| for (ProbeDefinition definition : definitions) { | |||
| if (definition instanceof MetricProbe) add((MetricProbe) definition); | |||
| if (definition instanceof DebuggerProbe) add((DebuggerProbe) definition); | |||
| if (definition instanceof TriggerProbe) add((TriggerProbe) definition); | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| if (definition instanceof TriggerProbe) add((TriggerProbe) definition); | |
| if (definition instanceof TriggerProbe) {add((TriggerProbe) definition)}; |
single if statement should be wrapped in a brace (...read more)
Omitting braces {} is valid in multiple statements, such as, for loops, if statements, and while loops. However, enforcing the use of control braces throughout your codebase will make the code more consistent and can make it easier to add statements in the future.
| @@ -161,7 +161,7 @@ public void commit(PollingRateHinter pollingRateHinter) { | |||
|
|
|||
| static class DefinitionBuilder { | |||
| private final Collection<ProbeDefinition> definitions = new ArrayList<>(); | |||
| private int debuggerProbeCount = 0; | |||
| private int triggerProbeCount = 0; | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
Suggested change
| private int triggerProbeCount = 0; | |
| private int triggerProbeCount; |
Remove initialization, this is already the default value. (...read more)
When initializing fields, prevent initializing fields to the default value. Any additional initialization means more bytecode instructions, and allocating many of these objects may impact your application performance.
If you initialize to a default value, remove the initialization.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (302.001 µs) : 264, 340
. : milestone, 302,
basic (296.534 µs) : 285, 308
. : milestone, 297,
loop (10.287 ms) : 10251, 10323
. : milestone, 10287,
section candidate
noprobe (302.963 µs) : 272, 334
. : milestone, 303,
basic (307.121 µs) : 298, 316
. : milestone, 307,
loop (11.118 ms) : 11061, 11174
. : milestone, 11118,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074342
Total [baseline] (10.379 s) : 0, 10379491
Agent [candidate] (1.067 s) : 0, 1067132
Total [candidate] (10.417 s) : 0, 10417452
section appsec
Agent [baseline] (1.201 s) : 0, 1200523
Total [baseline] (10.645 s) : 0, 10644581
Agent [candidate] (1.2 s) : 0, 1199721
Total [candidate] (10.579 s) : 0, 10579428
section iast
Agent [baseline] (1.196 s) : 0, 1195542
Total [baseline] (10.836 s) : 0, 10836022
Agent [candidate] (1.204 s) : 0, 1203748
Total [candidate] (10.85 s) : 0, 10850006
section profiling
Agent [baseline] (1.267 s) : 0, 1266888
Total [baseline] (10.604 s) : 0, 10603606
Agent [candidate] (1.275 s) : 0, 1275461
Total [candidate] (10.629 s) : 0, 10629427
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.446 ms) : 0, 685446
BytebuddyAgent [candidate] (680.823 ms) : 0, 680823
GlobalTracer [baseline] (312.562 ms) : 0, 312562
GlobalTracer [candidate] (310.705 ms) : 0, 310705
AppSec [baseline] (54.247 ms) : 0, 54247
AppSec [candidate] (53.679 ms) : 0, 53679
Remote Config [baseline] (664.059 µs) : 0, 664
Remote Config [candidate] (662.749 µs) : 0, 663
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.604 ms) : 0, 7604
section appsec
BytebuddyAgent [baseline] (697.728 ms) : 0, 697728
BytebuddyAgent [candidate] (697.57 ms) : 0, 697570
GlobalTracer [baseline] (307.501 ms) : 0, 307501
GlobalTracer [candidate] (307.519 ms) : 0, 307519
AppSec [baseline] (160.988 ms) : 0, 160988
AppSec [candidate] (161.727 ms) : 0, 161727
Remote Config [baseline] (638.956 µs) : 0, 639
Remote Config [candidate] (642.163 µs) : 0, 642
Telemetry [baseline] (8.151 ms) : 0, 8151
Telemetry [candidate] (8.208 ms) : 0, 8208
IAST [baseline] (23.719 ms) : 0, 23719
IAST [candidate] (20.833 ms) : 0, 20833
section iast
BytebuddyAgent [baseline] (796.285 ms) : 0, 796285
BytebuddyAgent [candidate] (801.997 ms) : 0, 801997
GlobalTracer [baseline] (300.012 ms) : 0, 300012
GlobalTracer [candidate] (301.275 ms) : 0, 301275
AppSec [baseline] (56.637 ms) : 0, 56637
AppSec [candidate] (54.322 ms) : 0, 54322
Remote Config [baseline] (611.224 µs) : 0, 611
Remote Config [candidate] (609.932 µs) : 0, 610
Telemetry [baseline] (7.131 ms) : 0, 7131
Telemetry [candidate] (7.827 ms) : 0, 7827
IAST [baseline] (21.183 ms) : 0, 21183
IAST [candidate] (23.942 ms) : 0, 23942
section profiling
BytebuddyAgent [baseline] (675.151 ms) : 0, 675151
BytebuddyAgent [candidate] (680.127 ms) : 0, 680127
GlobalTracer [baseline] (393.343 ms) : 0, 393343
GlobalTracer [candidate] (396.274 ms) : 0, 396274
AppSec [baseline] (54.824 ms) : 0, 54824
AppSec [candidate] (54.897 ms) : 0, 54897
Remote Config [baseline] (657.05 µs) : 0, 657
Remote Config [candidate] (658.907 µs) : 0, 659
Telemetry [baseline] (7.446 ms) : 0, 7446
Telemetry [candidate] (7.501 ms) : 0, 7501
ProfilingAgent [baseline] (96.857 ms) : 0, 96857
ProfilingAgent [candidate] (97.137 ms) : 0, 97137
Profiling [baseline] (96.881 ms) : 0, 96881
Profiling [candidate] (97.16 ms) : 0, 97160
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075980
Total [baseline] (8.56 s) : 0, 8559676
Agent [candidate] (1.067 s) : 0, 1067043
Total [candidate] (8.572 s) : 0, 8572395
section iast
Agent [baseline] (1.196 s) : 0, 1195794
Total [baseline] (9.065 s) : 0, 9065093
Agent [candidate] (1.203 s) : 0, 1203336
Total [candidate] (9.092 s) : 0, 9091605
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.197 s) : 0, 1197459
Total [baseline] (9.099 s) : 0, 9099196
Agent [candidate] (1.201 s) : 0, 1200714
Total [candidate] (9.102 s) : 0, 9101998
section iast_TELEMETRY_OFF
Agent [baseline] (1.201 s) : 0, 1200511
Total [baseline] (9.095 s) : 0, 9095152
Agent [candidate] (1.199 s) : 0, 1199470
Total [candidate] (9.085 s) : 0, 9084773
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.837 ms) : 0, 686837
BytebuddyAgent [candidate] (681.033 ms) : 0, 681033
GlobalTracer [baseline] (313.064 ms) : 0, 313064
GlobalTracer [candidate] (310.378 ms) : 0, 310378
AppSec [baseline] (53.921 ms) : 0, 53921
AppSec [candidate] (53.75 ms) : 0, 53750
Remote Config [baseline] (690.864 µs) : 0, 691
Remote Config [candidate] (664.482 µs) : 0, 664
Telemetry [baseline] (7.674 ms) : 0, 7674
Telemetry [candidate] (7.567 ms) : 0, 7567
section iast
BytebuddyAgent [baseline] (796.849 ms) : 0, 796849
BytebuddyAgent [candidate] (801.96 ms) : 0, 801960
GlobalTracer [baseline] (299.781 ms) : 0, 299781
GlobalTracer [candidate] (301.167 ms) : 0, 301167
AppSec [baseline] (55.061 ms) : 0, 55061
AppSec [candidate] (54.149 ms) : 0, 54149
Remote Config [baseline] (602.741 µs) : 0, 603
Remote Config [candidate] (611.318 µs) : 0, 611
Telemetry [baseline] (7.072 ms) : 0, 7072
Telemetry [candidate] (7.057 ms) : 0, 7057
IAST [baseline] (22.685 ms) : 0, 22685
IAST [candidate] (24.576 ms) : 0, 24576
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.867 ms) : 0, 796867
BytebuddyAgent [candidate] (800.03 ms) : 0, 800030
GlobalTracer [baseline] (300.821 ms) : 0, 300821
GlobalTracer [candidate] (300.403 ms) : 0, 300403
AppSec [baseline] (56.314 ms) : 0, 56314
AppSec [candidate] (54.336 ms) : 0, 54336
Remote Config [baseline] (616.639 µs) : 0, 617
Remote Config [candidate] (613.188 µs) : 0, 613
Telemetry [baseline] (7.07 ms) : 0, 7070
Telemetry [candidate] (7.112 ms) : 0, 7112
IAST [baseline] (22.006 ms) : 0, 22006
IAST [candidate] (24.387 ms) : 0, 24387
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.849 ms) : 0, 798849
BytebuddyAgent [candidate] (797.704 ms) : 0, 797704
GlobalTracer [baseline] (301.834 ms) : 0, 301834
GlobalTracer [candidate] (301.63 ms) : 0, 301630
AppSec [baseline] (55.643 ms) : 0, 55643
AppSec [candidate] (55.584 ms) : 0, 55584
Remote Config [baseline] (629.202 µs) : 0, 629
Remote Config [candidate] (614.63 µs) : 0, 615
Telemetry [baseline] (7.099 ms) : 0, 7099
Telemetry [candidate] (6.919 ms) : 0, 6919
IAST [baseline] (22.648 ms) : 0, 22648
IAST [candidate] (23.246 ms) : 0, 23246
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
. : milestone, 1355,
appsec (1.739 ms) : 1716, 1763
. : milestone, 1739,
appsec_no_iast (1.714 ms) : 1690, 1738
. : milestone, 1714,
iast (1.476 ms) : 1454, 1499
. : milestone, 1476,
profiling (1.529 ms) : 1503, 1555
. : milestone, 1529,
tracing (1.465 ms) : 1441, 1489
. : milestone, 1465,
section candidate
no_agent (1.33 ms) : 1309, 1351
. : milestone, 1330,
appsec (1.721 ms) : 1697, 1746
. : milestone, 1721,
appsec_no_iast (1.729 ms) : 1706, 1753
. : milestone, 1729,
iast (1.467 ms) : 1445, 1490
. : milestone, 1467,
profiling (1.457 ms) : 1434, 1480
. : milestone, 1457,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section baseline
no_agent (369.378 µs) : 349, 390
. : milestone, 369,
iast (481.671 µs) : 460, 503
. : milestone, 482,
iast_FULL (551.338 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (503.272 µs) : 482, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (486.256 µs) : 465, 508
. : milestone, 486,
iast_INACTIVE (444.026 µs) : 424, 465
. : milestone, 444,
iast_TELEMETRY_OFF (471.609 µs) : 450, 493
. : milestone, 472,
tracing (434.25 µs) : 414, 455
. : milestone, 434,
section candidate
no_agent (372.409 µs) : 350, 395
. : milestone, 372,
iast (480.695 µs) : 460, 502
. : milestone, 481,
iast_FULL (556.669 µs) : 535, 578
. : milestone, 557,
iast_GLOBAL (508.346 µs) : 487, 530
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (489.578 µs) : 468, 511
. : milestone, 490,
iast_INACTIVE (443.374 µs) : 423, 464
. : milestone, 443,
iast_TELEMETRY_OFF (467.963 µs) : 447, 489
. : milestone, 468,
tracing (445.396 µs) : 425, 466
. : milestone, 445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section baseline
no_agent (15.071 s) : 15071000, 15071000
. : milestone, 15071000,
appsec (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
iast (19.011 s) : 19011000, 19011000
. : milestone, 19011000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
. : milestone, 17878000,
profiling (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
tracing (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
section candidate
no_agent (15.568 s) : 15568000, 15568000
. : milestone, 15568000,
appsec (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
iast (18.982 s) : 18982000, 18982000
. : milestone, 18982000,
iast_GLOBAL (18.097 s) : 18097000, 18097000
. : milestone, 18097000,
profiling (15.234 s) : 15234000, 15234000
. : milestone, 15234000,
tracing (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~addfed4906, baseline=1.41.0-SNAPSHOT~fd84e8c84a
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.309 ms) : 2268, 2350
. : milestone, 2309,
iast (2.067 ms) : 2015, 2119
. : milestone, 2067,
iast_GLOBAL (2.117 ms) : 2065, 2170
. : milestone, 2117,
profiling (1.929 ms) : 1888, 1970
. : milestone, 1929,
tracing (1.9 ms) : 1861, 1938
. : milestone, 1900,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.324 ms) : 2282, 2365
. : milestone, 2324,
iast (2.068 ms) : 2016, 2120
. : milestone, 2068,
iast_GLOBAL (2.108 ms) : 2055, 2160
. : milestone, 2108,
profiling (1.926 ms) : 1884, 1968
. : milestone, 1926,
tracing (1.906 ms) : 1867, 1945
. : milestone, 1906,
|
jpbempel
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Renames the
DebuggerProbetoTriggerProbeand updates all references accordingly.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-2952