chore(eslint): remove redundant iteration guards

## Summary

Remove iteration guards where repository-owned callers always provide required collections.

## Why

The Unicorn migration should only add defensive branches at genuinely optional or third-party boundaries. Keeping impossible checks would hide broken internal contracts.

## Test plan

- Run the focused Bedrock, remote config, telemetry, WebdriverIO, Vitest, and Jest plugin suites.
- Run `npm run lint`.

Author: BridgeAR

packages/datadog-instrumentations/src/jest/coverage-backfill.js

@@ -14,13 +14,11 @@ const TRANSFORM_OPTIONS = {
 
 function getCoverageBackfillFiles (skippableSuitesCoverage, rootDir, getTestSuitePath) {
   const files = []
-  if (skippableSuitesCoverage) {
-    for (const filename of Object.keys(skippableSuitesCoverage)) {
-      const relativeFilename = path.isAbsolute(filename)
-        ? getTestSuitePath(filename, rootDir)
-        : filename
-      files.push(relativeFilename)
-    }
+  for (const filename of Object.keys(skippableSuitesCoverage)) {
+    const relativeFilename = path.isAbsolute(filename)
+      ? getTestSuitePath(filename, rootDir)
+      : filename
+    files.push(relativeFilename)
   }
   return files
 }

packages/datadog-instrumentations/src/mocha/worker.js

@@ -239,12 +239,9 @@ function getWebdriverioHookTest (hook) {
  */
 function adjustWebdriverioHookFailures (runner) {
   let suppressedFailures = 0
-  const failedHooks = runnerToFailedHooks.get(runner)
-  if (failedHooks) {
-    for (const { test } of failedHooks) {
-      if (isWebdriverioFailureSuppressed(test)) {
-        suppressedFailures++
-      }
+  for (const { test } of runnerToFailedHooks.get(runner)) {
+    if (isWebdriverioFailureSuppressed(test)) {
+      suppressedFailures++
     }
   }
   if (runner.stats) {
@@ -284,13 +281,10 @@ function getWebdriverioSuiteResults (runner) {
     }
   })
 
-  const failedHooks = runnerToFailedHooks.get(runner)
-  if (failedHooks) {
-    for (const { file, test } of failedHooks) {
-      const result = resultsByFile.get(file)
-      if (result && !isWebdriverioFailureSuppressed(test)) {
-        result.status = 'fail'
-      }
+  for (const { file, test } of runnerToFailedHooks.get(runner)) {
+    const result = resultsByFile.get(file)
+    if (result && !isWebdriverioFailureSuppressed(test)) {
+      result.status = 'fail'
     }
   }
 

packages/datadog-instrumentations/src/vitest-worker.js

@@ -137,13 +137,9 @@ function isFileInRepository (filename, repositoryRoot) {
 }
 
 function isV8ScriptCovered (scriptCoverage) {
-  if (scriptCoverage.functions) {
-    for (const functionCoverage of scriptCoverage.functions) {
-      if (functionCoverage.ranges) {
-        for (const range of functionCoverage.ranges) {
-          if (range.count > 0) return true
-        }
-      }
+  for (const functionCoverage of scriptCoverage.functions) {
+    for (const range of functionCoverage.ranges) {
+      if (range.count > 0) return true
     }
   }
   return false

packages/datadog-plugin-aws-sdk/src/services/bedrockruntime/utils.js

@@ -650,31 +650,29 @@ function extractTextAndResponseReasonConverseFromStream (chunks) {
   let usage = {}
   const blocksByIdx = new Map()
 
-  if (chunks) {
-    for (const chunk of chunks) {
-      if (chunk.messageStart?.role) {
-        role = chunk.messageStart.role
-      } else if (chunk.messageStop?.stopReason) {
-        stopReason = chunk.messageStop.stopReason
-      } else if (chunk.metadata?.usage) {
-        usage = chunk.metadata.usage
-      } else if (chunk.contentBlockStart?.start?.toolUse) {
-        const { contentBlockIndex, start: { toolUse } } = chunk.contentBlockStart
-        blocksByIdx.set(contentBlockIndex, {
-          toolUse: { toolUseId: toolUse.toolUseId, name: toolUse.name, inputStr: '' },
-        })
-      } else if (chunk.contentBlockDelta) {
-        const { contentBlockIndex, delta } = chunk.contentBlockDelta
-        if (typeof delta?.text === 'string') {
-          const block = blocksByIdx.get(contentBlockIndex) ?? {}
-          block.text = (block.text ?? '') + delta.text
-          blocksByIdx.set(contentBlockIndex, block)
-        } else if (typeof delta?.toolUse?.input === 'string') {
-          const block = blocksByIdx.get(contentBlockIndex) ?? { toolUse: { inputStr: '' } }
-          block.toolUse ??= { inputStr: '' }
-          block.toolUse.inputStr += delta.toolUse.input
-          blocksByIdx.set(contentBlockIndex, block)
-        }
+  for (const chunk of chunks) {
+    if (chunk.messageStart?.role) {
+      role = chunk.messageStart.role
+    } else if (chunk.messageStop?.stopReason) {
+      stopReason = chunk.messageStop.stopReason
+    } else if (chunk.metadata?.usage) {
+      usage = chunk.metadata.usage
+    } else if (chunk.contentBlockStart?.start?.toolUse) {
+      const { contentBlockIndex, start: { toolUse } } = chunk.contentBlockStart
+      blocksByIdx.set(contentBlockIndex, {
+        toolUse: { toolUseId: toolUse.toolUseId, name: toolUse.name, inputStr: '' },
+      })
+    } else if (chunk.contentBlockDelta) {
+      const { contentBlockIndex, delta } = chunk.contentBlockDelta
+      if (typeof delta?.text === 'string') {
+        const block = blocksByIdx.get(contentBlockIndex) ?? {}
+        block.text = (block.text ?? '') + delta.text
+        blocksByIdx.set(contentBlockIndex, block)
+      } else if (typeof delta?.toolUse?.input === 'string') {
+        const block = blocksByIdx.get(contentBlockIndex) ?? { toolUse: { inputStr: '' } }
+        block.toolUse ??= { inputStr: '' }
+        block.toolUse.inputStr += delta.toolUse.input
+        blocksByIdx.set(contentBlockIndex, block)
       }
     }
   }

packages/datadog-plugin-mocha/src/index.js

@@ -767,28 +767,22 @@ class MochaPlugin extends CiPlugin {
     const state = this._webdriverioJasmineState
     const results = []
     const reportedFiles = new Set()
-    const suiteStatuses = state?.suiteStatuses
-    if (suiteStatuses) {
-      for (const [file, status] of suiteStatuses) {
-        const error = state.suiteErrors.get(file)
-        const result = { file, status }
-        if (error) {
-          result.error = {
-            message: error.message,
-            stack: error.stack,
-          }
+    for (const [file, status] of state.suiteStatuses) {
+      const error = state.suiteErrors.get(file)
+      const result = { file, status }
+      if (error) {
+        result.error = {
+          message: error.message,
+          stack: error.stack,
         }
-        results.push(result)
-        reportedFiles.add(file)
       }
+      results.push(result)
+      reportedFiles.add(file)
     }
-    const specs = state?.specs
-    if (specs) {
-      for (const spec of specs) {
-        const file = normalizeJasmineFile(spec)
-        if (!reportedFiles.has(file)) {
-          results.push({ file, status: 'skip' })
-        }
+    for (const spec of state.specs) {
+      const file = normalizeJasmineFile(spec)
+      if (!reportedFiles.has(file)) {
+        results.push({ file, status: 'skip' })
       }
     }
 

packages/datadog-plugin-vitest/src/index.js

@@ -593,11 +593,9 @@ class VitestPlugin extends CiPlugin {
       isVitestNoWorkerInitActive,
       onDone,
     }) => {
-      if (requestErrorTags) {
-        for (const [tag, value] of Object.entries(requestErrorTags)) {
-          this.testSessionSpan.setTag(tag, value)
-          this.testModuleSpan.setTag(tag, value)
-        }
+      for (const [tag, value] of Object.entries(requestErrorTags)) {
+        this.testSessionSpan.setTag(tag, value)
+        this.testModuleSpan.setTag(tag, value)
       }
       this.testSessionSpan.setTag(TEST_STATUS, status)
       this.testModuleSpan.setTag(TEST_STATUS, status)

packages/dd-trace/src/config/remote_config.js

@@ -236,15 +236,13 @@ const optionLookupTable = {
 
 const transformers = {
   tracing_sampling_rules (samplingRules) {
-    if (samplingRules) {
-      for (const rule of (samplingRules)) {
-        if (rule.tags) {
-          const reformattedTags = {}
-          for (const tag of rule.tags) {
-            reformattedTags[tag.key] = tag.value_glob
-          }
-          rule.tags = reformattedTags
+    for (const rule of samplingRules) {
+      if (rule.tags) {
+        const reformattedTags = {}
+        for (const tag of rule.tags) {
+          reformattedTags[tag.key] = tag.value_glob
         }
+        rule.tags = reformattedTags
       }
     }
     return samplingRules

packages/dd-trace/src/telemetry/telemetry.js

@@ -130,17 +130,15 @@ function updateRetryData (error, retryObj) {
 
 function getIntegrations () {
   const newIntegrations = /** @type {Integration[]} */ ([])
-  if ((pluginManager._pluginsByName) != null) {
-    for (const pluginName of Object.keys(pluginManager._pluginsByName)) {
-      if (!sentIntegrations.has(pluginName)) {
-        newIntegrations.push({
-          name: pluginName,
-          enabled: pluginManager._pluginsByName[pluginName]._enabled,
-          auto_enabled: true,
-          [processTags.TELEMETRY_FIELD_NAME]: processTags.tagsObject,
-        })
-        sentIntegrations.add(pluginName)
-      }
+  for (const pluginName of Object.keys(pluginManager._pluginsByName)) {
+    if (!sentIntegrations.has(pluginName)) {
+      newIntegrations.push({
+        name: pluginName,
+        enabled: pluginManager._pluginsByName[pluginName]._enabled,
+        auto_enabled: true,
+        [processTags.TELEMETRY_FIELD_NAME]: processTags.tagsObject,
+      })
+      sentIntegrations.add(pluginName)
     }
   }
   return newIntegrations