Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazily load SDK APIs #5165

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

lazily load SDK APIs #5165

wants to merge 1 commit into from

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented Jan 29, 2025

See title

@github-actions GitHub Actions
Copy link

Overall package size

Self size: 8.54 MB
Deduped: 94.94 MB
No deduping: 95.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.0 | 9.8 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.09%. Comparing base (c0550a0) to head (8ff06d8).

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #5165       +/-   ##
===========================================
- Coverage   81.05%   47.09%   -33.96%     
===========================================
  Files         478      113      -365     
  Lines       21308     3739    -17569     
===========================================
- Hits        17271     1761    -15510     
+ Misses       4037     1978     -2059

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025

Benchmarks

Benchmark execution time: 2025-01-29 04:40:51

Comparing candidate commit 8ff06d8 in PR branch bengl/lazily-load-sdk-apis with baseline commit c0550a0 in branch master.

Found 189 performance improvements and 8 performance regressions! Performance is the same for 713 metrics, 23 unstable metrics.

scenario:appsec-control-18

  • 🟩 cpu_user_time [-53.778ms; -49.242ms] or [-14.181%; -12.985%]
  • 🟩 execution_time [-44.747ms; -36.676ms] or [-9.924%; -8.134%]
  • 🟩 instructions [-113.6M instructions; -112.1M instructions] or [-11.678%; -11.528%]

scenario:appsec-control-20

  • 🟩 cpu_user_time [-51.615ms; -47.924ms] or [-14.819%; -13.760%]
  • 🟩 execution_time [-41.269ms; -36.711ms] or [-10.200%; -9.073%]
  • 🟩 instructions [-98.1M instructions; -95.9M instructions] or [-11.525%; -11.260%]

scenario:appsec-control-22

  • 🟩 cpu_user_time [-50.846ms; -46.897ms] or [-16.023%; -14.778%]
  • 🟩 execution_time [-43.731ms; -38.838ms] or [-11.508%; -10.221%]
  • 🟩 instructions [-106.4M instructions; -105.0M instructions] or [-11.750%; -11.589%]

scenario:appsec-control-with-attacks-18

  • 🟩 cpu_user_time [-54.780ms; -50.028ms] or [-14.393%; -13.144%]
  • 🟩 execution_time [-46.366ms; -37.340ms] or [-10.245%; -8.250%]
  • 🟩 instructions [-117.7M instructions; -116.5M instructions] or [-12.043%; -11.921%]

scenario:appsec-control-with-attacks-20

  • 🟩 cpu_user_time [-56.168ms; -52.470ms] or [-15.992%; -14.939%]
  • 🟩 execution_time [-45.936ms; -41.686ms] or [-11.298%; -10.253%]
  • 🟩 instructions [-105.4M instructions; -103.1M instructions] or [-12.266%; -11.999%]

scenario:appsec-control-with-attacks-22

  • 🟩 cpu_user_time [-53.344ms; -49.408ms] or [-16.643%; -15.415%]
  • 🟩 execution_time [-45.877ms; -40.475ms] or [-11.950%; -10.543%]
  • 🟩 instructions [-113.5M instructions; -112.1M instructions] or [-12.426%; -12.268%]

scenario:appsec-iast-no-vulnerability-control-18

  • 🟩 cpu_user_time [-148.886ms; -133.266ms] or [-23.476%; -21.013%]
  • 🟩 execution_time [-140.502ms; -117.074ms] or [-18.978%; -15.814%]
  • 🟩 instructions [-283.2M instructions; -267.5M instructions] or [-19.156%; -18.095%]
  • 🟩 max_rss_usage [-8.830MB; -8.265MB] or [-10.595%; -9.917%]

scenario:appsec-iast-no-vulnerability-control-20

  • 🟩 cpu_user_time [-157.232ms; -143.868ms] or [-25.430%; -23.268%]
  • 🟩 execution_time [-147.591ms; -132.825ms] or [-21.080%; -18.972%]
  • 🟩 instructions [-254.2M instructions; -237.0M instructions] or [-19.337%; -18.035%]
  • 🟩 max_rss_usage [-7.063MB; -6.272MB] or [-8.903%; -7.906%]

scenario:appsec-iast-no-vulnerability-control-22

  • 🟩 cpu_user_time [-136.558ms; -124.295ms] or [-24.392%; -22.202%]
  • 🟩 execution_time [-133.836ms; -119.590ms] or [-20.451%; -18.274%]
  • 🟩 instructions [-256.5M instructions; -231.1M instructions] or [-18.773%; -16.917%]
  • 🟩 max_rss_usage [-10.163MB; -9.414MB] or [-11.324%; -10.489%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟩 cpu_usage_percentage [-7.727%; -6.328%]
  • 🟩 cpu_user_time [-865.503ms; -845.840ms] or [-65.724%; -64.231%]
  • 🟩 execution_time [-888.129ms; -866.182ms] or [-60.958%; -59.452%]
  • 🟩 instructions [-1.5G instructions; -1.5G instructions] or [-56.064%; -55.531%]
  • 🟩 max_rss_usage [-46.711MB; -45.471MB] or [-38.698%; -37.671%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • 🟩 cpu_user_time [-920.668ms; -900.487ms] or [-68.341%; -66.843%]
  • 🟩 execution_time [-959.362ms; -942.237ms] or [-64.779%; -63.623%]
  • 🟩 instructions [-1.6G instructions; -1.6G instructions] or [-60.424%; -59.631%]
  • 🟩 max_rss_usage [-41.870MB; -40.181MB] or [-36.840%; -35.354%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-22

  • 🟩 cpu_user_time [-670.830ms; -654.808ms] or [-63.127%; -61.619%]
  • 🟩 execution_time [-702.801ms; -687.853ms] or [-58.776%; -57.526%]
  • 🟩 instructions [-1.5G instructions; -1.5G instructions] or [-57.622%; -56.678%]
  • 🟩 max_rss_usage [-38.364MB; -36.541MB] or [-32.537%; -30.991%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟩 cpu_usage_percentage [-7.058%; -5.737%]
  • 🟩 cpu_user_time [-824.427ms; -811.897ms] or [-64.380%; -63.402%]
  • 🟩 execution_time [-849.177ms; -833.111ms] or [-59.903%; -58.770%]
  • 🟩 instructions [-1.4G instructions; -1.3G instructions] or [-53.383%; -52.479%]
  • 🟩 max_rss_usage [-46.665MB; -44.902MB] or [-38.697%; -37.235%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • 🟩 cpu_user_time [-871.675ms; -860.897ms] or [-66.932%; -66.104%]
  • 🟩 execution_time [-913.640ms; -897.963ms] or [-63.540%; -62.449%]
  • 🟩 instructions [-1.5G instructions; -1.4G instructions] or [-58.116%; -57.172%]
  • 🟩 max_rss_usage [-42.803MB; -41.272MB] or [-37.289%; -35.956%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-22

  • 🟩 cpu_user_time [-627.900ms; -613.601ms] or [-61.366%; -59.969%]
  • 🟩 execution_time [-667.614ms; -651.659ms] or [-57.372%; -56.001%]
  • 🟩 instructions [-1.3G instructions; -1.3G instructions] or [-54.890%; -53.752%]
  • 🟩 max_rss_usage [-37.906MB; -35.976MB] or [-32.296%; -30.652%]

scenario:appsec-iast-startup-time-iast-enabled-18

  • 🟩 cpu_user_time [-1.015s; -0.991s] or [-58.146%; -56.797%]
  • 🟩 execution_time [-1.085s; -1.066s] or [-56.262%; -55.288%]
  • 🟩 instructions [-1.3G instructions; -1.3G instructions] or [-39.339%; -38.704%]
  • 🟩 max_rss_usage [-39.138MB; -37.858MB] or [-28.603%; -27.667%]

scenario:appsec-iast-startup-time-iast-enabled-20

  • 🟩 cpu_user_time [-1.029s; -1.010s] or [-56.931%; -55.885%]
  • 🟩 execution_time [-1.105s; -1.087s] or [-54.239%; -53.359%]
  • 🟩 instructions [-1.5G instructions; -1.5G instructions] or [-44.749%; -43.924%]
  • 🟩 max_rss_usage [-39.064MB; -37.605MB] or [-29.076%; -27.990%]

scenario:appsec-iast-startup-time-iast-enabled-22

  • 🟩 cpu_user_time [-712.148ms; -697.866ms] or [-51.599%; -50.564%]
  • 🟩 execution_time [-789.605ms; -777.132ms] or [-49.917%; -49.129%]
  • 🟩 instructions [-1.3G instructions; -1.3G instructions] or [-40.073%; -39.179%]
  • 🟩 max_rss_usage [-33.436MB; -31.739MB] or [-24.672%; -23.420%]

scenario:appsec-iast-with-vulnerability-control-18

  • 🟩 cpu_user_time [-187.192ms; -170.496ms] or [-21.877%; -19.926%]
  • 🟩 execution_time [-269.572ms; -220.659ms] or [-19.418%; -15.895%]
  • 🟩 instructions [-380.4M instructions; -365.6M instructions] or [-15.095%; -14.506%]

scenario:appsec-iast-with-vulnerability-control-20

  • 🟩 cpu_user_time [-192.115ms; -176.658ms] or [-22.900%; -21.057%]
  • 🟩 execution_time [-217.453ms; -192.292ms] or [-19.455%; -17.204%]
  • 🟩 instructions [-294.6M instructions; -271.2M instructions] or [-14.589%; -13.427%]

scenario:appsec-iast-with-vulnerability-control-22

  • 🟩 cpu_user_time [-169.078ms; -153.530ms] or [-22.757%; -20.665%]
  • 🟩 execution_time [-198.100ms; -176.613ms] or [-19.437%; -17.329%]
  • 🟩 instructions [-289.8M instructions; -266.7M instructions] or [-14.105%; -12.979%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

  • 🟩 cpu_user_time [-1.124s; -1.101s] or [-62.776%; -61.495%]
  • 🟩 execution_time [-1.575s; -1.506s] or [-58.527%; -55.961%]
  • 🟩 instructions [-2.4G instructions; -2.4G instructions] or [-52.858%; -52.358%]
  • 🟩 max_rss_usage [-46.119MB; -44.975MB] or [-36.021%; -35.126%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20

  • 🟩 cpu_user_time [-1.160s; -1.131s] or [-64.371%; -62.782%]
  • 🟩 execution_time [-1.457s; -1.418s] or [-61.860%; -60.199%]
  • 🟩 instructions [-2.3G instructions; -2.3G instructions] or [-57.115%; -56.507%]
  • 🟩 max_rss_usage [-46.965MB; -45.573MB] or [-36.862%; -35.770%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22

  • 🟩 cpu_user_time [-916.953ms; -883.636ms] or [-61.767%; -59.523%]
  • 🟩 execution_time [-1.202s; -1.155s] or [-59.624%; -57.278%]
  • 🟩 instructions [-2.2G instructions; -2.2G instructions] or [-55.484%; -54.844%]
  • 🟩 max_rss_usage [-48.191MB; -46.970MB] or [-35.735%; -34.830%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

  • 🟩 cpu_user_time [-1006.608ms; -980.806ms] or [-60.128%; -58.586%]
  • 🟩 execution_time [-1.377s; -1.311s] or [-55.435%; -52.781%]
  • 🟩 instructions [-1.9G instructions; -1.9G instructions] or [-47.605%; -46.935%]
  • 🟩 max_rss_usage [-43.718MB; -41.078MB] or [-34.946%; -32.836%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • 🟩 cpu_user_time [-1.038s; -1.007s] or [-61.860%; -60.024%]
  • 🟩 execution_time [-1.258s; -1.219s] or [-58.549%; -56.703%]
  • 🟩 instructions [-1.9G instructions; -1.8G instructions] or [-52.160%; -50.887%]
  • 🟩 max_rss_usage [-43.459MB; -42.180MB] or [-35.169%; -34.134%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22

  • 🟩 cpu_user_time [-756.252ms; -730.499ms] or [-57.193%; -55.245%]
  • 🟩 execution_time [-958.005ms; -914.419ms] or [-54.200%; -51.734%]
  • 🟩 instructions [-1.8G instructions; -1.7G instructions] or [-50.269%; -49.056%]
  • 🟩 max_rss_usage [-43.964MB; -42.317MB] or [-33.696%; -32.433%]

scenario:net-with-tracer-18

  • 🟩 cpu_user_time [-87.315ms; -83.310ms] or [-22.595%; -21.559%]
  • 🟩 execution_time [-95.900ms; -93.904ms] or [-17.457%; -17.094%]
  • 🟩 instructions [-152.8M instructions; -150.9M instructions] or [-15.726%; -15.538%]
  • 🟩 max_rss_usage [-4.918MB; -4.722MB] or [-7.055%; -6.774%]

scenario:net-with-tracer-20

  • 🟩 cpu_user_time [-75.558ms; -71.576ms] or [-19.911%; -18.861%]
  • 🟩 execution_time [-87.964ms; -85.642ms] or [-16.218%; -15.790%]
  • 🟩 instructions [-161.3M instructions; -158.5M instructions] or [-17.654%; -17.355%]
  • 🟩 max_rss_usage [-4.195MB; -3.977MB] or [-6.194%; -5.873%]

scenario:net-with-tracer-22

  • 🟩 cpu_user_time [-73.431ms; -69.048ms] or [-21.148%; -19.886%]
  • 🟩 execution_time [-85.379ms; -83.579ms] or [-17.150%; -16.789%]
  • 🟩 instructions [-155.6M instructions; -152.8M instructions] or [-16.363%; -16.066%]
  • 🟩 max_rss_usage [-4.176MB; -3.927MB] or [-5.489%; -5.161%]

scenario:plugin-dns-with-tracer-18

  • 🟩 cpu_usage_percentage [-11.611%; -11.206%]
  • 🟩 cpu_user_time [-284.323ms; -267.170ms] or [-47.595%; -44.723%]
  • 🟩 execution_time [-304.442ms; -250.608ms] or [-14.466%; -11.908%]
  • 🟩 instructions [-453.7M instructions; -446.0M instructions] or [-36.477%; -35.860%]
  • 🟩 max_rss_usage [-10.065MB; -9.594MB] or [-13.297%; -12.674%]

scenario:plugin-dns-with-tracer-20

  • 🟩 cpu_usage_percentage [-12.352%; -11.957%]
  • 🟩 cpu_user_time [-305.742ms; -291.485ms] or [-47.967%; -45.731%]
  • 🟩 execution_time [-322.899ms; -270.535ms] or [-14.993%; -12.562%]
  • 🟩 instructions [-458.9M instructions; -450.6M instructions] or [-37.170%; -36.494%]
  • 🟩 max_rss_usage [-15.717MB; -15.270MB] or [-19.098%; -18.555%]

scenario:plugin-dns-with-tracer-22

  • 🟩 cpu_usage_percentage [-10.995%; -10.577%]
  • 🟩 cpu_user_time [-260.909ms; -245.190ms] or [-46.224%; -43.440%]
  • 🟩 execution_time [-297.997ms; -245.129ms] or [-14.249%; -11.721%]
  • 🟩 instructions [-467.6M instructions; -460.4M instructions] or [-36.436%; -35.876%]
  • 🟩 max_rss_usage [-15.112MB; -14.948MB] or [-17.116%; -16.930%]

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟩 execution_time [-16.464s; -14.705s] or [-86.846%; -77.568%]
  • 🟩 instructions [-35.6G instructions; -35.2G instructions] or [-85.592%; -84.689%]
  • 🟩 max_rss_usage [-758.848MB; -726.200MB] or [-61.343%; -58.704%]

scenario:plugin-graphql-with-depth-and-collapse-off-22

  • 🟩 instructions [-54.9G instructions; -54.1G instructions] or [-90.764%; -89.384%]
  • 🟩 max_rss_usage [-2.197GB; -2.084GB] or [-85.539%; -81.139%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 cpu_user_time [-7.966s; -7.638s] or [-74.246%; -71.191%]
  • 🟩 execution_time [-8.268s; -8.109s] or [-71.709%; -70.331%]
  • 🟩 instructions [-17.6G instructions; -17.3G instructions] or [-74.353%; -73.015%]
  • 🟩 max_rss_usage [-458.884MB; -446.192MB] or [-48.607%; -47.262%]

scenario:plugin-graphql-with-depth-and-collapse-on-20

  • 🟩 cpu_user_time [-15.273s; -14.235s] or [-86.486%; -80.608%]
  • 🟩 execution_time [-16.702s; -15.535s] or [-86.081%; -80.069%]
  • 🟩 instructions [-40.6G instructions; -40.4G instructions] or [-87.540%; -87.242%]
  • 🟩 max_rss_usage [-1.672GB; -1.668GB] or [-77.414%; -77.261%]

scenario:plugin-graphql-with-depth-and-collapse-on-22

  • 🟩 cpu_user_time [-14.794s; -13.992s] or [-85.896%; -81.243%]
  • 🟩 execution_time [-16.234s; -15.279s] or [-85.725%; -80.681%]
  • 🟩 instructions [-40.1G instructions; -39.7G instructions] or [-87.469%; -86.486%]
  • 🟩 max_rss_usage [-1.745GB; -1.740GB] or [-80.434%; -80.216%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 cpu_user_time [-8.307s; -7.944s] or [-75.314%; -72.021%]
  • 🟩 execution_time [-8.647s; -8.416s] or [-72.935%; -70.986%]
  • 🟩 instructions [-18.7G instructions; -18.2G instructions] or [-75.821%; -74.053%]
  • 🟩 max_rss_usage [-458.750MB; -442.214MB] or [-48.729%; -46.972%]

scenario:plugin-graphql-with-depth-off-20

  • 🟩 cpu_user_time [-15.503s; -14.953s] or [-85.552%; -82.516%]
  • 🟩 execution_time [-16.909s; -16.249s] or [-85.109%; -81.785%]
  • 🟩 instructions [-41.6G instructions; -41.4G instructions] or [-87.809%; -87.407%]
  • 🟩 max_rss_usage [-1.681GB; -1.680GB] or [-77.414%; -77.361%]

scenario:plugin-graphql-with-depth-off-22

  • 🟩 cpu_user_time [-15.058s; -14.112s] or [-86.312%; -80.886%]
  • 🟩 execution_time [-16.496s; -15.434s] or [-85.994%; -80.456%]
  • 🟩 instructions [-41.0G instructions; -40.7G instructions] or [-87.572%; -86.950%]
  • 🟩 max_rss_usage [-1.791GB; -1.643GB] or [-82.134%; -75.334%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 cpu_user_time [-7.861s; -7.630s] or [-73.462%; -71.303%]
  • 🟩 execution_time [-8.258s; -8.008s] or [-71.828%; -69.660%]
  • 🟩 instructions [-17.5G instructions; -17.3G instructions] or [-73.995%; -73.311%]
  • 🟩 max_rss_usage [-461.916MB; -447.192MB] or [-48.723%; -47.170%]

scenario:plugin-graphql-with-depth-on-max-20

  • 🟩 cpu_user_time [-14.963s; -14.698s] or [-84.244%; -82.747%]
  • 🟩 execution_time [-16.445s; -15.997s] or [-84.240%; -81.940%]
  • 🟩 instructions [-40.6G instructions; -40.5G instructions] or [-87.420%; -87.224%]
  • 🟩 max_rss_usage [-1.671GB; -1.666GB] or [-77.418%; -77.174%]

scenario:plugin-graphql-with-depth-on-max-22

  • 🟩 cpu_user_time [-14.881s; -13.795s] or [-86.746%; -80.413%]
  • 🟩 execution_time [-16.323s; -15.050s] or [-86.625%; -79.870%]
  • 🟩 instructions [-40.1G instructions; -39.7G instructions] or [-87.393%; -86.326%]
  • 🟩 max_rss_usage [-1.742GB; -1.741GB] or [-80.296%; -80.247%]

scenario:plugin-http-client-with-tracer-18

  • 🟩 cpu_usage_percentage [-6.875%; -6.775%]
  • 🟩 cpu_user_time [-335.036ms; -321.575ms] or [-40.989%; -39.342%]
  • 🟩 execution_time [-366.366ms; -351.010ms] or [-30.953%; -29.655%]
  • 🟩 instructions [-559.7M instructions; -554.1M instructions] or [-33.598%; -33.261%]
  • 🟩 max_rss_usage [-12.197MB; -11.790MB] or [-14.701%; -14.211%]

scenario:plugin-http-client-with-tracer-20

  • 🟩 cpu_user_time [-194.888ms; -187.945ms] or [-32.464%; -31.308%]
  • 🟩 execution_time [-216.995ms; -211.436ms] or [-26.219%; -25.547%]
  • 🟩 instructions [-294.8M instructions; -289.0M instructions] or [-24.914%; -24.425%]
  • 🟩 max_rss_usage [-7.221MB; -6.793MB] or [-9.665%; -9.091%]

scenario:plugin-http-client-with-tracer-22

  • 🟩 cpu_user_time [-149.132ms; -141.432ms] or [-27.131%; -25.730%]
  • 🟩 execution_time [-163.826ms; -157.637ms] or [-21.301%; -20.497%]
  • 🟩 instructions [-274.4M instructions; -270.2M instructions] or [-21.972%; -21.633%]
  • 🟩 max_rss_usage [-4.716MB; -4.532MB] or [-5.871%; -5.643%]

scenario:plugin-http-server-querystring-obfuscation-18

  • 🟥 cpu_usage_percentage [+6.786%; +6.904%]
  • 🟩 execution_time [-188.181ms; -183.880ms] or [-17.722%; -17.317%]

scenario:plugin-http-server-querystring-obfuscation-20

  • 🟥 cpu_usage_percentage [+6.445%; +6.602%]
  • 🟩 execution_time [-184.601ms; -180.813ms] or [-22.159%; -21.705%]

scenario:plugin-http-server-querystring-obfuscation-22

  • 🟥 cpu_usage_percentage [+6.315%; +6.523%]
  • 🟩 execution_time [-151.974ms; -147.923ms] or [-19.118%; -18.608%]

scenario:plugin-http-server-with-tracer-18

  • 🟥 cpu_usage_percentage [+5.648%; +5.798%]
  • 🟩 execution_time [-160.645ms; -156.202ms] or [-15.858%; -15.420%]

scenario:plugin-http-server-with-tracer-20

  • 🟥 cpu_usage_percentage [+5.254%; +5.466%]
  • 🟩 execution_time [-152.686ms; -148.419ms] or [-19.212%; -18.675%]

scenario:plugin-http-server-with-tracer-22

  • 🟥 cpu_usage_percentage [+5.018%; +5.253%]
  • 🟩 execution_time [-121.904ms; -117.597ms] or [-16.061%; -15.494%]

scenario:spans-finish-later-22

  • 🟩 instructions [-254.3M instructions; -195.0M instructions] or [-8.922%; -6.842%]

scenario:startup-with-tracer-22

  • 🟥 cpu_user_time [+12.596ms; +18.589ms] or [+6.245%; +9.216%]
  • 🟥 execution_time [+12.904ms; +14.291ms] or [+5.254%; +5.819%]

simon-id
simon-id reviewed Jan 29, 2025
View reviewed changes
packages/dd-trace/src/proxy.js
Comment on lines +241 to +245
if (config.appsec.enabled) {
this.appsec = new lazyClasses.AppsecSdk(this._tracer, config)
} else {
this.appsec = new lazyClasses.NoopAppsecSdk()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppSec SDK needs to be available even if AppSec is disabled. I think this is breaking that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the noopAppsecSdk is used when tracing is disabled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-id simon-id simon-id left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengl @simon-id