Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load AppSec SDK on first method use #5177

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simon-id
Copy link
Member

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Jan 30, 2025

Overall package size

Self size: 8.57 MB
Deduped: 94.97 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@simon-id simon-id self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (f3bb2a7) to head (e6025f4).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5177      +/-   ##
==========================================
+ Coverage   81.07%   81.68%   +0.61%     
==========================================
  Files         479      313     -166     
  Lines       21338    12485    -8853     
==========================================
- Hits        17299    10198    -7101     
+ Misses       4039     2287    -1752     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 30, 2025

Datadog Report

Branch report: lazy_load_appsec_sdk
Commit report: eb6abcf
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 612 Passed, 0 Skipped, 11m 28.35s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 30, 2025

Benchmarks

Benchmark execution time: 2025-02-01 16:41:02

Comparing candidate commit e6025f4 in PR branch lazy_load_appsec_sdk with baseline commit f3bb2a7 in branch master.

Found 4 performance improvements and 6 performance regressions! Performance is the same for 901 metrics, 22 unstable metrics.

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22

  • 🟩 max_rss_usage [-11.206MB; -9.078MB] or [-8.352%; -6.766%]

scenario:log-skip-log-20

  • 🟥 cpu_user_time [+18.006ms; +22.917ms] or [+5.027%; +6.398%]

scenario:log-with-error-20

  • 🟥 cpu_user_time [+18.038ms; +23.226ms] or [+5.070%; +6.528%]

scenario:log-without-log-20

  • 🟥 cpu_user_time [+19.403ms; +24.746ms] or [+5.797%; +7.393%]

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+113.481MB; +124.687MB] or [+21.304%; +23.407%]

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-86.630MB; -75.098MB] or [-9.173%; -7.952%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-91.490MB; -78.498MB] or [-9.713%; -8.334%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-81.053MB; -79.767MB] or [-8.560%; -8.424%]

scenario:startup-with-tracer-20

  • 🟥 cpu_user_time [+15.787ms; +24.572ms] or [+6.677%; +10.393%]
  • 🟥 execution_time [+15.077ms; +21.263ms] or [+5.360%; +7.559%]

@simon-id simon-id changed the title try to lazy-load appsec sdk at first usage Lazy load AppSec SDK on first method use Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant