Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yarnrc with ignore-engines config #5183

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jan 31, 2025

What does this PR do?

Add .yarnrc with ignore-engines true config.

Motivation

When using old Node versions, ESLint otherwise fails to install.

Additional Notes

Supersedes #5179

Copy link

github-actions bot commented Jan 31, 2025

Overall package size

Self size: 8.61 MB
Deduped: 95 MB
No deduping: 95.51 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (5d6e698) to head (55cf8c3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5183   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files         481      481           
  Lines       21489    21489           
=======================================
  Hits        17436    17436           
  Misses       4053     4053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rochdev rochdev marked this pull request as ready for review January 31, 2025 12:01
@rochdev rochdev requested a review from a team as a code owner January 31, 2025 12:01
@watson
Copy link
Collaborator

watson commented Jan 31, 2025

It would be nice if we could remove this file in CI. That way we'd be notified if we by accident installed a module that didn't support any of the versions we test in CI

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 31, 2025

Datadog Report

Branch report: yarnrc-ignore-engines
Commit report: aa7a326
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 614 Passed, 0 Skipped, 14m 52.63s Total Time

@rochdev
Copy link
Member Author

rochdev commented Jan 31, 2025

It would be nice if we could remove this file in CI. That way we'd be notified if we by accident installed a module that didn't support any of the versions we test in CI

I don't think it's necessary for 2 reasons:

  1. We already explicitly use --ignore-engines in CI, so this is basically just redundant and only also applies it when working locally.
  2. We could have an explicit job that checks that. Short of that, we have integration tests that use a sandbox that install dd-trace like a user would (which does not include the file)

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025

Benchmarks

Benchmark execution time: 2025-02-03 21:45:10

Comparing candidate commit 55cf8c3 in PR branch yarnrc-ignore-engines with baseline commit 5d6e698 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 896 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-90.691MB; -63.845MB] or [-9.629%; -6.779%]

@rochdev rochdev force-pushed the yarnrc-ignore-engines branch from f39fa49 to 55cf8c3 Compare February 3, 2025 21:33
@rochdev rochdev merged commit 15b9f39 into master Feb 3, 2025
351 of 353 checks passed
@rochdev rochdev deleted the yarnrc-ignore-engines branch February 3, 2025 21:48
rochdev added a commit that referenced this pull request Feb 7, 2025
@rochdev rochdev mentioned this pull request Feb 7, 2025
rochdev added a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants