Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.34.0 proposal #5184

Merged
merged 11 commits into from
Jan 31, 2025
Merged

v5.34.0 proposal #5184

merged 11 commits into from
Jan 31, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Jan 31, 2025

  • [34c3763fce] - (SEMVER-PATCH) Use official parametric scenario parameters (Charles de Beauchesne) #5182
  • [c67739b0ff] - (SEMVER-MINOR) Code injection instrumented metric (Ilyas Shabi) #5164
  • [ccf12922b1] - (SEMVER-PATCH) [DI] Improve path matching algorithm for probe file paths (Thomas Watson) #5166
  • [9f5ee9dd8b] - (SEMVER-PATCH) retry npm install on error for plugin test suite (Roch Devost) #5178
  • [6f79a86e73] - (SEMVER-PATCH) disable test-agent plugin logs (William Conti) #5181
  • [e8e96bff7d] - (SEMVER-MINOR) env var to disable all middleware spans (Bryan English) #5044
  • [bfdd3ad0fb] - (SEMVER-PATCH) ci(openai): fix esm tests (Sam Brenner) #5163
  • [fd61c8c54e] - (SEMVER-PATCH) replace msgpack-lite with official library for tests (Roch Devost) #5173
  • [f3bb2a7a87] - (SEMVER-PATCH) fix flaky user_tracking test (simon-id) #5172
  • [69426fb50f] - (SEMVER-MINOR) chore(tracing): graphql error support (William Conti) #5162

wconti27 and others added 8 commits January 31, 2025 13:41
* add graphql error reporting via span links
* replace msgpack-lite with official library for tests

* remove int64-buffer

* fix serializing traces in tests

* replace bigint with int instead of str

* fix moleculer test

* fix llmobs tests

* fix langchain tests
* env var to disable all middleware spans

---------

Co-authored-by: Ida.Liu <[email protected]>
Co-authored-by: Ida Liu <[email protected]>
Change the path matching algorithm used to match a probe file path against the
list of loaded module paths. The new algorithm supports Windows paths and path
prefixes and has fewer false positives.
Copy link

github-actions bot commented Jan 31, 2025

Overall package size

Self size: 8.55 MB
Deduped: 94.94 MB
No deduping: 95.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@175f12b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/datadog-plugin-graphql/src/utils.js 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5184   +/-   ##
=======================================
  Coverage        ?   81.08%           
=======================================
  Files           ?      480           
  Lines           ?    21367           
  Branches        ?        0           
=======================================
  Hits            ?    17325           
  Misses          ?     4042           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 31, 2025

Datadog Report

Branch report: v5.34.0-proposal
Commit report: 8a3f5c8
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 615 Passed, 0 Skipped, 14m 7.58s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2025

Benchmarks

Benchmark execution time: 2025-01-31 14:31:59

Comparing candidate commit fa95e32 in PR branch v5.34.0-proposal with baseline commit 175f12b in branch v5.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 907 metrics, 26 unstable metrics.

@watson watson marked this pull request as ready for review January 31, 2025 14:37
@watson watson requested a review from a team as a code owner January 31, 2025 14:37
@watson watson merged commit 2f816e4 into v5.x Jan 31, 2025
350 checks passed
@watson watson deleted the v5.34.0-proposal branch January 31, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants