Skip to content

migrate all tests to bun - #6718

Closed
rochdev wants to merge 38 commits into
masterfrom
bun-isolated
Closed

migrate all tests to bun#6718
rochdev wants to merge 38 commits into
masterfrom
bun-isolated

Conversation

@rochdev

@rochdev rochdev commented Oct 22, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Migrate all tests to Bun.

Motivation

Continuation of #6693

@github-actions

github-actions Bot commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.56 MB
Deduped: 5.4 MB
No deduping: 5.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 813.08 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.52%. Comparing base (313fe22) to head (8576373).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6718      +/-   ##
==========================================
- Coverage   80.41%   79.52%   -0.90%     
==========================================
  Files         732      729       -3     
  Lines       31050    30779     -271     
==========================================
- Hits        24970    24476     -494     
- Misses       6080     6303     +223     
Flag Coverage Δ
aiguard-macos 39.07% <ø> (-0.11%) ⬇️
aiguard-ubuntu 39.11% <ø> (-0.11%) ⬇️
aiguard-windows 38.96% <ø> (-0.11%) ⬇️
apm-capabilities-tracing-macos 48.89% <ø> (+0.04%) ⬆️
apm-capabilities-tracing-ubuntu 48.89% <ø> (ø)
apm-capabilities-tracing-windows 48.57% <ø> (-0.05%) ⬇️
apm-integrations-child-process 38.56% <ø> (-0.11%) ⬇️
apm-integrations-couchbase-18 37.32% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-eol 37.80% <ø> (-0.10%) ⬇️
apm-integrations-oracledb 37.99% <ø> (-0.10%) ⬇️
appsec-express 55.35% <ø> (-0.09%) ⬇️
appsec-fastify 52.03% <ø> (-0.04%) ⬇️
appsec-graphql 52.30% <ø> (-0.09%) ⬇️
appsec-kafka 44.63% <ø> (-0.09%) ⬇️
appsec-ldapjs 44.29% <ø> (-0.09%) ⬇️
appsec-lodash 43.98% <ø> (-0.09%) ⬇️
appsec-macos 58.48% <ø> (-0.07%) ⬇️
appsec-mongodb-core 49.06% <ø> (-0.09%) ⬇️
appsec-mongoose 49.06% <ø> (-0.90%) ⬇️
appsec-mysql 51.25% <ø> (-0.08%) ⬇️
appsec-node-serialize 43.49% <ø> (-0.09%) ⬇️
appsec-passport 48.10% <ø> (-0.09%) ⬇️
appsec-postgres 51.04% <ø> (-0.08%) ⬇️
appsec-sourcing 42.84% <ø> (-0.09%) ⬇️
appsec-template 43.66% <ø> (-0.09%) ⬇️
appsec-ubuntu 58.50% <ø> (-0.07%) ⬇️
appsec-windows 58.36% <ø> (-0.07%) ⬇️
instrumentations-instrumentation-bluebird 32.23% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-body-parser 40.72% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-child_process 37.87% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-cookie-parser 34.50% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express 34.84% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.63% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-express-session 40.40% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-fs 31.83% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-generic-pool 29.77% <ø> (-0.03%) ⬇️
instrumentations-instrumentation-http 39.61% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.24% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-mongoose 33.49% <ø> (-0.21%) ⬇️
instrumentations-instrumentation-multer 40.46% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mysql2 38.25% <ø> (-0.12%) ⬇️
instrumentations-instrumentation-passport 40.76% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport-http 40.73% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport-local 40.73% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-pg 37.78% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-promise 32.16% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-promise-js 32.17% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-q 32.20% <ø> (-0.12%) ⬇️
instrumentations-instrumentation-url 32.13% <ø> (-0.11%) ⬇️
instrumentations-instrumentation-when 32.18% <ø> (-0.11%) ⬇️
llmobs-ai 41.28% <ø> (-0.36%) ⬇️
llmobs-anthropic 40.62% <ø> (-0.10%) ⬇️
llmobs-bedrock 39.55% <ø> (-0.05%) ⬇️
llmobs-google-genai 40.11% <ø> (-0.09%) ⬇️
llmobs-langchain 39.65% <ø> (-0.08%) ⬇️
llmobs-openai 44.45% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 40.33% <ø> (-0.10%) ⬇️
platform-core ?
platform-esbuild ?
platform-instrumentations-misc 39.62% <ø> (ø)
platform-shimmer 34.83% <ø> (ø)
platform-unit-guardrails 30.37% <ø> (ø)
plugins-azure-event-hubs 22.64% <ø> (ø)
plugins-azure-service-bus 22.08% <ø> (ø)
plugins-bullmq 43.56% <ø> (-0.10%) ⬇️
plugins-cassandra 38.03% <ø> (-0.10%) ⬇️
plugins-cookie 23.69% <ø> (ø)
plugins-cookie-parser 23.50% <ø> (ø)
plugins-crypto 22.88% <ø> (ø)
plugins-dd-trace-api 38.38% <ø> (-0.11%) ⬇️
plugins-express-mongo-sanitize 23.67% <ø> (ø)
plugins-express-session 23.46% <ø> (ø)
plugins-fastify 41.98% <ø> (-0.64%) ⬇️
plugins-fetch 38.59% <ø> (-0.10%) ⬇️
plugins-fs 38.66% <ø> (-0.11%) ⬇️
plugins-generic-pool 22.51% <ø> (-0.17%) ⬇️
plugins-google-cloud-pubsub ?
plugins-grpc 41.29% <ø> (-0.10%) ⬇️
plugins-handlebars 23.71% <ø> (ø)
plugins-hapi 40.42% <ø> (-0.10%) ⬇️
plugins-hono 40.62% <ø> (-0.24%) ⬇️
plugins-ioredis 38.46% <ø> (-0.11%) ⬇️
plugins-knex 23.51% <ø> (ø)
plugins-ldapjs 21.12% <ø> (-0.16%) ⬇️
plugins-light-my-request 23.15% <ø> (ø)
plugins-limitd-client 32.53% <ø> (-0.11%) ⬇️
plugins-lodash 22.57% <ø> (-0.17%) ⬇️
plugins-mariadb ?
plugins-memcached 38.19% <ø> (-0.11%) ⬇️
plugins-microgateway-core 39.43% <ø> (-0.10%) ⬇️
plugins-moleculer 40.83% <ø> (-0.10%) ⬇️
plugins-mongodb 39.53% <ø> (-0.11%) ⬇️
plugins-mongodb-core 39.12% <ø> (-0.10%) ⬇️
plugins-mongoose 39.06% <ø> (-0.21%) ⬇️
plugins-multer 23.46% <ø> (ø)
plugins-mysql 39.22% <ø> (-0.11%) ⬇️
plugins-mysql2 39.29% <ø> (-0.11%) ⬇️
plugins-node-serialize 23.73% <ø> (ø)
plugins-opensearch 37.87% <ø> (-0.10%) ⬇️
plugins-passport-http 23.56% <ø> (ø)
plugins-postgres 35.69% <ø> (-0.10%) ⬇️
plugins-process 22.88% <ø> (ø)
plugins-pug 23.69% <ø> (ø)
plugins-redis 38.76% <ø> (-0.13%) ⬇️
plugins-router 43.23% <ø> (-0.10%) ⬇️
plugins-sequelize 22.27% <ø> (ø)
plugins-test-and-upstream-amqp10 38.38% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-amqplib 43.89% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-apollo 39.32% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.80% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-bunyan 33.85% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-connect 40.89% <ø> (-0.25%) ⬇️
plugins-test-and-upstream-graphql 40.06% <ø> (-0.26%) ⬇️
plugins-test-and-upstream-koa 40.67% <ø> (-0.25%) ⬇️
plugins-test-and-upstream-protobufjs 39.04% <ø> (-0.11%) ⬇️
plugins-test-and-upstream-rhea 44.15% <ø> (-0.13%) ⬇️
plugins-undici 39.36% <ø> (-0.12%) ⬇️
plugins-url 22.88% <ø> (ø)
plugins-valkey 38.11% <ø> (-0.11%) ⬇️
plugins-vm 22.88% <ø> (ø)
plugins-winston 34.26% <ø> (-0.10%) ⬇️
plugins-ws 40.73% <ø> (-0.11%) ⬇️
profiling-macos 40.05% <ø> (-0.10%) ⬇️
profiling-ubuntu 40.10% <ø> (-0.10%) ⬇️
profiling-windows 41.46% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 22.38% <ø> (ø)
serverless-azure-functions-eventhubs 22.38% <ø> (ø)
serverless-azure-functions-servicebus 22.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 22, 2025

Copy link
Copy Markdown

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

cypress@10.2.0 esm instruments tests with the APM protocol (old agents) from integration-tests/cypress/cypress.spec.js (Datadog) (Fix with Cursor)
Expected values to be partially and strictly deep-equal:
+ actual - expected

+ undefined
- {
-   meta: {
-     'test.codeowners': '["@datadog-dd-trace-js"]',
-     'test.framework': 'cypress',
-     'test.name': 'basic pass suite can pass',
-     'test.status': 'pass',
...

🧪 1 Test failed

❄️ Known flaky: tests.appsec.waf.test_telemetry.Test_TelemetryMetrics.test_waf_requests_match_traced_requests[uds-express4] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Number of requests in traces do not match waf.requests metric total
assert 5 == 4

self = <tests.appsec.waf.test_telemetry.Test_TelemetryMetrics object at 0x7f40149e6c30>

    def test_waf_requests_match_traced_requests(self):
        """Total waf.requests metric should match the number of requests in traces."""
        spans = [s for _, s in interfaces.library.get_root_spans()]
        spans = [
            s
...
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8576373 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter

pr-commenter Bot commented Oct 22, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-02-05 04:15:59

Comparing candidate commit 8576373 in PR branch bun-isolated with baseline commit 313fe22 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 229 metrics, 29 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟥 max_rss_usage [+7.977MB; +11.148MB] or [+6.194%; +8.656%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟥 max_rss_usage [+9.095MB; +11.617MB] or [+7.068%; +9.027%]

@rochdev
rochdev changed the base branch from master to bun-sandbox October 22, 2025 21:51
@rochdev
rochdev force-pushed the bun-isolated branch 2 times, most recently from 2ac83d5 to 63284a6 Compare October 22, 2025 22:16
Base automatically changed from bun-sandbox to master October 24, 2025 15:57
@BridgeAR

Copy link
Copy Markdown
Member

Is this something that is still planned?

@BridgeAR

Copy link
Copy Markdown
Member

@rochdev is this still planned? If not, should we close this and open a new PR when there is time to add more tests? We did add smoke tests for bun in the meanwhile

@rochdev

rochdev commented Mar 13, 2026

Copy link
Copy Markdown
Member Author

is this still planned? If not, should we close this and open a new PR when there is time to add more tests? We did add smoke tests for bun in the meanwhile

The only reason I didn't finish it is because the few failures remaining will need time to look into that I don't have, but yes I would still like to get this PR to the finish line at some point.

@BridgeAR

Copy link
Copy Markdown
Member

This conflicts a lot and this is stale for quite some time.

I will close it for now, but please just reopen when you want to continue working on it!

@BridgeAR BridgeAR closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants