test: completely remove chai and fix type errors - #7144
Merged
Conversation
Contributor
Overall package sizeSelf size: 4.36 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BridgeAR
changed the base branch from
master
to
BridgeAR/2025-12-18-rewrite-chai-to-assert
December 18, 2025 18:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7144 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 522 522
Lines 22232 22233 +1
=======================================
+ Hits 18848 18849 +1
Misses 3384 3384 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
BridgeAR/2025-12-18-rewrite-chai-to-assert
to
master
December 18, 2025 19:00
BridgeAR
force-pushed
the
BridgeAR/2025-12-18-fix-type-issues
branch
from
December 18, 2025 19:21
783ea14 to
18a1a0e
Compare
BenchmarksBenchmark execution time: 2025-12-20 01:34:58 Comparing candidate commit 8f35575 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics. |
BridgeAR
force-pushed
the
BridgeAR/2025-12-18-fix-type-issues
branch
from
December 19, 2025 17:39
3094a62 to
3012057
Compare
BridgeAR
changed the title
BridgeAR
marked this pull request as ready for review
December 19, 2025 17:40
|
watson
previously approved these changes
Dec 19, 2025
| // This is a bit like chai's `expect(expected).to.deep.include(actual)`, except | ||
| // that when it recurses it uses the same inclusion check, rather than deep | ||
| // equality. Some nice output is included. | ||
| function deepInclude (expected, actual, path = []) { |
Collaborator
There was a problem hiding this comment.
Nice find! Great to get rid of this redundant code. It was even exported but just not used (anymore at least)
| // OpenTracing's upstream API compatibility checks depend on `chai`, but this | ||
| // repo intentionally does not. We provide a minimal shim just for these checks | ||
| // (assert.equal, expect(...).to.not.throw(), expect(...).to.be.a()). | ||
| function createChaiShim () { |
Environment variables may only be of type string or undefined.
Instead, the code is now using Node.js assert or a native testing library available by a test runner.
BridgeAR
force-pushed
the
BridgeAR/2025-12-18-fix-type-issues
branch
from
December 19, 2025 21:49
fe70f24 to
ace957f
Compare
watson
reviewed
Dec 19, 2025
BridgeAR
commented
Dec 20, 2025
watson
approved these changes
Dec 20, 2025
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
* test: fix env type errors Environment variables may only be of type string or undefined. * test: remove all chai related code Instead, the code is now using Node.js assert or a native testing library available by a test runner. * test: fix opentracing tests This uses a hack to keep them supported, since they use chai. To do so, a fake chai is introduced when loading that test file. * test: remove unused deepInclude test helper It was not used for a while and could be replaced with the more generic partial deep strict equal helper.
Merged
nina9753
pushed a commit
that referenced
this pull request
Jan 15, 2026
* test: fix env type errors Environment variables may only be of type string or undefined. * test: remove all chai related code Instead, the code is now using Node.js assert or a native testing library available by a test runner. * test: fix opentracing tests This uses a hack to keep them supported, since they use chai. To do so, a fake chai is introduced when loading that test file. * test: remove unused deepInclude test helper It was not used for a while and could be replaced with the more generic partial deep strict equal helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.