Skip to content

fix(aap): Fix appsec test for sinon.js 21.0.1 - #7233

Merged
simon-id merged 3 commits into
masterfrom
ccapell/fix-blocking-teset-with-sinon-21.0.1
Jan 14, 2026
Merged

fix(aap): Fix appsec test for sinon.js 21.0.1#7233
simon-id merged 3 commits into
masterfrom
ccapell/fix-blocking-teset-with-sinon-21.0.1

Conversation

@CarlesDD

@CarlesDD CarlesDD commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Bumps Sinon.js to v21.0.1
Applies a workaround by explicitly calling resetHistory() on all spies to properly reset their call counts.

Motivation

A recent patch release of Sinon.js changed the behaviour of sandbox.reset() method.

@pr-commenter

pr-commenter Bot commented Jan 13, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-01-14 06:18:02

Comparing candidate commit c05ad7a in PR branch ccapell/fix-blocking-teset-with-sinon-21.0.1 with baseline commit e996e29 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics.

@github-actions

github-actions Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.39 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov

codecov Bot commented Jan 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.56%. Comparing base (e996e29) to head (c05ad7a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7233   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         532      532           
  Lines       22656    22656           
=======================================
  Hits        19159    19159           
  Misses       3497     3497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

This comment has been minimized.

@CarlesDD
CarlesDD marked this pull request as ready for review January 14, 2026 06:41
@CarlesDD
CarlesDD requested review from a team as code owners January 14, 2026 06:41
@simon-id
simon-id merged commit 851e7ec into master Jan 14, 2026
826 of 828 checks passed
@simon-id
simon-id deleted the ccapell/fix-blocking-teset-with-sinon-21.0.1 branch January 14, 2026 08:40
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 15, 2026
* Bump sinon.js to 21.0.1

* Workaround for sinon spies in appsec test
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jan 15, 2026
nina9753 pushed a commit that referenced this pull request Jan 15, 2026
* Bump sinon.js to 21.0.1

* Workaround for sinon spies in appsec test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants