fix(aap): Fix appsec test for sinon.js 21.0.1 - #7233
Merged
Conversation
BenchmarksBenchmark execution time: 2026-01-14 06:18:02 Comparing candidate commit c05ad7a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics. |
Contributor
Overall package sizeSelf size: 4.39 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7233 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 532 532
Lines 22656 22656
=======================================
Hits 19159 19159
Misses 3497 3497 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
CarlesDD
marked this pull request as ready for review
January 14, 2026 06:41
simon-id
approved these changes
Jan 14, 2026
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
* Bump sinon.js to 21.0.1 * Workaround for sinon spies in appsec test
Merged
nina9753
pushed a commit
that referenced
this pull request
Jan 15, 2026
* Bump sinon.js to 21.0.1 * Workaround for sinon spies in appsec test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps Sinon.js to v21.0.1
Applies a workaround by explicitly calling
resetHistory()on all spies to properly reset their call counts.Motivation
A recent patch release of Sinon.js changed the behaviour of
sandbox.reset()method.