Skip to content

chore(dep): bump dd-license-attribution tool to newest version - #7246

Merged
watson merged 3 commits into
masterfrom
watson/3rd-party-license
Jan 15, 2026
Merged

chore(dep): bump dd-license-attribution tool to newest version#7246
watson merged 3 commits into
masterfrom
watson/3rd-party-license

Conversation

@watson

@watson watson commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Bump dd-license-attribution to the latest version which fixes two issues with LICENSE-3rdparty.csv:

  • Consistently use Windows style line endings
  • Removes incorrect @datadog/source-map line from LICENSE-3rdparty.csv

Also update scripts/check_licenses.js to support resolving npm aliases.

Motivation

The new version of dd-license-attribution contains two bug fixes, ensuring that LICENSE-3rdparty.csv is now more correct.

Additional Notes

Reviewer tip: Hide white-space changes in diff to not see the changes related to the line endings.

watson commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jan 14, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 4.39 MB
Deduped: 5.21 MB
No deduping: 5.21 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter

pr-commenter Bot commented Jan 14, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-01-15 08:33:36

Comparing candidate commit 5848030 in PR branch watson/3rd-party-license with baseline commit e48b161 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics.

@codecov

codecov Bot commented Jan 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.87%. Comparing base (e48b161) to head (5848030).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7246   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files         532      532           
  Lines       22654    22654           
=======================================
  Hits        19227    19227           
  Misses       3427     3427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson self-assigned this Jan 14, 2026
This version contains a bug fix for ensuring CSV line endings are always
the same no matter which version of Python is being used.
@watson
watson force-pushed the watson/3rd-party-license branch from 6a8044b to 75fe541 Compare January 15, 2026 06:34
@datadog-datadog-prod-us1

This comment has been minimized.

@watson
watson marked this pull request as ready for review January 15, 2026 07:14
@watson
watson requested a review from a team as a code owner January 15, 2026 07:14
This removes a line from the CSV file that was incorrectly added due to
a bug now fixed in the new version of dd-license-attribution
@watson
watson force-pushed the watson/3rd-party-license branch 2 times, most recently from 1bbf66b to 02ad67a Compare January 15, 2026 08:10

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am just unsure why the whole file is regenerated / got different whitespace now

@watson

watson commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator Author

@BridgeAR that's explained in the PR body

@watson
watson merged commit f687057 into master Jan 15, 2026
795 checks passed
@watson
watson deleted the watson/3rd-party-license branch January 15, 2026 12:09
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 15, 2026
Bump `dd-license-attribution` to the latest version which fixes two issues with
`LICENSE-3rdparty.csv`:
- Consistently use Windows style line endings
- Removes incorrect `@datadog/source-map` line from `LICENSE-3rdparty.csv`

Also update `scripts/check_licenses.js` to support resolving npm aliases.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jan 15, 2026
dd-octo-sts Bot pushed a commit that referenced this pull request Jan 17, 2026
Bump `dd-license-attribution` to the latest version which fixes two issues with
`LICENSE-3rdparty.csv`:
- Consistently use Windows style line endings
- Removes incorrect `@datadog/source-map` line from `LICENSE-3rdparty.csv`

Also update `scripts/check_licenses.js` to support resolving npm aliases.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jan 17, 2026
BridgeAR pushed a commit that referenced this pull request Jan 22, 2026
Bump `dd-license-attribution` to the latest version which fixes two issues with
`LICENSE-3rdparty.csv`:
- Consistently use Windows style line endings
- Removes incorrect `@datadog/source-map` line from `LICENSE-3rdparty.csv`

Also update `scripts/check_licenses.js` to support resolving npm aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants