v5.84.0 proposal - #7347
Merged
Merged
Conversation
* fix: load files correctly for Cucumber and Playwright The require calls were not correctly aligned. This was detected due to type errors being visible for the wrong require calls. As drive-by add a few additional types. * test: add additional test cases --------- Co-authored-by: Juan Fernandez <juan.fernandezdealba@datadoghq.com>
Split up the very large basic.spec.js file into smaller scoped files
Retries once after waiting one minute.
…s 1 directory with 2 updates (#7185) * chore(deps): bump the vendor-minor-and-patch-dependencies group across 1 directory with 2 updates Bumps the vendor-minor-and-patch-dependencies group with 2 updates in the /vendor directory: [@isaacs/ttlcache](https://github.com/isaacs/ttlcache) and [esquery](https://github.com/estools/esquery). Updates `@isaacs/ttlcache` from 2.1.3 to 2.1.4 - [Changelog](https://github.com/isaacs/ttlcache/blob/main/CHANGELOG.md) - [Commits](isaacs/ttlcache@v2.1.3...v2.1.4) Updates `esquery` from 1.6.0 to 1.7.0 - [Commits](https://github.com/estools/esquery/commits) --- updated-dependencies: - dependency-name: "@isaacs/ttlcache" dependency-version: 2.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: vendor-minor-and-patch-dependencies - dependency-name: esquery dependency-version: 1.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: vendor-minor-and-patch-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * update vendored dependencies with new versions Co-authored-by: github-actions <github-actions@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
These are mostly passing through stdio as argument to exec, which does not support that argument. In addition, fix a couple of process.env types and add some more types to test helpers. There is one spot where `parallel` was defined was not used in the test. That is removed as well as activating the no-undef eslint rule for test-optimization code. On top, the assertObjectContains helper got improved to always generate a diff in the future, even on older Node.js versions.
The vendoring validation would happen if dev dependencies were updated. These would not create a bundle and that caused issues. The major updates were also not taken into account for vendoring and that is now the case. Instead of relying on the group, we verify what files are changed.
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This increases the overall runtime a lot.
…7329) This should a) reduce github API rate limit usages and b) increase the overall success rate of the all-green job for long running processes as well as jobs that hit the API rate limit early on. Six minutes is chosen as our CI normally needs about twice as long overall and even if we optimize slow runs away, we likely will not drop below six minutes. Re-running our CI will not have the delay. The verbose mode allows to understand better why the job fails, which is currently partially difficult.
) The AgentInfoExporter class had mixed responsibilities, serving as both an agent info fetcher and a trace buffering exporter. This made the code confusing and led to unnecessary instantiations. Changes: - Split agent info fetching into agent/info.js with fetchAgentInfo utility - Extract buffering logic into BufferingExporter base class - Update CiVisibilityExporter to extend BufferingExporter - Update openfeature and llmobs writers to use fetchAgentInfo directly This improves code clarity by adhering to single responsibility principle and reduces overhead by avoiding unnecessary class instantiations when only agent info is needed.
The vendoring still had two issues. 1. Updated dev dependencies should also run the vendoring, since these may change how the bundle is minified. This is not taken into account. 2. The artifact generated was added to the repository. That way we actually also added the patch file itself to the repository. That works once, while creating the second patch would not conflict. This is fixed by generating the file outside of the repository and only applying ./vendor as patch. The patch file is now ignored, to further mitigate the risk for this to happen again in case the code is refactored, * chore: fix type error and improve error output while bundling
…switch is passed through environment variables (#7141)
Implements a URL-keyed cache for /info endpoint responses to reduce unnecessary HTTP requests to the agent. Cache entries expire after 60 seconds.
* chore(deps): bump protobufjs from 7.5.4 to 8.0.0 in /vendor Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.5.4 to 8.0.0. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@protobufjs-v7.5.4...protobufjs-v8.0.0) --- updated-dependencies: - dependency-name: protobufjs dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * update vendored dependencies with new versions Co-authored-by: github-actions <github-actions@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
* chore(deps): bump meriyah from 6.1.4 to 7.0.0 in /vendor Bumps [meriyah](https://github.com/meriyah/meriyah) from 6.1.4 to 7.0.0. - [Release notes](https://github.com/meriyah/meriyah/releases) - [Changelog](https://github.com/meriyah/meriyah/blob/main/CHANGELOG.md) - [Commits](meriyah/meriyah@v6.1.4...v7.0.0) --- updated-dependencies: - dependency-name: meriyah dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ion (#7339) * support var class instance method patching * add additional test for non-var case
Includes fix for OF.7: empty string is now accepted as a valid targeting key.
The files were missing multiple entries as well as having too many entries. This is now fixed by adding a test that verifies the correctness.
Closed
Contributor
Overall package sizeSelf size: 4.46 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.3 | 76.87 kB | 808.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v5.x #7347 +/- ##
==========================================
+ Coverage 83.19% 86.03% +2.84%
==========================================
Files 476 515 +39
Lines 20153 22249 +2096
==========================================
+ Hits 16766 19142 +2376
+ Misses 3387 3107 -280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The vendor/dist directory contains bundled dependencies that don't need to be scanned as part of the project's code analysis.
dd-octo-sts
Bot
force-pushed
the
v5.84.0-proposal
branch
from
January 29, 2026 05:22
81c9b00 to
99c7de1
Compare
Remove unused tags parameter from agent proxy and add default timeout value to DI logs writer constructor. This consolidates the default timeout logic and removes unnecessary parameter passing.
Fixes a race condition in AgentProxyCiVisibilityExporter where `_isGzipCompatible` and `evpProxyPrefix` could be read before being set, causing intermittent test failures in CI. The race condition was amplified by commit 6eed53f which added caching to fetchAgentInfo. When the cache is hit, the callback runs via process.nextTick (extremely fast), making the timing window between promise resolution and property assignment visible. Production code fix: - Move `this._isGzipCompatible = isGzipCompatible` to execute before `this._resolveCanUseCiVisProtocol()` in the callback - This ensures the property is set before tests (or production code) can read it after awaiting `_canUseCiVisProtocolPromise` - Matches the pattern in AgentlessCiVisibilityExporter Test cleanup fix: - Add `nock.cleanAll()` to beforeEach hook to prevent HTTP mock state leakage between tests - Without cleanup, nock interceptors from previous tests could interfere with subsequent tests - Follows the pattern in exporter.spec.js and other test files Fixes 4 flaky tests: - _isGzipCompatible (v4+ and v3 version checks) - evpProxyPrefix (v2 and v4 prefix assignments)
… updates Recreates the reverted PR #7371 with fixed CI
Add command templates for commit messages, PR bodies, and branch testing to standardize workflows. Update .gitignore to track .cursor/commands while keeping .cursor/skills ignored.
* feat(openfeature): add env vars for flagging provider configuration Add environment variable support for: - DD_FLAGGING_PROVIDER_ENABLED / DD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLED - DD_FLAGGING_PROVIDER_INITIALIZATION_TIMEOUT_MS / DD_EXPERIMENTAL_FLAGGING_PROVIDER_INITIALIZATION_TIMEOUT_MS * fix(openfeature): use only DD_EXPERIMENTAL_* env vars for flagging provider Remove support for non-experimental env vars (DD_FLAGGING_PROVIDER_ENABLED and DD_FLAGGING_PROVIDER_INITIALIZATION_TIMEOUT_MS) to align with other Datadog tracers (Go, Python, Ruby, Java, .NET) which only support the DD_EXPERIMENTAL_* variants.
Resolve peer dependency errors for dd-trace users who don't directly use OpenFeature. Fixes: #6986
dd-octo-sts
Bot
force-pushed
the
v5.84.0-proposal
branch
from
January 29, 2026 19:05
99c7de1 to
b132508
Compare
BridgeAR
marked this pull request as ready for review
January 29, 2026 19:26
leoromanovsky
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0aa9ce26a9] - (SEMVER-PATCH) chore: update @datadog/openfeature-node-server to 0.3.3 (Leo Romanovsky) #738360286914e9] - (SEMVER-PATCH) refactor(debugger): optimize JSONBuffer timer management (Thomas Watson) #73657b348ca052] - (SEMVER-PATCH) add env var to configure ffe init time (Leo Romanovsky) #694827af201bf1] - (SEMVER-PATCH) chore: Update @fastify/multipart used in tests to the latest version (Ugaitz Urien) #7379d51ac85dbc] - (SEMVER-PATCH) chore: add Cursor command templates (Thomas Watson) #73781f484403e8] - chore(deps): bump the test-versions group across 3 directories with 7 updates (Ugaitz Urien)e12c19568c] - (SEMVER-PATCH) fix(ci-visibility): fix race condition in agent-proxy exporter (Thomas Watson) #7375a2ff6675cc] - (SEMVER-PATCH) refactor(ci-visibility): simplify DI logs writer (Thomas Watson) #7373d119cf223d] - (SEMVER-PATCH) Revert "chore(deps): bump the test-versions group across 3 directories with 7 updates (chore(deps): bump the test-versions group across 3 directories with 7 updates #7371)" (Thomas Watson) #7374be2e01cd5b] - (SEMVER-PATCH) chore(deps): bump the test-versions group across 3 directories with 7 updates (dependabot[bot]) #7371b7a7392f86] - (SEMVER-PATCH) fix super support for traceCallback (Roch Devost) #7327081a148823] - (SEMVER-PATCH) AppSec optimizations (simon-id) #7168f763fd37be] - (SEMVER-PATCH) ci: make vendoring in CI more robust (Ruben Bridgewater) #73435572149f18] - (SEMVER-PATCH) [test optimization] Fixtest.statusreported in test sessions including quarantined tests (Juan Antonio Fernández de Alba) #7353e67b47e8d7] - (SEMVER-PATCH) docs: add integration test permissions note to AGENTS.md (Thomas Watson) #73622c57dccc96] - (SEMVER-PATCH) [test optimization] Fix mocks onjesttests when retried with ATF, EFD or impacted tests (Juan Antonio Fernández de Alba) #7352424bd1bf89] - (SEMVER-PATCH) chore(deps): bump the gh-actions-packages group across 11 directories with 5 updates (dependabot[bot]) #736199aef7c791] - (SEMVER-PATCH) chore: remove unnecessary if condition (Pablo Erhard) #7354be8dc65e69] - (SEMVER-PATCH) refactor: centralize agent URL construction into getAgentUrl helper (Thomas Watson) #7311089e8e1a3e] - (SEMVER-PATCH) fix(agent): improve fetchAgentInfo error handling (Thomas Watson) #73137b864e2d96] - (SEMVER-PATCH) docs: instruct Aider and Gemini CLI to use AGENTS.md (Thomas Watson) #7348f9a04bed52] - (SEMVER-PATCH) ci(codeql): exclude vendor/dist from analysis (Thomas Watson) #7349b084a8de58] - (SEMVER-PATCH) doc: fix API.md and index.d.ts to include the plugins (Ruben Bridgewater) #7341af9056a7ea] - (SEMVER-PATCH) Bump @datadog/openfeature-node-server to 0.3.1 (Leo Romanovsky) #7344fbc82c25c4] - (SEMVER-PATCH) fix(langchain, core): properly handle class expressions with orchestrion (Sam Brenner) #7339137125b3d3] - (SEMVER-PATCH) chore(deps): bump meriyah from 6.1.4 to 7.0.0 in /vendor (dependabot[bot]) #7160f8ac5f9843] - (SEMVER-PATCH) chore(deps): bump protobufjs from 7.5.4 to 8.0.0 in /vendor (dependabot[bot]) #7161daecbd48b6] - (SEMVER-MINOR) feat(debugger): support Live Debugger Remote Enablement (Thomas Watson) #73176eed53f44d] - (SEMVER-PATCH) perf(agent): cache agent info requests for 1 minute (Thomas Watson) #73122d19e95fbf] - (SEMVER-PATCH) fix(test-optimization): no advanced features are enabled if ITR kill switch is passed through environment variables (Calvin Bayer) #71419e11e52a90] - (SEMVER-PATCH) ci: fix vendoring completely (Ruben Bridgewater) #7328e6e966d125] - (SEMVER-PATCH) refactor(exporters): split AgentInfoExporter into focused modules (Thomas Watson) #7310ab24010071] - (SEMVER-PATCH) chore: add .cursor dir to .gitignore (Thomas Watson) #73334a749eeafa] - (SEMVER-PATCH) chore: addyarn addcommand to AGENTS.md (Thomas Watson) #73346d656a3924] - (SEMVER-PATCH) ci: delay all-green check for six minutes and activate verbose mode (Ruben Bridgewater) #7329262d4e4f06] - (SEMVER-PATCH) ci: split azure functions integration tests into multiple jobs (Roch Devost) #7301b25f5928d8] - (SEMVER-PATCH) chore: remove plugin checklist from PR template (simon-id) #710578a05369e3] - (SEMVER-PATCH) chore(deps): bump lodash from 4.17.21 to 4.17.23 (dependabot[bot]) #7303494217fdf7] - (SEMVER-PATCH) fix log publish format (Roch Devost) #72935b46416622] - (SEMVER-PATCH) [test optimization] Fix attempt to fix logic in playwright (Juan Antonio Fernández de Alba) #73256b0ccd2d05] - (SEMVER-PATCH) ci: fix vendoring pipeline (Ruben Bridgewater) #7316b1c41b8625] - (SEMVER-PATCH) test: fix type issues in test optimization tests (Ruben Bridgewater) #7297b4af38d2d7] - (SEMVER-PATCH) chore(deps): bump the vendor-minor-and-patch-dependencies group across 1 directory with 2 updates (dependabot[bot]) #71850943c1400f] - (SEMVER-PATCH) test: retry npm install of wasm-js-rewriter (Roch Devost) #6775daa5dbd021] - (SEMVER-PATCH) chore(test): refactor debugger integration tests (Thomas Watson) #73150345cbaee3] - (SEMVER-PATCH) fix: load files correctly for Cucumber and Playwright (Ruben Bridgewater) #7281