Skip to content

feat(config): enable startup logs by default #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bm1549 merged 6 commits into from
Mar 18, 2026
Merged

feat(config): enable startup logs by default #7474

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
294f91f
feat(config): enable startup logs by default
bm1549 Mar 6, 2026
6e9a1bd
Merge branch 'master' into brian.marks/startup-log-default-enablement
bm1549 Mar 17, 2026
63d6d7f
fix(test): disable startup logs in RASP integration tests
bm1549 Mar 17, 2026
2f5e627
fix(config): update DD_TRACE_STARTUP_LOGS implementation level to C
bm1549 Mar 17, 2026
d271066
fix(config): gate startup logs default behind DD_MAJOR version check
bm1549 Mar 17, 2026
63a1ba1
test(config): use DD_MAJOR to determine startupLogs default in tests
bm1549 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration-tests/appsec/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ describe('RASP', () => {
DD_APPSEC_RASP_ENABLED: 'true',
DD_APPSEC_RULES: path.join(cwd, 'appsec/rasp/rasp_rules.json'),
DD_APPSEC_RASP_COLLECT_REQUEST_BODY: String(collectRequestBody),
DD_TRACE_STARTUP_LOGS: 'false',
Copy link
Copy Markdown
Contributor Author

@bm1549 bm1549 Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appsec test makes sure that no logs exist when blocking a request. Rather than patching it to ignore the DD startup log, this seemed more correct

},
}, stdOutputHandler, stdOutputHandler)
axios = Axios.create({ baseURL: proc.url })
Expand Down
2 changes: 2 additions & 0 deletions packages/dd-trace/src/config/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

const pkg = require('../pkg')
const { isFalse, isTrue } = require('../util')
const { DD_MAJOR } = require('../../../../version')
const { getEnvironmentVariable: getEnv } = require('./helper')

const {
Expand Down Expand Up @@ -117,6 +118,7 @@ const defaultsWithoutSupportedConfigurationEntry = {
// TODO: These entries should be removed. They are off by default
// because they rely on other configs.
const defaultsWithConditionalRuntimeBehavior = {
startupLogs: DD_MAJOR >= 6,
isGitUploadEnabled: false,
isImpactedTestsEnabled: false,
isIntelligentTestRunnerEnabled: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/dd-trace/test/config/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ describe('Config', () => {
{ name: 'spanAttributeSchema', value: 'v0', origin: 'default' },
{ name: 'spanComputePeerService', value: false, origin: 'calculated' },
{ name: 'spanRemoveIntegrationFromService', value: false, origin: 'default' },
{ name: 'startupLogs', value: false, origin: 'default' },
{ name: 'startupLogs', value: true, origin: 'default' },
{ name: 'stats.enabled', value: false, origin: 'calculated' },
{ name: 'tagsHeaderMaxLength', value: 512, origin: 'default' },
{ name: 'telemetry.debug', value: false, origin: 'default' },
Expand Down
Loading