feat(llmobs): support custom telemetry metadata in Vercel AI SDK spans#7556
feat(llmobs): support custom telemetry metadata in Vercel AI SDK spans#7556
Conversation
Add getTelemetryMetadata function to extract custom metadata from ai.telemetry.metadata.* attributes and include them in LLMObs span metadata for text generation, object generation, and embedding workflow operations.
Co-authored-by: Sam Brenner <106700075+sabrenner@users.noreply.github.com>
Overall package sizeSelf size: 5.47 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7556 +/- ##
==========================================
+ Coverage 73.85% 73.87% +0.02%
==========================================
Files 773 773
Lines 35959 35985 +26
==========================================
+ Hits 26558 26585 +27
+ Misses 9401 9400 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f3ae286 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, I just left a few suggestions for a faster implementation. There is still a bit of code duplication, while abstracting these would likely not improve much, so I think that is good as is.
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
#7556) * feat(llmobs): support custom telemetry metadata in Vercel AI SDK spans Add getTelemetryMetadata function to extract custom metadata from ai.telemetry.metadata.* attributes and include them in LLMObs span metadata for text generation, object generation, and embedding workflow operations. * Update packages/dd-trace/src/llmobs/plugins/ai/util.js Co-authored-by: Sam Brenner <106700075+sabrenner@users.noreply.github.com> * source cleanups * test cleanups * minor cleanup * review comments * Update packages/dd-trace/src/llmobs/plugins/ai/util.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> * Update packages/dd-trace/src/llmobs/plugins/ai/util.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> * fmt * apply review changes --------- Co-authored-by: Isaac Wasserman <isaacrwasserman@gmail.com> Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
#7556) * feat(llmobs): support custom telemetry metadata in Vercel AI SDK spans Add getTelemetryMetadata function to extract custom metadata from ai.telemetry.metadata.* attributes and include them in LLMObs span metadata for text generation, object generation, and embedding workflow operations. * Update packages/dd-trace/src/llmobs/plugins/ai/util.js Co-authored-by: Sam Brenner <106700075+sabrenner@users.noreply.github.com> * source cleanups * test cleanups * minor cleanup * review comments * Update packages/dd-trace/src/llmobs/plugins/ai/util.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> * Update packages/dd-trace/src/llmobs/plugins/ai/util.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> * fmt * apply review changes --------- Co-authored-by: Isaac Wasserman <isaacrwasserman@gmail.com> Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
What does this PR do?
Closes #7322 (by porting its commits and cleaning it up)
Motivation
Adds support for recording telemetry metadata for Vercel AI SDK telemetry on Datadog LLM Observability span events' metadata field.