Skip to content

[DRAFT] NOT MERGING POC: Send Node.js runtime metrics via OTLP using OTel-native naming#7869

Draft
link04 wants to merge 4 commits intomasterfrom
maximo/otlp-runtime-metrics-poc
Draft

[DRAFT] NOT MERGING POC: Send Node.js runtime metrics via OTLP using OTel-native naming#7869
link04 wants to merge 4 commits intomasterfrom
maximo/otlp-runtime-metrics-poc

Conversation

@link04
Copy link
Copy Markdown

@link04 link04 commented Mar 27, 2026

Do not review — initial POC only.

Sends v8js.memory.heap., process.cpu.utilization, process.memory.usage, nodejs.eventloop.delay. via OTLP. Related: DataDog/dd-trace-dotnet#8299

🤖 Generated with Claude Code

Adds v8js.memory.heap.*, process.cpu.utilization, process.memory.usage,
nodejs.eventloop.delay.* as OTel instruments on the existing OTLP
metrics pipeline.

Routes to OTLP when config.otelMetricsEnabled is true, skipping
DogStatsD to avoid double-reporting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Overall package size

Self size: 5.46 MB
Deduped: 6.3 MB
No deduping: 6.3 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 bot commented Mar 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 68.73% (+4.16%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 661d1d6 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@link04 link04 changed the title POC: Send Node.js runtime metrics via OTLP using OTel-native naming [DRAFT] NOT MERGING POC: Send Node.js runtime metrics via OTLP using OTel-native naming Mar 27, 2026
- Remove unused sinon import
- Remove unused DEFAULT_INTERVAL constant
- Use ternary in router per lint rule
- Break long lines under 120 char limit
- Add trailing commas per style

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.27%. Comparing base (64890d7) to head (661d1d6).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7869      +/-   ##
==========================================
- Coverage   74.61%   74.27%   -0.34%     
==========================================
  Files         768      765       -3     
  Lines       35659    35793     +134     
==========================================
- Hits        26606    26586      -20     
- Misses       9053     9207     +154     
Flag Coverage Δ
aiguard-macos 39.41% <0.00%> (+0.08%) ⬆️
aiguard-ubuntu 39.53% <0.00%> (+0.09%) ⬆️
aiguard-windows 39.20% <0.00%> (+0.08%) ⬆️
apm-capabilities-tracing-macos 49.18% <100.00%> (+0.07%) ⬆️
apm-capabilities-tracing-ubuntu 49.10% <100.00%> (+0.07%) ⬆️
apm-capabilities-tracing-windows 48.96% <100.00%> (+0.07%) ⬆️
apm-integrations-child-process 38.74% <0.00%> (+0.08%) ⬆️
apm-integrations-couchbase-18 37.55% <0.00%> (+0.09%) ⬆️
apm-integrations-couchbase-eol 38.04% <0.00%> (+0.10%) ⬆️
apm-integrations-oracledb 37.87% <0.00%> (+0.09%) ⬆️
appsec-express 55.39% <0.00%> (+0.15%) ⬆️
appsec-fastify 51.72% <0.00%> (+0.13%) ⬆️
appsec-graphql 51.87% <0.00%> (+0.12%) ⬆️
appsec-kafka 44.50% <0.00%> (+0.11%) ⬆️
appsec-ldapjs 44.11% <0.00%> (+0.10%) ⬆️
appsec-lodash 43.71% <0.00%> (+0.09%) ⬆️
appsec-macos 58.15% <0.00%> (-0.11%) ⬇️
appsec-mongodb-core 48.89% <0.00%> (+0.12%) ⬆️
appsec-mongoose 49.55% <0.00%> (+0.12%) ⬆️
appsec-mysql 51.08% <0.00%> (+0.22%) ⬆️
appsec-node-serialize 43.29% <0.00%> (+0.09%) ⬆️
appsec-passport 47.76% <0.00%> (+0.13%) ⬆️
appsec-postgres 50.70% <0.00%> (+0.12%) ⬆️
appsec-sourcing 42.54% <0.00%> (+0.09%) ⬆️
appsec-stripe 44.73% <0.00%> (+0.10%) ⬆️
appsec-template 43.46% <0.00%> (+0.09%) ⬆️
appsec-ubuntu 58.23% <0.00%> (-0.09%) ⬇️
appsec-windows 57.95% <0.00%> (-0.12%) ⬇️
instrumentations-instrumentation-bluebird 32.32% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-body-parser 40.63% <0.00%> (+0.09%) ⬆️
instrumentations-instrumentation-child_process 38.07% <0.00%> (+0.07%) ⬆️
instrumentations-instrumentation-cookie-parser 34.35% <0.00%> (+0.03%) ⬆️
instrumentations-instrumentation-express 34.67% <0.00%> (+0.03%) ⬆️
instrumentations-instrumentation-express-mongo-sanitize 34.48% <0.00%> (+0.03%) ⬆️
instrumentations-instrumentation-express-session 40.27% <0.00%> (+0.08%) ⬆️
instrumentations-instrumentation-fs 32.00% <0.00%> (+0.01%) ⬆️
instrumentations-instrumentation-generic-pool 29.46% <0.00%> (+<0.01%) ⬆️
instrumentations-instrumentation-http 39.99% <0.00%> (+0.09%) ⬆️
instrumentations-instrumentation-knex 32.39% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-mongoose 33.51% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-multer 40.38% <0.00%> (+0.08%) ⬆️
instrumentations-instrumentation-mysql2 38.40% <0.00%> (+0.07%) ⬆️
instrumentations-instrumentation-passport 44.16% <0.00%> (+0.10%) ⬆️
instrumentations-instrumentation-passport-http 43.84% <0.00%> (+0.10%) ⬆️
instrumentations-instrumentation-passport-local 44.37% <0.00%> (+0.10%) ⬆️
instrumentations-instrumentation-pg 37.84% <0.00%> (+0.07%) ⬆️
instrumentations-instrumentation-promise 32.25% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-promise-js 32.26% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-q 32.30% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-url 32.22% <0.00%> (+0.02%) ⬆️
instrumentations-instrumentation-when 32.27% <0.00%> (+0.02%) ⬆️
llmobs-ai 41.61% <0.00%> (-0.86%) ⬇️
llmobs-anthropic 40.84% <0.00%> (+0.36%) ⬆️
llmobs-bedrock 39.32% <0.00%> (+0.07%) ⬆️
llmobs-google-genai 39.87% <0.00%> (+0.07%) ⬆️
llmobs-langchain 39.45% <0.00%> (-0.71%) ⬇️
llmobs-openai 44.12% <0.00%> (+0.14%) ⬆️
llmobs-vertex-ai 40.13% <0.00%> (+0.08%) ⬆️
platform-core 31.47% <0.00%> (ø)
platform-esbuild 34.42% <0.00%> (ø)
platform-instrumentations-misc 34.11% <0.00%> (-14.30%) ⬇️
platform-shimmer 37.56% <0.00%> (ø)
platform-unit-guardrails 32.89% <0.00%> (ø)
platform-webpack 19.96% <0.00%> (-0.08%) ⬇️
plugins-azure-durable-functions 25.74% <0.00%> (ø)
plugins-azure-event-hubs 25.90% <0.00%> (ø)
plugins-azure-service-bus 25.26% <0.00%> (ø)
plugins-bullmq 43.61% <0.00%> (-0.88%) ⬇️
plugins-cassandra 38.02% <0.00%> (+0.07%) ⬆️
plugins-cookie 26.96% <0.00%> (ø)
plugins-cookie-parser 26.75% <0.00%> (ø)
plugins-crypto 26.73% <0.00%> (ø)
plugins-dd-trace-api 38.43% <0.00%> (+0.07%) ⬆️
plugins-express-mongo-sanitize 26.89% <0.00%> (ø)
plugins-express-session 26.70% <0.00%> (ø)
plugins-fastify 42.36% <0.00%> (+0.10%) ⬆️
plugins-fetch 38.51% <0.00%> (+0.07%) ⬆️
plugins-fs 38.75% <0.00%> (+0.07%) ⬆️
plugins-generic-pool 25.94% <0.00%> (ø)
plugins-google-cloud-pubsub 45.69% <0.00%> (+0.11%) ⬆️
plugins-grpc 41.01% <0.00%> (+0.08%) ⬆️
plugins-handlebars 26.94% <0.00%> (ø)
plugins-hapi 40.27% <0.00%> (+0.09%) ⬆️
plugins-hono 40.61% <0.00%> (+0.09%) ⬆️
plugins-ioredis 38.60% <0.00%> (+0.10%) ⬆️
plugins-knex 26.57% <0.00%> (ø)
plugins-langgraph 37.99% <0.00%> (-0.56%) ⬇️
plugins-ldapjs 24.43% <0.00%> (ø)
plugins-light-my-request 26.30% <0.00%> (ø)
plugins-limitd-client 32.60% <0.00%> (+0.02%) ⬆️
plugins-lodash 26.03% <0.00%> (ø)
plugins-mariadb 39.61% <0.00%> (+0.08%) ⬆️
plugins-memcached 38.34% <0.00%> (+0.10%) ⬆️
plugins-microgateway-core 39.34% <0.00%> (+0.08%) ⬆️
plugins-moleculer 40.63% <0.00%> (+0.09%) ⬆️
plugins-mongodb 39.27% <0.00%> (+0.08%) ⬆️
plugins-mongodb-core 39.12% <0.00%> (+0.08%) ⬆️
plugins-mongoose 38.92% <0.00%> (+0.01%) ⬆️
plugins-multer 26.70% <0.00%> (ø)
plugins-mysql 39.45% <0.00%> (+0.23%) ⬆️
plugins-mysql2 39.40% <0.00%> (+0.08%) ⬆️
plugins-node-serialize 27.00% <0.00%> (ø)
plugins-opensearch 37.74% <0.00%> (+0.07%) ⬆️
plugins-passport-http 26.76% <0.00%> (ø)
plugins-postgres 35.59% <0.00%> (-0.02%) ⬇️
plugins-process 26.73% <0.00%> (ø)
plugins-pug 26.96% <0.00%> (ø)
plugins-redis 39.04% <0.00%> (+0.08%) ⬆️
plugins-router 43.36% <0.00%> (+0.11%) ⬆️
plugins-sequelize 25.55% <0.00%> (ø)
plugins-test-and-upstream-amqp10 38.62% <0.00%> (+0.08%) ⬆️
plugins-test-and-upstream-amqplib 44.37% <0.00%> (+0.12%) ⬆️
plugins-test-and-upstream-apollo 39.24% <0.00%> (+0.07%) ⬆️
plugins-test-and-upstream-avsc 38.69% <0.00%> (+0.08%) ⬆️
plugins-test-and-upstream-bunyan 33.93% <0.00%> (+0.04%) ⬆️
plugins-test-and-upstream-connect 40.93% <0.00%> (+0.09%) ⬆️
plugins-test-and-upstream-graphql 40.28% <0.00%> (+0.09%) ⬆️
plugins-test-and-upstream-koa 40.52% <0.00%> (-0.05%) ⬇️
plugins-test-and-upstream-protobufjs 38.92% <0.00%> (+0.08%) ⬆️
plugins-test-and-upstream-rhea 44.37% <0.00%> (+0.09%) ⬆️
plugins-undici 39.36% <0.00%> (+0.20%) ⬆️
plugins-url 26.73% <0.00%> (ø)
plugins-valkey 38.31% <0.00%> (+0.10%) ⬆️
plugins-vm 26.73% <0.00%> (ø)
plugins-winston 34.26% <0.00%> (+0.18%) ⬆️
plugins-ws 42.12% <0.00%> (+0.10%) ⬆️
profiling-macos 40.65% <0.00%> (+0.15%) ⬆️
profiling-ubuntu 40.78% <0.00%> (+0.15%) ⬆️
profiling-windows 42.30% <0.00%> (+0.53%) ⬆️
serverless-azure-functions-client 25.62% <0.00%> (ø)
serverless-azure-functions-eventhubs 25.62% <0.00%> (ø)
serverless-azure-functions-servicebus 25.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 27, 2026

Benchmarks

Benchmark execution time: 2026-04-03 18:20:30

Comparing candidate commit 661d1d6 in PR branch maximo/otlp-runtime-metrics-poc with baseline commit 64890d7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 226 metrics, 34 unstable metrics.

link04 and others added 2 commits April 2, 2026 14:17
Adds the mapped metric (nodejs.eventloop.utilization) and higher
percentiles. Fixes lint errors. Total: 13 OTel metrics.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add assertions for nodejs.eventloop.delay.p90, p99, and
nodejs.eventloop.utilization. Verify disabled state for
new event loop metrics. Matches existing runtime_metrics.spec.js
pattern of verifying every metric by name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
link04 added a commit to DataDog/system-tests that referenced this pull request Apr 9, 2026
New scenario OTLP_RUNTIME_METRICS that sets DD_METRICS_OTEL_ENABLED=true
alongside DD_RUNTIME_METRICS_ENABLED=true. Tests verify OTel-native metric
names (dotnet.*, jvm.*, go.*, v8js.*) appear in OTLP payloads and that
DD-proprietary names (runtime.dotnet.*, runtime.go.*) do not.

All languages marked as missing_feature in manifests until POC PRs are merged:
- .NET: DataDog/dd-trace-dotnet#8299
- Go: DataDog/dd-trace-go#4611
- Node.js: DataDog/dd-trace-js#7869
- Java: DataDog/dd-trace-java#10985

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant