feat(span): internal API split for Span#7881
Open
pabloerhard wants to merge 32 commits intomasterfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7881 +/- ##
==========================================
+ Coverage 73.82% 73.84% +0.02%
==========================================
Files 773 774 +1
Lines 35972 36020 +48
==========================================
+ Hits 26556 26600 +44
- Misses 9416 9420 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Overall package sizeSelf size: 5.48 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d8be3e0 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksBenchmark execution time: 2026-04-10 02:39:40 Comparing candidate commit d8be3e0 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 229 metrics, 31 unstable metrics. |
rochdev
requested changes
Mar 30, 2026
| testName, | ||
| testStatus, | ||
| finishTime: this.activeTestSpan._getTime(), // we store the finish time here | ||
| finishTime: activeSpan._getTime(), // we store the finish time here |
Member
There was a problem hiding this comment.
What should be on the store is an internal span, not a public span, so this change shouldn't be needed.
Contributor
Author
There was a problem hiding this comment.
This does not come from the store, it uses the tracer to start a span which then returns a wrapped a span.
pabloerhard
changed the title
pabloerhard
commented
Apr 7, 2026
| ERROR_STACK: 'error.stack', | ||
| IGNORE_OTEL_ERROR: Symbol('ignore.otel.error'), | ||
| COMPONENT: 'component', | ||
| SVC_SRC_KEY: '_dd.svc_src', |
Contributor
Author
There was a problem hiding this comment.
This file change will not be needed once #7824 is merged.
This should be resolved depending on what PR gets merged first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an internal API split for Span which allows a distinction between the internal use of Span and the user use of Span. This internal API split consists of adding a wrapper to the user exposed Span through the proxy.
This PR adds the wrapper on the proxy exposed startSpand, the internal trace which is mostly user used and the internal scope.
Motivation
Having a distinction between internal and external use of Span, and acting accoridngly.
Additional Notes