fix nextjs memory leak from req weakmap#7946
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7946 +/- ##
=======================================
Coverage 73.86% 73.87%
=======================================
Files 773 773
Lines 35955 35949 -6
=======================================
- Hits 26558 26557 -1
+ Misses 9397 9392 -5 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Overall package sizeSelf size: 5.47 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 3fd5b18 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Member
Author
rochdev
force-pushed
the
fix-next-req-map-leak
branch
from
41a5e4d to
3fd5b18
Compare
dd-octo-sts bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
The WeakMap was effectively creating a strong reference and memory was not freed anymore. Instead, rely on the storage for state handling.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Next.js memory leak from req WeakMap.
Motivation
Regression from #7000 reported in #7878. The original fix kept the WeakMap and cleaned it up manually, which fixes the symptom but not the underlying issue that we shouldn't be storing things in a map to begin with and instead rely on AsyncLocalStorage which is 100% safe.
Additional Notes