Skip to content

v5.117.0 proposal - #9505

Merged
szegedi merged 4 commits into
v5.xfrom
v5.117.0-proposal
Jul 23, 2026
Merged

v5.117.0 proposal#9505
szegedi merged 4 commits into
v5.xfrom
v5.117.0-proposal

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Features

  • Profiling: Pack column numbers for server-side unminification #9501

Fixes

  • Test Optimization: Complete test runs after subscriber loss #9381

Internal (CI, Testing, Benchmarking)

  • Dependencies: Bump pnpm #9498

dependabot Bot and others added 4 commits July 23, 2026 11:36
Bumps the test-versions group with 1 update in the /packages/dd-trace/test/plugins/versions directory: [pnpm](https://github.com/pnpm/pnpm/tree/HEAD/pnpm11/pnpm).


Updates `pnpm` from 11.15.0 to 11.15.1
- [Release notes](https://github.com/pnpm/pnpm/releases)
- [Commits](https://github.com/pnpm/pnpm/commits/v11.15.1/pnpm11/pnpm)

---
updated-dependencies:
- dependency-name: pnpm
  dependency-version: 11.15.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-versions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(test-optimization): complete test runs after subscriber loss

Finish subscribers can disable themselves while handling a diagnostic-channel publication, leaving no callback owner and hanging the framework run indefinitely. Treat losing the last subscriber as completion while preserving exporter-backed waits and Jest's timeout.

* test(test-optimization): cover vitest suite finish and cucumber config-loss

The vitest worker suite-finish path (the one that awaits the flush through the
shared channel helper) had no dedicated instrumentation spec and no CI job, so
its subscriber-loss behavior rode only on end-to-end coverage. Add a real-path
spec driving the `@vitest/runner` `startTests` hook, plus `instrumentation-vitest`
and `instrumentation-cucumber` jobs alongside the other frameworks.

The cucumber spec now pins the `|| {}` guard in getWrappedStart: a
library-configuration subscriber that disables itself without responding resolves
the request to `undefined`, and the run must still finish with every remote
feature treated as disabled.

Drive-by fix:

* Drop `frameworkVersion` from the vitest worker `testSuiteFinishCh` payload; the
  suite-finish subscriber never reads it and it is already carried in currentStore.

* fix(test-optimization): finish runs after plugin lifecycle errors

Mocha configuration requests publish through runStores, so an internal handler error can disable the plugin and leave delayed startup waiting forever. Re-enabling Playwright after test start can leave an active finish subscriber without a span, whose early return similarly never releases the worker.
…9501)

* feat(profiling): pack column numbers for server-side unminification

Updates profiler to 5.17.0, and then sets columnNumbers: 'pack' on the wall profiler and pass 'pack' to the space profiler's heap.profile call. pprof 5.17.0 packs the column into the line only for frames whose source map is declared but missing (dd:has-missing-map-files) — exactly the frames sent for server-side unminification — so this lets the
backend deobfuscate minified Node.js (e.g. Next.js server) frames, where the column is the only discriminator between functions on a single generated line.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Jul 23, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Overall package size

Self size: 7.49 MB
Deduped: 8.15 MB
No deduping: 8.15 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.2 | 124.41 kB | 440.65 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-official

datadog-official Bot commented Jul 23, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 99.54%
Overall Coverage: 98.47%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 15f08de | Docs | Datadog PR Page | Give us feedback!

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.54545% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.45%. Comparing base (6b35e7d) to head (15f08de).
⚠️ Report is 1918 commits behind head on v5.x.

Files with missing lines Patch % Lines
...ackages/datadog-instrumentations/src/mocha/main.js 98.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             v5.x    #9505       +/-   ##
===========================================
+ Coverage   83.19%   98.45%   +15.26%     
===========================================
  Files         476      941      +465     
  Lines       20153   126966   +106813     
  Branches        0    10824    +10824     
===========================================
+ Hits        16766   125008   +108242     
+ Misses       3387     1958     -1429     
Flag Coverage Δ
aiguard 57.38% <ø> (?)
aiguard-integration 56.18% <ø> (?)
apm-bucket-0 58.59% <ø> (?)
apm-bucket-1 63.93% <ø> (?)
apm-bucket-2 62.69% <ø> (?)
apm-bucket-3 60.05% <ø> (?)
apm-capabilities-tracing 64.60% <83.33%> (?)
apm-integrations-aerospike 56.63% <ø> (?)
apm-integrations-confluentinc-kafka-javascript 61.57% <ø> (?)
apm-integrations-couchbase 57.07% <ø> (?)
apm-integrations-http 62.71% <ø> (?)
apm-integrations-kafkajs 62.12% <ø> (?)
apm-integrations-next 59.17% <ø> (?)
apm-integrations-prisma 58.65% <ø> (?)
appsec 72.84% <ø> (?)
appsec-express_fastify_graphql 70.35% <ø> (?)
appsec-integration 51.49% <36.50%> (?)
appsec-kafka_ldapjs_lodash 63.92% <ø> (?)
appsec-mongodb-core_mongoose_mysql 67.65% <ø> (?)
appsec-next 57.51% <59.78%> (?)
appsec-node-serialize_passport_postgres 67.32% <ø> (?)
appsec-sourcing_stripe_template 65.66% <ø> (?)
debugger 64.85% <ø> (?)
instrumentations-bucket-0 51.72% <ø> (?)
instrumentations-bucket-1 60.23% <ø> (?)
instrumentations-bucket-10 62.03% <ø> (?)
instrumentations-bucket-11 51.63% <ø> (?)
instrumentations-bucket-12 52.20% <ø> (?)
instrumentations-bucket-13 51.74% <ø> (?)
instrumentations-bucket-2 53.63% <ø> (?)
instrumentations-bucket-3 59.22% <ø> (?)
instrumentations-bucket-4 52.29% <ø> (?)
instrumentations-bucket-5 57.55% <38.56%> (?)
instrumentations-bucket-6 60.74% <ø> (?)
instrumentations-bucket-7 58.41% <ø> (?)
instrumentations-bucket-8 59.56% <ø> (?)
instrumentations-instrumentation-couchbase 51.02% <ø> (?)
instrumentations-integration-esbuild 34.30% <36.50%> (?)
llmobs-ai_anthropic_bedrock 62.74% <ø> (?)
llmobs-bucket-1 61.56% <ø> (?)
llmobs-openai 62.68% <ø> (?)
llmobs-sdk 66.13% <ø> (?)
llmobs-vertex-ai 59.18% <ø> (?)
openfeature 56.02% <ø> (?)
openfeature-unit 53.39% <ø> (?)
platform-core_esbuild_instrumentations-misc 40.62% <51.50%> (?)
platform-integration 61.37% <ø> (?)
platform-shimmer_unit-guardrails_webpack 39.04% <36.50%> (?)
plugins-bucket-0 57.05% <ø> (?)
plugins-bucket-1 54.30% <ø> (?)
plugins-bucket-11 62.28% <ø> (?)
plugins-bucket-18 61.96% <ø> (?)
plugins-bucket-19 60.04% <ø> (?)
plugins-bucket-20 62.06% <ø> (?)
plugins-bucket-4 58.58% <ø> (?)
plugins-bullmq_cassandra_cookie 61.75% <ø> (?)
plugins-cookie-parser_crypto_dd-trace-api 56.72% <ø> (?)
plugins-fetch_fs_generic-pool 58.77% <ø> (?)
plugins-google-cloud-pubsub_grpc_handlebars 64.69% <ø> (?)
plugins-hapi_hono_ioredis 60.22% <ø> (?)
plugins-jest_knex_langgraph 55.59% <ø> (?)
plugins-ldapjs_light-my-request_limitd-client 58.50% <ø> (?)
plugins-lodash_mariadb_memcached 58.00% <ø> (?)
plugins-moleculer_mongodb_mongodb-core 61.91% <ø> (?)
plugins-mongoose_multer_mysql 59.02% <ø> (?)
plugins-mysql2_nats_node-serialize 60.71% <ø> (?)
plugins-opensearch_passport-http_pino 59.54% <ø> (?)
plugins-postgres_process_pug 58.32% <ø> (?)
plugins-redis_router_sequelize 62.04% <ø> (?)
plugins-test-and-upstream-rhea_undici_url 61.63% <ø> (?)
plugins-valkey_vm_winston 58.01% <ø> (?)
plugins-ws 59.60% <ø> (?)
profiling 62.16% <100.00%> (?)
serverless-aws-sdk-aws-sdk 55.05% <38.56%> (?)
serverless-aws-sdk-bedrockruntime 54.76% <ø> (?)
serverless-aws-sdk-client 56.43% <ø> (?)
serverless-aws-sdk-dynamodb 55.66% <ø> (?)
serverless-aws-sdk-eventbridge 49.37% <38.56%> (?)
serverless-aws-sdk-kinesis 59.34% <ø> (?)
serverless-aws-sdk-lambda 57.39% <ø> (?)
serverless-aws-sdk-s3 55.61% <ø> (?)
serverless-aws-sdk-serverless-peer-service 59.74% <ø> (?)
serverless-aws-sdk-sns 60.14% <ø> (?)
serverless-aws-sdk-sqs 60.57% <ø> (?)
serverless-aws-sdk-stepfunctions 55.59% <ø> (?)
serverless-aws-sdk-util 51.47% <ø> (?)
serverless-bucket-0 54.04% <ø> (?)
serverless-bucket-1 59.26% <ø> (?)
test-optimization-cucumber 72.01% <92.26%> (?)
test-optimization-cypress 65.51% <88.38%> (?)
test-optimization-jest 73.43% <92.48%> (?)
test-optimization-mocha 73.47% <96.12%> (?)
test-optimization-playwright-playwright-atr 60.27% <90.12%> (?)
test-optimization-playwright-playwright-efd 60.50% <90.12%> (?)
test-optimization-playwright-playwright-final-status 60.47% <90.12%> (?)
test-optimization-playwright-playwright-impacted-tests 60.21% <90.12%> (?)
test-optimization-playwright-playwright-reporting 61.61% <91.97%> (?)
test-optimization-playwright-playwright-test-management 61.01% <90.12%> (?)
test-optimization-playwright-playwright-test-span 60.40% <90.12%> (?)
test-optimization-selenium 60.14% <92.47%> (?)
test-optimization-testopt 58.57% <80.27%> (?)
test-optimization-vitest 70.36% <92.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Jul 23, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-23 11:51:58

Comparing candidate commit 15f08de in PR branch v5.117.0-proposal with baseline commit db90af6 in branch v5.x.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2325 metrics, 33 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-20

  • unstable execution_time [-238.030ms; +226.136ms] or [-6.313%; +5.997%]

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-211.807ms; +214.889ms] or [-7.937%; +8.053%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-228.993ms; +234.366ms] or [-8.998%; +9.209%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-188.815ms; +184.179ms] or [-6.483%; +6.324%]

scenario:appsec-control-20

  • unstable cpu_user_time [-66.500ms; +70.533ms] or [-4.995%; +5.298%]
  • unstable execution_time [-191.278ms; +196.916ms] or [-10.670%; +10.985%]

scenario:appsec-control-24

  • unstable execution_time [-111176.031µs; +111358.831µs] or [-8.974%; +8.989%]

scenario:appsec-control-26

  • unstable execution_time [-120883.366µs; +122042.699µs] or [-9.756%; +9.850%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1857.238ms; +2935.402ms] or [-22.541%; +35.626%]
  • unstable execution_time [-1883.142ms; +2949.869ms] or [-21.061%; +32.991%]
  • unstable instructions [-15.6G instructions; +24.7G instructions] or [-23.158%; +36.815%]
  • unstable max_rss_usage [-8.334MB; +12.799MB] or [-5.302%; +8.144%]
  • unstable throughput [-809.893op/s; +522.207op/s] or [-22.049%; +14.217%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-2570.513ms; +4168.630ms] or [-26.903%; +43.628%]
  • unstable execution_time [-2600.246ms; +4141.987ms] or [-25.280%; +40.269%]
  • unstable instructions [-23.1G instructions; +36.8G instructions] or [-28.963%; +46.252%]
  • unstable max_rss_usage [-6.650MB; +13.726MB] or [-4.166%; +8.599%]
  • unstable throughput [-812.439op/s; +508.440op/s] or [-25.221%; +15.784%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-2.133s; +4.560s] or [-21.316%; +45.568%]
  • unstable execution_time [-2.105s; +4.541s] or [-19.607%; +42.306%]
  • unstable instructions [-19.0G instructions; +40.8G instructions] or [-22.780%; +48.778%]
  • unstable max_rss_usage [-6.780MB; +15.417MB] or [-4.226%; +9.610%]
  • unstable throughput [-985.575op/s; +456.381op/s] or [-31.712%; +14.685%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-462.477ms; +292.123ms] or [-9.316%; +5.884%]
  • unstable execution_time [-461.206ms; +296.055ms] or [-9.152%; +5.875%]
  • unstable throughput [-103221.098op/s; +157455.800op/s] or [-6.183%; +9.432%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-20

  • unstable max_rss_usage [-33.048MB; +38.319MB] or [-8.192%; +9.499%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable cpu_user_time [-607.454ms; +602.989ms] or [-5.268%; +5.229%]
  • unstable execution_time [-623.631ms; +613.268ms] or [-5.299%; +5.211%]
  • unstable throughput [-3.575op/s; +3.667op/s] or [-5.228%; +5.362%]

scenario:plugin-pg-service-24

  • unstable cpu_usage_percentage [-5.299%; +4.796%]
  • unstable execution_time [-106.685ms; +117.732ms] or [-6.270%; +6.919%]
  • unstable throughput [-198272.952op/s; +187513.590op/s] or [-5.572%; +5.269%]

@szegedi
szegedi marked this pull request as ready for review July 23, 2026 12:07
@szegedi
szegedi requested review from a team as code owners July 23, 2026 12:07
@szegedi
szegedi requested review from crysmags and removed request for a team July 23, 2026 12:07
@szegedi
szegedi merged commit 9c6a17b into v5.x Jul 23, 2026
658 checks passed
@szegedi
szegedi deleted the v5.117.0-proposal branch July 23, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants