Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
"@datadog/native-metrics": "3.1.2",
"@datadog/openfeature-node-server": "2.0.2",
"@datadog/pprof": "5.17.0",
"@datadog/wasm-js-rewriter": "5.0.1",
"@datadog/wasm-js-rewriter": "5.0.2",
"@opentelemetry/api": ">=1.0.0 <1.10.0",
"@opentelemetry/api-logs": "<1.0.0",
"oxc-parser": "^0.132.0"
Expand Down Expand Up @@ -253,5 +253,8 @@
"workerpool": "^10.0.3",
"yaml": "^2.9.0",
"yarn-deduplicate": "^6.0.2"
},
"resolutions": {
"@datadog/wasm-js-rewriter/js-yaml": "^4.3.1"
}
}
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -295,12 +295,12 @@
pprof-format "^2.2.1"
source-map "^0.8.0"

"@datadog/wasm-js-rewriter@5.0.1":
version "5.0.1"
resolved "https://registry.yarnpkg.com/@datadog/wasm-js-rewriter/-/wasm-js-rewriter-5.0.1.tgz#f227d2e3eb0f83b8a37f190a9ff8fdbde5955782"
integrity sha512-EzbV3Lrdt3udQEsbDOVC5gB1y7yxfpBbrSIk4jaEsGjyj0Dbv2HGj7tZjs+qXzIzNonHc8h5El2bYZOGfC2wwg==
"@datadog/wasm-js-rewriter@5.0.2":
version "5.0.2"
resolved "https://registry.yarnpkg.com/@datadog/wasm-js-rewriter/-/wasm-js-rewriter-5.0.2.tgz#f7cb491d02a0ce54429ca732f3dba5436b5e9271"
integrity sha512-ffv9TqdtuE8XnZgaGnmMIU1A+t+eaHIEbdVpV5elijq1dKK03OqFb+Xo4ojTbgCwxIYDA1zmA8TnZJBjtzuVuw==
dependencies:
js-yaml "^4.1.0"
js-yaml "^4.1.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin the rewriter to a js-yaml patched range

This still depends on js-yaml through ^4.1.1, and the checked-in lockfile continues to resolve the combined js-yaml@^4.1.0, js-yaml@^4.1.1 entry to 4.1.1. GHSA-5p4m-2wfm-xmqj marks >=4.0.0 <4.3.1 as affected and 4.3.1 as patched, so repo installs and lockfile-based consumers remain vulnerable even after this bump; please use a rewriter release/override that requires js-yaml >=4.3.1 <5 and update the lockfile accordingly.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exclude vulnerable js-yaml from the published range

Fresh evidence after the added resolution: this new 5.0.2 lock entry still advertises js-yaml "^4.1.1", which can satisfy 4.1.1 or 4.3.0 even though GHSA-5p4m-2wfm-xmqj lists >=4.0.0 <4.3.1 as affected. For downstream npm installs of the published dd-trace package, the repo-level resolutions entry is not applied—npm documents that overrides are “only considered in the root package.json” and published packages should pin dependencies or use shrinkwrap—so existing consumer lockfiles can keep a vulnerable js-yaml; please publish/use a rewriter whose own dependency range excludes <4.3.1.

Useful? React with 👍 / 👎.

lru-cache "^7.14.0"
module-details-from-path "^1.0.3"
node-gyp-build "^4.5.0"
Expand Down Expand Up @@ -2854,10 +2854,10 @@ js-yaml@^3.13.1:
argparse "^1.0.7"
esprima "^4.0.0"

js-yaml@^4.1.0, js-yaml@^4.1.1:
version "4.1.1"
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-4.1.1.tgz#854c292467705b699476e1a2decc0c8a3458806b"
integrity sha512-qQKT4zQxXl8lLwBtHMWwaTcGfFOZviOJet3Oy/xmGk2gZH677CJM9EvtfdSkgWcATZhj/55JZ0rmy3myCT5lsA==
js-yaml@^4.1.0, js-yaml@^4.1.1, js-yaml@^4.3.1:
version "4.3.1"
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-4.3.1.tgz#01216c001d67f48e2cd560d708c7af21090a3848"
integrity sha512-CY6crGq313MX8GkwvB7tzgp99vjQxY1++5y10/BKN/GUfHqWaOGQMNZkBvqSzsZKWk/ijwHlWzzkLulsGHhjWQ==
dependencies:
argparse "^2.0.1"

Expand Down
Loading