Skip to content

ci(instrumentations): use supported Confluent Node versions - #9771

Open
BridgeAR wants to merge 2 commits into
masterfrom
BridgeAR/2026-08-11-confluent-node-support
Open

ci(instrumentations): use supported Confluent Node versions#9771
BridgeAR wants to merge 2 commits into
masterfrom
BridgeAR/2026-08-11-confluent-node-support

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

What does this PR do?

Run Confluent instrumentation on Node 18, 20, and 22 for all supported package versions, and Node 24 for >=1.4.0.

Motivation

@confluentinc/kafka-javascript has no ABI 147 prebuild. Its source fallback fails under Node 26 because the librdkafka configuration header is not generated.

Additional Notes

Node 26 should be added after the Kafka-backed plugin suite can install, load, and connect there.

@confluentinc/kafka-javascript does not ship an ABI 147 prebuild, and its bundled librdkafka source fallback cannot build on Node 26.
@dd-octo-sts

dd-octo-sts Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8.2 MB
Deduped: 8.86 MB
No deduping: 8.86 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 441.72 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter

pr-commenter Bot commented Aug 11, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-14 20:26:11

Comparing candidate commit 921cb06 in PR branch BridgeAR/2026-08-11-confluent-node-support with baseline commit 77cd463 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2320 metrics, 38 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-206.313ms; +220.180ms] or [-7.608%; +8.119%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-191.267ms; +237.452ms] or [-7.494%; +9.303%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-161335.230µs; +159891.463µs] or [-5.164%; +5.118%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-185616.939µs; +184197.972µs] or [-6.325%; +6.276%]

scenario:appsec-control-20

  • unstable execution_time [-120.119ms; +123.853ms] or [-7.257%; +7.483%]

scenario:appsec-control-24

  • unstable execution_time [-116.836ms; +119.132ms] or [-9.270%; +9.453%]

scenario:appsec-control-26

  • unstable execution_time [-122.094ms; +127.107ms] or [-9.766%; +10.167%]

scenario:appsec-iast-no-vulnerability-control-20

  • unstable execution_time [-17.539ms; +14.971ms] or [-6.967%; +5.947%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-20821.162µs; +19208.679µs] or [-8.061%; +7.437%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-12.264ms; +18.717ms] or [-4.775%; +7.288%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-28.145ms; +32.565ms] or [-5.076%; +5.873%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-1578.648ms; +3459.393ms] or [-18.486%; +40.510%]
  • unstable execution_time [-1670.405ms; +3538.034ms] or [-18.085%; +38.304%]
  • unstable instructions [-13.6G instructions; +29.5G instructions] or [-19.548%; +42.261%]
  • unstable max_rss_usage [-7.776MB; +12.243MB] or [-4.911%; +7.731%]
  • unstable throughput [-1016.543op/s; +447.438op/s] or [-28.318%; +12.464%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-2891.497ms; +4254.219ms] or [-30.055%; +44.220%]
  • unstable execution_time [-3033.104ms; +4474.577ms] or [-29.323%; +43.259%]
  • unstable instructions [-25.0G instructions; +37.4G instructions] or [-31.096%; +46.485%]
  • unstable max_rss_usage [-8.918MB; +13.739MB] or [-5.577%; +8.592%]
  • unstable throughput [-841.444op/s; +565.080op/s] or [-26.026%; +17.478%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-3578.658ms; +2212.983ms] or [-37.758%; +23.349%]
  • unstable execution_time [-3599.736ms; +2236.188ms] or [-35.326%; +21.945%]
  • unstable instructions [-30.8G instructions; +19.4G instructions] or [-39.502%; +24.932%]
  • unstable max_rss_usage [-14.017MB; +8.870MB] or [-8.594%; +5.438%]
  • unstable throughput [-593.238op/s; +1013.077op/s] or [-17.776%; +30.356%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-2301.161ms; +756.748ms] or [-24.061%; +7.913%]
  • unstable execution_time [-2323.852ms; +760.475ms] or [-22.629%; +7.405%]
  • unstable instructions [-20.6G instructions; +6.7G instructions] or [-25.802%; +8.418%]
  • unstable throughput [-151.625op/s; +455.063op/s] or [-4.694%; +14.088%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-352.404ms; +274.167ms] or [-7.292%; +5.673%]
  • unstable execution_time [-349.962ms; +268.047ms] or [-7.129%; +5.460%]
  • unstable throughput [-94405.636op/s; +123767.116op/s] or [-5.531%; +7.251%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-8772.655KB; +10417.798KB] or [-6.540%; +7.766%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable max_rss_usage [-32057.100KB; +33960.529KB] or [-16.985%; +17.994%]

scenario:plugin-mongodb-core-plain-find-26

  • unstable cpu_usage_percentage [-5.942%; +4.317%]
  • unstable execution_time [-98.882ms; +172.111ms] or [-4.748%; +8.264%]
  • unstable throughput [-269403.867op/s; +150240.230op/s] or [-6.784%; +3.783%]

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Aug 11, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 1 Pipeline job failed

All Green | all-green   View in Datadog   GitHub Actions

See error xcrun is not installed or can't be found, and coverage.py is also not installed or can't be found, leading to no gcov data being found.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 98.53% (-0.02%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 921cb06 | Docs | Datadog PR Page | Give us feedback!

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.53%. Comparing base (77cd463) to head (921cb06).
⚠️ Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9771      +/-   ##
==========================================
- Coverage   98.55%   98.53%   -0.03%     
==========================================
  Files         966      975       +9     
  Lines      139420   144148    +4728     
  Branches    12543    12892     +349     
==========================================
+ Hits       137407   142031    +4624     
- Misses       2013     2117     +104     
Flag Coverage Δ
aiguard 57.23% <ø> (+0.22%) ⬆️
aiguard-integration 55.49% <ø> (-0.39%) ⬇️
apm-bucket-0 ?
apm-bucket-1 ?
apm-bucket-2 ?
apm-bucket-3 ?
apm-capabilities-tracing 62.35% <ø> (+0.03%) ⬆️
apm-integrations-aerospike 55.52% <ø> (-0.78%) ⬇️
apm-integrations-aerospike-_integrat-1d185c06 57.63% <ø> (?)
apm-integrations-confluentinc-kafka--d0bf0045 60.63% <ø> (?)
apm-integrations-confluentinc-kafka-javascript ?
apm-integrations-couchbase 56.21% <ø> (-0.52%) ⬇️
apm-integrations-elasticsearch_integ-31b69669 62.82% <ø> (?)
apm-integrations-http 61.38% <ø> (-0.54%) ⬇️
apm-integrations-http2_integrations--9aea12f5 61.65% <ø> (?)
apm-integrations-kafkajs 61.15% <ø> (-0.59%) ⬇️
apm-integrations-next 58.89% <ø> (-0.54%) ⬇️
apm-integrations-prisma 58.33% <ø> (-0.20%) ⬇️
apm-integrations-restify_integration-b312dd16 59.27% <ø> (?)
appsec 71.52% <ø> (-0.60%) ⬇️
appsec-express_fastify_graphql 68.91% <ø> (-0.53%) ⬇️
appsec-integration 49.60% <ø> (-0.58%) ⬇️
appsec-kafka_ldapjs_lodash 62.88% <ø> (-0.54%) ⬇️
appsec-mongodb-core_mongoose_mysql 66.37% <ø> (-0.52%) ⬇️
appsec-next 56.24% <ø> (-0.44%) ⬇️
appsec-node-serialize_passport_postgres 65.78% <ø> (-0.52%) ⬇️
appsec-sourcing_stripe_template 64.21% <ø> (-0.52%) ⬇️
debugger 63.68% <ø> (-0.58%) ⬇️
instr-ai_instrumentation-anthropic-l-e862da55 51.24% <ø> (?)
instr-bluebird_instrumentation-body--02ae4b41 59.13% <ø> (?)
instr-confluentinc-kafka-javascript 50.68% <ø> (?)
instr-connect_instrumentation-cookie-0bbb44d9 52.69% <ø> (?)
instr-couchbase 50.22% <ø> (?)
instr-express-session_instrumentatio-02a5aaf4 58.26% <ø> (?)
instr-express_instrumentation-expres-59707961 53.04% <ø> (?)
instr-fs_instrumentation-generic-poo-0cf52117 49.70% <ø> (?)
instr-http_instrumentation-http-clie-6b557c9f 59.95% <ø> (?)
instr-knex_instrumentation-koa_instr-d01c2978 57.61% <ø> (?)
instr-mongoose_instrumentation-multe-04a7d100 58.59% <ø> (?)
instr-mysql2_instrumentation-nyc_ins-352ff3c4 56.95% <ø> (?)
instr-otel-sdk-trace_instrumentation-ac070883 60.38% <ø> (?)
instr-passport-local_instrumentation-837edef8 61.11% <ø> (?)
instr-promise-js_instrumentation-q_i-6ea3f5eb 51.24% <ø> (?)
instr-router_instrumentation-stripe_-6f86dc12 51.99% <ø> (?)
instr-when_instrumentation-zlib 51.20% <ø> (?)
instrumentations-bucket-0 ?
instrumentations-bucket-1 ?
instrumentations-bucket-10 ?
instrumentations-bucket-11 ?
instrumentations-bucket-12 ?
instrumentations-bucket-13 ?
instrumentations-bucket-14 ?
instrumentations-bucket-2 ?
instrumentations-bucket-3 ?
instrumentations-bucket-4 ?
instrumentations-bucket-5 ?
instrumentations-bucket-6 ?
instrumentations-bucket-7 ?
instrumentations-bucket-8 ?
instrumentations-bucket-9 ?
instrumentations-instrumentation-couchbase ?
instrumentations-integration-esbuild 33.87% <ø> (-0.37%) ⬇️
llmobs-ai_anthropic_bedrock 62.31% <ø> (-0.55%) ⬇️
llmobs-bucket-1 ?
llmobs-claude-agent-sdk_google-genai-da2c851e 60.84% <ø> (?)
llmobs-openai 61.25% <ø> (-0.52%) ⬇️
llmobs-openai-agents_vertex-ai 59.56% <ø> (-0.49%) ⬇️
llmobs-sdk 67.23% <ø> (+0.42%) ⬆️
master-coverage 98.53% <ø> (?)
openfeature 55.19% <ø> (-0.49%) ⬇️
openfeature-unit 52.84% <ø> (-0.42%) ⬇️
platform-core_esbuild_instrumentations-misc 40.85% <ø> (-0.43%) ⬇️
platform-integration 59.92% <ø> (-0.51%) ⬇️
platform-shimmer_unit-guardrails_webpack 38.49% <ø> (-0.45%) ⬇️
plugins-aws-durable-execution-sdk-js-2bc88c07 56.43% <ø> (?)
plugins-azure-event-hubs_azure-servi-50d5b0fc 53.55% <ø> (?)
plugins-bucket-0 ?
plugins-bucket-1 ?
plugins-bucket-11 ?
plugins-bucket-17 ?
plugins-bucket-18 ?
plugins-bucket-19 ?
plugins-bucket-20 ?
plugins-bucket-4 ?
plugins-bullmq_cassandra_cookie 60.84% <ø> (-0.56%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 55.86% <ø> (-0.52%) ⬇️
plugins-express-mongo-sanitize_expre-4f0480c2 57.81% <ø> (?)
plugins-fetch_fs_generic-pool 57.76% <ø> (-0.48%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 63.59% <ø> (-0.58%) ⬇️
plugins-hapi_hono_ioredis 59.38% <ø> (-0.54%) ⬇️
plugins-knex_langgraph_ldapjs 54.60% <ø> (-0.49%) ⬇️
plugins-light-my-request_limitd-client_lodash 57.85% <ø> (-0.54%) ⬇️
plugins-mariadb_memcached_mercurius 61.02% <ø> (-0.29%) ⬇️
plugins-microgateway-core_modelconte-ca2fdeba 60.93% <ø> (?)
plugins-mongodb_mongodb-core_mongoose 58.75% <ø> (-0.54%) ⬇️
plugins-multer_mysql_mysql2 58.34% <ø> (-0.54%) ⬇️
plugins-nats_node-serialize_opensearch 59.86% <ø> (-0.56%) ⬇️
plugins-passport-http_pino_postgres 58.08% <ø> (-0.53%) ⬇️
plugins-process_pug_redis 56.89% <ø> (-0.53%) ⬇️
plugins-router_sequelize_test-and-up-32bf768a 60.75% <ø> (?)
plugins-test-and-upstream-amqplib_te-47de9104 61.42% <ø> (?)
plugins-test-and-upstream-bunyan_tes-870c2d6f 60.78% <ø> (?)
plugins-test-and-upstream-koa_test-a-e7fc792b 63.15% <ø> (?)
plugins-undici_url_valkey 57.54% <ø> (-0.50%) ⬇️
plugins-vm_winston_ws 59.07% <ø> (-0.55%) ⬇️
profiling 61.16% <ø> (-0.37%) ⬇️
serverless-aws-sdk-aws-sdk 54.40% <ø> (-0.75%) ⬇️
serverless-aws-sdk-base-inject-field 50.47% <ø> (-0.50%) ⬇️
serverless-aws-sdk-bedrockruntime 54.19% <ø> (-0.50%) ⬇️
serverless-aws-sdk-client 55.71% <ø> (-0.54%) ⬇️
serverless-aws-sdk-dynamodb ?
serverless-aws-sdk-dynamodb_azure-du-4678d100 57.96% <ø> (?)
serverless-aws-sdk-eventbridge 56.49% <ø> (+6.73%) ⬆️
serverless-aws-sdk-kinesis 58.55% <ø> (-0.56%) ⬇️
serverless-aws-sdk-lambda 56.73% <ø> (-0.53%) ⬇️
serverless-aws-sdk-s3 55.11% <ø> (-0.51%) ⬇️
serverless-aws-sdk-serverless-peer-service 59.13% <ø> (-0.23%) ⬇️
serverless-aws-sdk-sns 59.34% <ø> (-0.57%) ⬇️
serverless-aws-sdk-sqs 59.78% <ø> (-0.55%) ⬇️
serverless-aws-sdk-stepfunctions 54.94% <ø> (-0.51%) ⬇️
serverless-aws-sdk-util 50.99% <ø> (-0.51%) ⬇️
serverless-azure-functions-cosmosdb_-45b4105e 52.81% <ø> (?)
serverless-bucket-0 ?
serverless-bucket-1 ?
serverless-lambda 55.23% <ø> (?)
test-optimization-cucumber 70.54% <ø> (-0.53%) ⬇️
test-optimization-cypress 64.76% <ø> (-0.03%) ⬇️
test-optimization-jest 71.99% <ø> (-0.46%) ⬇️
test-optimization-mocha 72.05% <ø> (-0.02%) ⬇️
test-optimization-playwright-playwri-363e40a6 59.39% <ø> (?)
test-optimization-playwright-playwri-5141d36d 60.86% <ø> (?)
test-optimization-playwright-playwri-5b35813b 59.83% <ø> (?)
test-optimization-playwright-playwri-924f4516 60.33% <ø> (?)
test-optimization-playwright-playwri-d6f5a99b 59.57% <ø> (?)
test-optimization-playwright-playwright-atr 59.52% <ø> (-0.39%) ⬇️
test-optimization-playwright-playwright-efd 59.68% <ø> (-0.36%) ⬇️
test-optimization-playwright-playwright-final-status ?
test-optimization-playwright-playwright-impacted-tests ?
test-optimization-playwright-playwright-reporting ?
test-optimization-playwright-playwright-test-management ?
test-optimization-playwright-playwright-test-span ?
test-optimization-selenium 58.77% <ø> (-0.47%) ⬇️
test-optimization-testopt 57.44% <ø> (-0.11%) ⬇️
test-optimization-vitest 72.70% <ø> (-0.60%) ⬇️
test-optimization-vitest-browser 58.62% <ø> (-0.30%) ⬇️
test-optimization-webdriverio 64.91% <ø> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR
BridgeAR marked this pull request as ready for review August 11, 2026 21:43
@BridgeAR
BridgeAR requested a review from a team as a code owner August 11, 2026 21:43
@BridgeAR
BridgeAR requested review from bojbrook and removed request for a team August 11, 2026 21:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed4f30c08c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- run: npm run test:instrumentations:ci
- uses: ./.github/actions/coverage
with:
flags: instrumentations-${{ github.job }}-${{ matrix.node-version }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Shorten the matrix coverage flag

Because this job now has four matrix cells, All Green will see multiple coverage artifacts for the same integration and scripts/group-coverage.mjs keeps multi-cell integrations under their full stripped flag instead of bucketing them. This flag becomes instrumentations-instrumentation-confluentinc-kafka-javascript after the node version is stripped, which is 62 characters; the grouping script documents Codecov's 45-character flag limit and that overlong flags are silently dropped (scripts/group-coverage.mjs lines 42-44, 122-124), so the new Confluent instrumentation coverage will not be uploaded to Codecov. Use a shorter per-cell flag such as one based on confluentinc-kafka-javascript without the duplicated instrumentation prefix.

Useful? React with 👍 / 👎.

Multi-cell integrations kept their full normalized name, so Codecov silently dropped flags longer than 45 characters.
@BridgeAR
BridgeAR requested a review from a team as a code owner August 14, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant