ci(instrumentations): use supported Confluent Node versions - #9771
ci(instrumentations): use supported Confluent Node versions#9771BridgeAR wants to merge 2 commits into
Conversation
@confluentinc/kafka-javascript does not ship an ABI 147 prebuild, and its bundled librdkafka source fallback cannot build on Node 26.
Overall package sizeSelf size: 8.2 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 441.72 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2026-08-14 20:26:11 Comparing candidate commit 921cb06 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2320 metrics, 38 unstable metrics.
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed4f30c08c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - run: npm run test:instrumentations:ci | ||
| - uses: ./.github/actions/coverage | ||
| with: | ||
| flags: instrumentations-${{ github.job }}-${{ matrix.node-version }} |
There was a problem hiding this comment.
Shorten the matrix coverage flag
Because this job now has four matrix cells, All Green will see multiple coverage artifacts for the same integration and scripts/group-coverage.mjs keeps multi-cell integrations under their full stripped flag instead of bucketing them. This flag becomes instrumentations-instrumentation-confluentinc-kafka-javascript after the node version is stripped, which is 62 characters; the grouping script documents Codecov's 45-character flag limit and that overlong flags are silently dropped (scripts/group-coverage.mjs lines 42-44, 122-124), so the new Confluent instrumentation coverage will not be uploaded to Codecov. Use a shorter per-cell flag such as one based on confluentinc-kafka-javascript without the duplicated instrumentation prefix.
Useful? React with 👍 / 👎.
Multi-cell integrations kept their full normalized name, so Codecov silently dropped flags longer than 45 characters.
What does this PR do?
Run Confluent instrumentation on Node 18, 20, and 22 for all supported package versions, and Node 24 for
>=1.4.0.Motivation
@confluentinc/kafka-javascripthas no ABI 147 prebuild. Its source fallback fails under Node 26 because the librdkafka configuration header is not generated.Additional Notes
Node 26 should be added after the Kafka-backed plugin suite can install, load, and connect there.