-
Notifications
You must be signed in to change notification settings - Fork 164
[WIP] feat: add http status error configuration #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] feat: add http status error configuration #3223
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3223 +/- ##
============================================
- Coverage 76.38% 67.38% -9.00%
+ Complexity 2948 715 -2233
============================================
Files 145 68 -77
Lines 16076 6148 -9928
Branches 1107 1107
============================================
- Hits 12280 4143 -8137
+ Misses 3221 1430 -1791
Partials 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. see 87 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
PR Security UpdateAll commits in this PR up to and including 69f19db have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack. |
Thanks for the contribution! I've littered the code with suggestions, but it already looks quite good :-) |
Thanks so much for the review and suggestions! |
Thanks, the code looks fine now - we can have a look at the tests. |
Anything I can do on my end? I've tried to build run the tests in the container, but I've been having trouble with getting it started with docker compose. I've only been able to run the 8.3-buster container and run the tests manually. |
Description
This PR adds a set of configuration items for custom error flagging based on http status codes. This will allow users of the library to prevent tagging errors for things like a 4xx status code on a server, for example.
This would bring the library closer to the java tracer and some functionalities of the python and c# tracers.
The priority when evaluating spans is:
Reviewer checklist