Skip to content

Fix initial double remote config reading #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Apr 28, 2025

This also prevents an use-after-free given that only ddtrace_rinit_remote_config will initialize DDTRACE_G(active_rc_hooks).

This use-after-free only manifests sometimes on consecutive requests where both requests end up using live-debugger resources.

@bwoebi bwoebi requested review from a team as code owners April 28, 2025 18:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.38%. Comparing base (aeeec62) to head (b8c57b1).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3225   +/-   ##
=========================================
  Coverage     76.38%   76.38%           
  Complexity     2948     2948           
=========================================
  Files           145      145           
  Lines         16076    16076           
  Branches       1107     1107           
=========================================
  Hits          12280    12280           
  Misses         3221     3221           
  Partials        575      575           
Flag Coverage Δ
appsec-extension 68.80% <ø> (ø)
tracer-php 79.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeeec62...b8c57b1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Apr 28, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-04-28 18:30:45

Comparing candidate commit 71ba6fe in PR branch bob/fix-rc-use-after-free with baseline commit aeeec62 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being honest, I don't know what's going on here, but it's supposed to fix a bug, so I'll trust you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants