-
Notifications
You must be signed in to change notification settings - Fork 164
Fix initial double remote config reading #3225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Bob Weinand <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3225 +/- ##
=========================================
Coverage 76.38% 76.38%
Complexity 2948 2948
=========================================
Files 145 145
Lines 16076 16076
Branches 1107 1107
=========================================
Hits 12280 12280
Misses 3221 3221
Partials 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-04-28 18:30:45 Comparing candidate commit 71ba6fe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being honest, I don't know what's going on here, but it's supposed to fix a bug, so I'll trust you.
Signed-off-by: Bob Weinand <[email protected]>
Signed-off-by: Bob Weinand <[email protected]>
This also prevents an use-after-free given that only ddtrace_rinit_remote_config will initialize
DDTRACE_G(active_rc_hooks)
.This use-after-free only manifests sometimes on consecutive requests where both requests end up using live-debugger resources.