-
Notifications
You must be signed in to change notification settings - Fork 167
Print block_id #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Print block_id #3444
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3444 +/- ##
==========================================
+ Coverage 61.89% 62.04% +0.14%
==========================================
Files 141 141
Lines 12501 12624 +123
Branches 1633 1651 +18
==========================================
+ Hits 7737 7832 +95
- Misses 4042 4065 +23
- Partials 722 727 +5
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ appsec ]Benchmark execution time: 2025-10-15 14:58:51 Comparing candidate commit d7e9379 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
252d896
to
b861a80
Compare
b861a80
to
fc35f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think adding 8 new tests is excessive, especially because the old tests already were changed to cover the new functionality. Maybe leave only the new tests with custom templates -- and add the placeholder more than once.
@cataphract thanks for the review. I have addressed all comments. |
ab7f27b
to
3787fd4
Compare
"p{font-size:16px}</style></head><body><main><p>Sorry, you cannot access " | ||
"this page. Please contact the customer service " | ||
"team.</p></main><footer><p>Security provided by <a " | ||
"team.</br> Block ID: {block_id}</p></main><footer><p>Security provided by " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This template hasn't been standardised, AFAIK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. But when it gets done, all I will have to do is to change this
fc4552d
to
868eadc
Compare
868eadc
to
d7e9379
Compare
Description
Display the new
block_id
provided by the latest libddwaf version. This block id is provided on blocks and redirects. It is displayed to the user on html, json and redirections.The placeholder for block id on the template is
{block_id}
. There can be multiple placeholders in the same templateAdditionally, messaging around requests blocked/redirected has been reworded as some customer found them confusing.
Reviewer checklist