Skip to content

fix(ci_visibility): do not use is_user_code [backport 3.14] #14809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.14
Choose a base branch
from
+7 −4
Open

fix(ci_visibility): do not use is_user_code [backport 3.14] #14809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ddtrace/internal/coverage/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from ddtrace.internal.coverage.util import collapse_ranges
from ddtrace.internal.logger import get_logger
from ddtrace.internal.module import ModuleWatchdog
from ddtrace.internal.packages import is_user_code
from ddtrace.internal.packages import platlib_path
from ddtrace.internal.packages import platstdlib_path
from ddtrace.internal.packages import purelib_path
Expand Down Expand Up @@ -327,9 +326,6 @@ def transform(self, code: CodeType, _module: ModuleType) -> CodeType:
# Don't instrument code from standard library/site packages/etc.
return code

if not is_user_code(code_path):
return code

retval = self.instrument_code(code, _module.__package__ if _module is not None else "")

if self._collect_import_coverage:
Expand Down
7 changes: 7 additions & 0 deletions releasenotes/notes/ci_visibility-fix-itr-user-code-61c09671abe6df17.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- |
CI Visibility: This fix resolves an issue where tests would be incorrectly detected as third-party code if a
third-party package containing a folder with the same name as the tests folder was installed. For instance, the
``sumy`` package installs files under ``tests/*`` in ``site-packages``, and this would cause any modules under
``tests.*`` to be considered third-party.
Loading