-
Notifications
You must be signed in to change notification settings - Fork 461
ci: remove unnused action secrets from system-tests [backport 3.16] #14839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.16
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 255 ± 4 ms. The average import time from base is: 257 ± 4 ms. The import time difference between this PR and base is: -1.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
## Description These aren't needed or used anymore, so we can stop providing them. ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers --> (cherry picked from commit b6d846e)
23d1911
to
9a6bcf9
Compare
Performance SLOsComparing candidate backport-14834-to-3.16 (9a6bcf9) with baseline 3.16 (35c3c11) ❌ Test Failures (1 suite)❌ span - 25/26✅ add-eventTime: ✅ 20.708ms (SLO: <22.500ms -8.0%) vs baseline: -0.2% Memory: ✅ 50.347MB (SLO: <53.000MB -5.0%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 91.020ms (SLO: <93.500ms -2.7%) vs baseline: +0.4% Memory: ✅ 661.213MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 149.046ms (SLO: <155.000ms -3.8%) vs baseline: +0.4% Memory: ✅ 661.655MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.8% ✅ get-contextTime: ✅ 19.383ms (SLO: <20.500ms -5.4%) vs baseline: +0.2% Memory: ✅ 49.147MB (SLO: <53.000MB -7.3%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 19.601ms (SLO: <20.500ms -4.4%) vs baseline: -0.4% Memory: ✅ 49.096MB (SLO: <53.000MB -7.4%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 38.298ms (SLO: <40.000ms -4.3%) vs baseline: ~same Memory: ✅ 42.713MB (SLO: <53.000MB 📉 -19.4%) vs baseline: +4.8% ✅ set-statusTime: ✅ 21.270ms (SLO: <22.000ms -3.3%) vs baseline: ~same Memory: ✅ 49.020MB (SLO: <53.000MB -7.5%) vs baseline: +4.7% ✅ startTime: ✅ 19.311ms (SLO: <20.500ms -5.8%) vs baseline: +0.4% Memory: ✅ 49.098MB (SLO: <53.000MB -7.4%) vs baseline: +4.6% ✅ start-finishTime: ✅ 51.559ms (SLO: <52.500ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 32.047MB (SLO: <34.000MB -5.7%) vs baseline: +4.5% ✅ start-finish-telemetryTime: ✅ 52.774ms (SLO: <54.500ms -3.2%) vs baseline: +0.4% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ❌ start-finish-traceid128Time: ❌ 55.362ms (SLO: <55.000ms +0.7%) vs baseline: +1.4% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 19.723ms (SLO: <22.500ms 📉 -12.3%) vs baseline: +0.1% Memory: ✅ 48.956MB (SLO: <53.000MB -7.6%) vs baseline: +4.8% ✅ update-nameTime: ✅ 20.310ms (SLO: <22.000ms -7.7%) vs baseline: +1.2% Memory: ✅ 49.719MB (SLO: <53.000MB -6.2%) vs baseline: +4.7% 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.495µs (SLO: <20.000µs 📉 -82.5%) vs baseline: 📈 +10.6% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 211.401µs (SLO: <250.000µs 📉 -15.4%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 2.981µs (SLO: <20.000µs 📉 -85.1%) vs baseline: +0.4% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 191.671µs (SLO: <220.000µs 📉 -12.9%) vs baseline: -0.7% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.109µs (SLO: <20.000µs 📉 -89.5%) vs baseline: -0.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.5% ✅ 1-gauge-metrics-100-timesTime: ✅ 124.637µs (SLO: <150.000µs 📉 -16.9%) vs baseline: -0.7% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.262µs (SLO: <20.000µs 📉 -83.7%) vs baseline: +3.6% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 211.575µs (SLO: <250.000µs 📉 -15.4%) vs baseline: -1.0% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 100-count-metrics-100-timesTime: ✅ 21.876ms (SLO: <23.500ms -6.9%) vs baseline: +1.2% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 1.991ms (SLO: <2.250ms 📉 -11.5%) vs baseline: ~same Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.293ms (SLO: <1.550ms 📉 -16.6%) vs baseline: ~same Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.202ms (SLO: <2.550ms 📉 -13.7%) vs baseline: -0.3% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.201µs (SLO: <20.000µs 📉 -79.0%) vs baseline: -0.3% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 181.494µs (SLO: <250.000µs 📉 -27.4%) vs baseline: -0.1% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.220ms (SLO: <2.500ms 📉 -11.2%) vs baseline: +1.4% Memory: ✅ 32.893MB (SLO: <34.500MB -4.7%) vs baseline: +4.7% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.490ms (SLO: <22.300ms -8.1%) vs baseline: +0.2% Memory: ✅ 65.411MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.4% Memory: ✅ 64.445MB (SLO: <67.000MB -3.8%) vs baseline: +4.7% ✅ iastTime: ✅ 20.433ms (SLO: <22.250ms -8.2%) vs baseline: ~same Memory: ✅ 65.426MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.216ms (SLO: <16.550ms -8.1%) vs baseline: ~same Memory: ✅ 53.713MB (SLO: <54.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 20.529ms (SLO: <21.750ms -5.6%) vs baseline: ~same Memory: ✅ 65.503MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 26.182ms (SLO: <28.200ms -7.2%) vs baseline: -0.1% Memory: ✅ 67.508MB (SLO: <69.500MB -2.9%) vs baseline: +3.1% ✅ tracerTime: ✅ 20.489ms (SLO: <21.750ms -5.8%) vs baseline: +0.1% Memory: ✅ 65.352MB (SLO: <67.000MB -2.5%) vs baseline: +4.6% ✅ tracer-and-profilerTime: ✅ 22.066ms (SLO: <23.500ms -6.1%) vs baseline: +0.3% Memory: ✅ 66.683MB (SLO: <67.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.371ms (SLO: <21.500ms -9.9%) vs baseline: +0.1% Memory: ✅ 65.517MB (SLO: <66.000MB 🟡 -0.7%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.668ms (SLO: <17.500ms -4.8%) vs baseline: +0.3% Memory: ✅ 65.376MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.524ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 71.502MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-no-cachesTime: ✅ 18.479ms (SLO: <19.650ms -6.0%) vs baseline: ~same Memory: ✅ 65.410MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.809ms (SLO: <20.100ms -6.4%) vs baseline: +0.4% Memory: ✅ 65.434MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.163ms (SLO: <21.500ms -6.2%) vs baseline: ~same Memory: ✅ 65.433MB (SLO: <67.000MB -2.3%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 20.427ms (SLO: <22.000ms -7.1%) vs baseline: +0.7% Memory: ✅ 65.513MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.061ms (SLO: <19.850ms -9.0%) vs baseline: -0.1% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.411ms (SLO: <19.400ms -5.1%) vs baseline: +1.9% Memory: ✅ 65.352MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.098ms (SLO: <19.450ms -7.0%) vs baseline: ~same Memory: ✅ 65.352MB (SLO: <66.500MB 🟡 -1.7%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.571ms (SLO: <4.750ms -3.8%) vs baseline: +0.2% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.558ms (SLO: <6.750ms -2.8%) vs baseline: +0.3% Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.569ms (SLO: <4.750ms -3.8%) vs baseline: -0.1% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.874ms (SLO: <2.000ms -6.3%) vs baseline: +0.9% Memory: ✅ 45.357MB (SLO: <47.000MB -3.5%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.864ms (SLO: <2.000ms -6.8%) vs baseline: +0.3% Memory: ✅ 42.330MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.908ms (SLO: <2.100ms -9.2%) vs baseline: -0.1% Memory: ✅ 46.419MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.379ms (SLO: <3.650ms -7.4%) vs baseline: -0.3% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: +0.4% Memory: ✅ 52.219MB (SLO: <53.500MB -2.4%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 58.297MB (SLO: <60.000MB -2.8%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.717ms (SLO: <47.150ms -9.4%) vs baseline: +0.2% Memory: ✅ 44.504MB (SLO: <47.000MB -5.3%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 317.488ms (SLO: <344.800ms -7.9%) vs baseline: -0.4% Memory: ✅ 595.546MB (SLO: <600.000MB 🟡 -0.7%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 287.403ms (SLO: <314.000ms -8.5%) vs baseline: +0.6% Memory: ✅ 596.976MB (SLO: <600.000MB 🟡 -0.5%) vs baseline: +4.9% ✅ get-contextTime: ✅ 80.298ms (SLO: <92.350ms 📉 -13.1%) vs baseline: +0.3% Memory: ✅ 39.994MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 39.016ms (SLO: <44.500ms 📉 -12.3%) vs baseline: +0.3% Memory: ✅ 43.990MB (SLO: <47.500MB -7.4%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 59.912ms (SLO: <67.650ms 📉 -11.4%) vs baseline: +1.6% Memory: ✅ 40.288MB (SLO: <47.000MB 📉 -14.3%) vs baseline: +4.8% ✅ set-statusTime: ✅ 45.328ms (SLO: <50.400ms 📉 -10.1%) vs baseline: +1.4% Memory: ✅ 43.990MB (SLO: <47.000MB -6.4%) vs baseline: +4.8% ✅ startTime: ✅ 37.985ms (SLO: <43.450ms 📉 -12.6%) vs baseline: -0.5% Memory: ✅ 44.004MB (SLO: <47.000MB -6.4%) vs baseline: +4.8% ✅ start-finishTime: ✅ 82.876ms (SLO: <88.000ms -5.8%) vs baseline: -0.1% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 83.941ms (SLO: <89.000ms -5.7%) vs baseline: -0.5% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 40.213ms (SLO: <45.150ms 📉 -10.9%) vs baseline: +0.2% Memory: ✅ 44.265MB (SLO: <47.000MB -5.8%) vs baseline: +4.8%
|
Backport b6d846e from #14834 to 3.16.
Description
These aren't needed or used anymore, so we can stop providing them.
Testing
Risks
Additional Notes