-
Notifications
You must be signed in to change notification settings - Fork 461
chore(profiling): add type annotations to test_threading.py
#14845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: vlad/lock-profiler-add-rlock
Are you sure you want to change the base?
chore(profiling): add type annotations to test_threading.py
#14845
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 2 ms. The average import time from base is: 239 ± 2 ms. The import time difference between this PR and base is: -1.64 ± 0.08 ms. Import time breakdownThe following import paths have shrunk:
|
test_threading.py
900bfd8
to
e2d136e
Compare
Performance SLOsComparing candidate vlad/type_annotations_test_threading (333a584) with baseline vlad/lock-profiler-add-rlock (39c0f31) ❌ Test Failures (1 suite)❌ span - 25/26✅ add-eventTime: ✅ 20.523ms (SLO: <22.500ms -8.8%) vs baseline: +0.5% Memory: ✅ 50.450MB (SLO: <53.000MB -4.8%) vs baseline: +5.1% ✅ add-metricsTime: ✅ 90.513ms (SLO: <93.500ms -3.2%) vs baseline: -0.5% Memory: ✅ 661.082MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 148.208ms (SLO: <155.000ms -4.4%) vs baseline: +0.4% Memory: ✅ 661.937MB (SLO: <962.500MB 📉 -31.2%) vs baseline: +5.0% ✅ get-contextTime: ✅ 19.260ms (SLO: <20.500ms -6.0%) vs baseline: -0.6% Memory: ✅ 49.155MB (SLO: <53.000MB -7.3%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 20.011ms (SLO: <20.500ms -2.4%) vs baseline: +2.4% Memory: ✅ 49.181MB (SLO: <53.000MB -7.2%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 39.029ms (SLO: <40.000ms -2.4%) vs baseline: +1.9% Memory: ✅ 42.689MB (SLO: <53.000MB 📉 -19.5%) vs baseline: +4.7% ✅ set-statusTime: ✅ 21.308ms (SLO: <22.000ms -3.1%) vs baseline: +0.1% Memory: ✅ 49.096MB (SLO: <53.000MB -7.4%) vs baseline: +4.6% ✅ startTime: ✅ 19.068ms (SLO: <20.500ms -7.0%) vs baseline: +0.1% Memory: ✅ 49.230MB (SLO: <53.000MB -7.1%) vs baseline: +5.0% ✅ start-finishTime: ✅ 51.825ms (SLO: <52.500ms 🟡 -1.3%) vs baseline: +0.8% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 52.823ms (SLO: <54.500ms -3.1%) vs baseline: ~same Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.7% ❌ start-finish-traceid128Time: ❌ 56.137ms (SLO: <56.000ms +0.2%) vs baseline: +2.2% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ start-traceid128Time: ✅ 19.516ms (SLO: <22.500ms 📉 -13.3%) vs baseline: -0.2% Memory: ✅ 49.157MB (SLO: <53.000MB -7.3%) vs baseline: +4.9% ✅ update-nameTime: ✅ 20.425ms (SLO: <22.000ms -7.2%) vs baseline: +1.5% Memory: ✅ 49.771MB (SLO: <53.000MB -6.1%) vs baseline: +4.8% 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.288µs (SLO: <10.000µs 📉 -57.1%) vs baseline: +0.4% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.5% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.100µs (SLO: <10.000µs 📉 -39.0%) vs baseline: -0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.284µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -1.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.484µs (SLO: <10.000µs 📉 -65.2%) vs baseline: +0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.881µs (SLO: <10.000µs 📉 -51.2%) vs baseline: -0.8% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.595µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.8% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 4.012µs (SLO: <10.000µs 📉 -59.9%) vs baseline: +9.8% Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.4% ✅ ospathsplitdrive_noaspectTime: ✅ 0.702µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 5.251µs (SLO: <10.000µs 📉 -47.5%) vs baseline: 📈 +15.2% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.387µs (SLO: <10.000µs 📉 -86.1%) vs baseline: ~same Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.368ms (SLO: <22.300ms -8.7%) vs baseline: -0.7% Memory: ✅ 65.453MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.345ms (SLO: <1.450ms -7.3%) vs baseline: -0.3% Memory: ✅ 64.576MB (SLO: <67.000MB -3.6%) vs baseline: +4.8% ✅ iastTime: ✅ 20.480ms (SLO: <22.250ms -8.0%) vs baseline: -0.1% Memory: ✅ 65.397MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.507ms (SLO: <16.550ms -6.3%) vs baseline: ~same Memory: ✅ 54.027MB (SLO: <54.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.490ms (SLO: <21.750ms -5.8%) vs baseline: -0.5% Memory: ✅ 65.476MB (SLO: <67.000MB -2.3%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 26.167ms (SLO: <28.200ms -7.2%) vs baseline: ~same Memory: ✅ 67.659MB (SLO: <69.500MB -2.6%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.443ms (SLO: <21.750ms -6.0%) vs baseline: -0.1% Memory: ✅ 65.402MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.611ms (SLO: <23.500ms -3.8%) vs baseline: -0.2% Memory: ✅ 66.950MB (SLO: <67.500MB 🟡 -0.8%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.299ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.5% Memory: ✅ 65.480MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.575ms (SLO: <17.500ms -5.3%) vs baseline: -0.8% Memory: ✅ 65.474MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.495ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 71.343MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.426ms (SLO: <19.650ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.447MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.788ms (SLO: <20.100ms -6.5%) vs baseline: -0.4% Memory: ✅ 65.189MB (SLO: <67.000MB -2.7%) vs baseline: +4.6% ✅ tracer-no-middlewareTime: ✅ 20.190ms (SLO: <21.500ms -6.1%) vs baseline: +0.1% Memory: ✅ 65.478MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.315ms (SLO: <22.000ms -7.7%) vs baseline: ~same Memory: ✅ 65.507MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.027ms (SLO: <19.850ms -9.2%) vs baseline: -0.3% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.046ms (SLO: <19.400ms -7.0%) vs baseline: ~same Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.104ms (SLO: <19.450ms -6.9%) vs baseline: ~same Memory: ✅ 65.136MB (SLO: <66.500MB -2.1%) vs baseline: +4.6% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.572ms (SLO: <4.750ms -3.8%) vs baseline: ~same Memory: ✅ 61.892MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.550ms (SLO: <6.750ms -3.0%) vs baseline: ~same Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.575ms (SLO: <4.750ms -3.7%) vs baseline: ~same Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.2% Memory: ✅ 45.456MB (SLO: <47.000MB -3.3%) vs baseline: +4.5% ✅ iast-getTime: ✅ 1.863ms (SLO: <2.000ms -6.8%) vs baseline: +0.2% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.916ms (SLO: <2.100ms -8.7%) vs baseline: +0.4% Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.5% ✅ resource-renamingTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: -0.2% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: +0.4% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: -0.2% Memory: ✅ 58.406MB (SLO: <60.000MB -2.7%) vs baseline: +5.0% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.547ms (SLO: <47.150ms -9.8%) vs baseline: +0.3% Memory: ✅ 44.459MB (SLO: <47.000MB -5.4%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 318.243ms (SLO: <344.800ms -7.7%) vs baseline: +0.5% Memory: ✅ 595.329MB (SLO: <600.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 286.692ms (SLO: <314.000ms -8.7%) vs baseline: ~same Memory: ✅ 596.427MB (SLO: <600.000MB 🟡 -0.6%) vs baseline: +4.8% ✅ get-contextTime: ✅ 82.692ms (SLO: <92.350ms 📉 -10.5%) vs baseline: +2.8% Memory: ✅ 39.981MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +5.2% ✅ is-recordingTime: ✅ 39.107ms (SLO: <44.500ms 📉 -12.1%) vs baseline: +0.6% Memory: ✅ 44.006MB (SLO: <47.500MB -7.4%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 59.956ms (SLO: <67.650ms 📉 -11.4%) vs baseline: +1.8% Memory: ✅ 40.192MB (SLO: <47.000MB 📉 -14.5%) vs baseline: +4.7% ✅ set-statusTime: ✅ 44.729ms (SLO: <50.400ms 📉 -11.3%) vs baseline: -0.1% Memory: ✅ 43.951MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% ✅ startTime: ✅ 38.289ms (SLO: <43.450ms 📉 -11.9%) vs baseline: +0.2% Memory: ✅ 43.969MB (SLO: <47.000MB -6.4%) vs baseline: +5.0% ✅ start-finishTime: ✅ 82.626ms (SLO: <88.000ms -6.1%) vs baseline: +0.4% Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 84.036ms (SLO: <89.000ms -5.6%) vs baseline: +0.2% Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 40.851ms (SLO: <45.150ms -9.5%) vs baseline: +1.1% Memory: ✅ 44.247MB (SLO: <47.000MB -5.9%) vs baseline: +5.0%
|
ffcf769
to
76a6c28
Compare
3f50634
to
7e7549f
Compare
…lector tests fail
…belong with threading)
7e7549f
to
5e35980
Compare
76a6c28
to
683b95c
Compare
435e9ec
to
5faff64
Compare
683b95c
to
f820ad3
Compare
f820ad3
to
1ade860
Compare
PROF-12734
Description
Testing
Risks
none