-
Notifications
You must be signed in to change notification settings - Fork 461
feat(aap): support for custom scanners #14850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 241 ± 2 ms. The average import time from base is: 243 ± 2 ms. The import time difference between this PR and base is: -1.97 ± 0.08 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/custom_scanners (8b2d3c5) with baseline main (493f80c) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.522ms (SLO: <22.300ms -8.0%) vs baseline: ~same Memory: ✅ 65.476MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.347ms (SLO: <1.450ms -7.1%) vs baseline: +0.7% Memory: ✅ 64.567MB (SLO: <67.000MB -3.6%) vs baseline: +4.9% ✅ iastTime: ✅ 20.437ms (SLO: <22.250ms -8.1%) vs baseline: -0.1% Memory: ✅ 65.525MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.305ms (SLO: <16.550ms -7.5%) vs baseline: +0.2% Memory: ✅ 53.708MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 20.513ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 65.491MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.225ms (SLO: <28.200ms -7.0%) vs baseline: ~same Memory: ✅ 67.671MB (SLO: <69.500MB -2.6%) vs baseline: +5.0% ✅ tracerTime: ✅ 20.475ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 65.436MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.060ms (SLO: <23.500ms -6.1%) vs baseline: -0.1% Memory: ✅ 66.708MB (SLO: <67.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.312ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.4% Memory: ✅ 65.459MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.602ms (SLO: <17.500ms -5.1%) vs baseline: -0.4% Memory: ✅ 65.461MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.469ms (SLO: <21.750ms -5.9%) vs baseline: -0.4% Memory: ✅ 71.408MB (SLO: <72.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.470ms (SLO: <19.650ms -6.0%) vs baseline: +0.4% Memory: ✅ 65.466MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.756ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 65.377MB (SLO: <67.000MB -2.4%) vs baseline: +5.1% ✅ tracer-no-middlewareTime: ✅ 20.215ms (SLO: <21.500ms -6.0%) vs baseline: +0.4% Memory: ✅ 65.493MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.304ms (SLO: <22.000ms -7.7%) vs baseline: -0.2% Memory: ✅ 65.450MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.001ms (SLO: <19.850ms -9.3%) vs baseline: -0.4% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 18.016ms (SLO: <19.400ms -7.1%) vs baseline: -0.3% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.106ms (SLO: <19.450ms -6.9%) vs baseline: -0.1% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.571ms (SLO: <4.750ms -3.8%) vs baseline: ~same Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.589ms (SLO: <6.750ms -2.4%) vs baseline: +0.2% Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +4.6% ✅ appsec-telemetryTime: ✅ 4.572ms (SLO: <4.750ms -3.7%) vs baseline: -0.4% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.2% Memory: ✅ 45.534MB (SLO: <47.000MB -3.1%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: +0.1% Memory: ✅ 42.349MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.916ms (SLO: <2.100ms -8.8%) vs baseline: +0.2% Memory: ✅ 46.439MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: -0.3% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.372ms (SLO: <3.650ms -7.6%) vs baseline: -0.1% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.374ms (SLO: <3.650ms -7.6%) vs baseline: ~same Memory: ✅ 58.256MB (SLO: <60.000MB -2.9%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.528ms (SLO: <47.150ms -9.8%) vs baseline: +0.4% Memory: ✅ 44.473MB (SLO: <47.000MB -5.4%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 315.688ms (SLO: <344.800ms -8.4%) vs baseline: -0.3% Memory: ✅ 595.284MB (SLO: <600.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 288.155ms (SLO: <314.000ms -8.2%) vs baseline: +0.3% Memory: ✅ 596.296MB (SLO: <600.000MB 🟡 -0.6%) vs baseline: +4.8% ✅ get-contextTime: ✅ 80.285ms (SLO: <92.350ms 📉 -13.1%) vs baseline: -0.4% Memory: ✅ 39.969MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 39.836ms (SLO: <44.500ms 📉 -10.5%) vs baseline: +2.6% Memory: ✅ 43.848MB (SLO: <47.500MB -7.7%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 59.343ms (SLO: <67.650ms 📉 -12.3%) vs baseline: +0.7% Memory: ✅ 40.165MB (SLO: <47.000MB 📉 -14.5%) vs baseline: +4.5% ✅ set-statusTime: ✅ 44.853ms (SLO: <50.400ms 📉 -11.0%) vs baseline: +0.5% Memory: ✅ 43.958MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% ✅ startTime: ✅ 38.300ms (SLO: <43.450ms 📉 -11.9%) vs baseline: +0.3% Memory: ✅ 43.957MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% ✅ start-finishTime: ✅ 82.629ms (SLO: <88.000ms -6.1%) vs baseline: +0.1% Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 83.904ms (SLO: <89.000ms -5.7%) vs baseline: ~same Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.9% ✅ update-nameTime: ✅ 40.364ms (SLO: <45.150ms 📉 -10.6%) vs baseline: +1.0% Memory: ✅ 44.229MB (SLO: <47.000MB -5.9%) vs baseline: +5.1% 🟡 span - 26/26✅ add-eventTime: ✅ 20.602ms (SLO: <22.500ms -8.4%) vs baseline: +0.5% Memory: ✅ 50.312MB (SLO: <53.000MB -5.1%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 91.164ms (SLO: <93.500ms -2.5%) vs baseline: +0.4% Memory: ✅ 661.197MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 148.001ms (SLO: <155.000ms -4.5%) vs baseline: +0.2% Memory: ✅ 660.885MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.7% ✅ get-contextTime: ✅ 19.144ms (SLO: <20.500ms -6.6%) vs baseline: +0.1% Memory: ✅ 49.087MB (SLO: <53.000MB -7.4%) vs baseline: +4.6% ✅ is-recordingTime: ✅ 19.398ms (SLO: <20.500ms -5.4%) vs baseline: -0.1% Memory: ✅ 49.173MB (SLO: <53.000MB -7.2%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 38.591ms (SLO: <40.000ms -3.5%) vs baseline: +0.6% Memory: ✅ 42.809MB (SLO: <53.000MB 📉 -19.2%) vs baseline: +5.1% ✅ set-statusTime: ✅ 21.158ms (SLO: <22.000ms -3.8%) vs baseline: ~same Memory: ✅ 49.106MB (SLO: <53.000MB -7.3%) vs baseline: +4.8% ✅ startTime: ✅ 19.185ms (SLO: <20.500ms -6.4%) vs baseline: -0.6% Memory: ✅ 49.157MB (SLO: <53.000MB -7.3%) vs baseline: +4.9% ✅ start-finishTime: ✅ 51.524ms (SLO: <52.500ms 🟡 -1.9%) vs baseline: +0.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 52.746ms (SLO: <54.500ms -3.2%) vs baseline: +0.3% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ start-finish-traceid128Time: ✅ 55.064ms (SLO: <56.000ms 🟡 -1.7%) vs baseline: +0.4% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ start-traceid128Time: ✅ 19.866ms (SLO: <22.500ms 📉 -11.7%) vs baseline: +1.1% Memory: ✅ 49.076MB (SLO: <53.000MB -7.4%) vs baseline: +4.7% ✅ update-nameTime: ✅ 20.255ms (SLO: <22.000ms -7.9%) vs baseline: +0.5% Memory: ✅ 49.783MB (SLO: <53.000MB -6.1%) vs baseline: +4.6%
|
Description
Adding support for custom scanners.
[RFC-1071] API Security: Custom Data Classification
Testing
Add a new custom rule file and a specific tests in threats tests.
Also tested with DataDog/system-tests#5468
APPSEC-59618