-
Notifications
You must be signed in to change notification settings - Fork 461
wip allow versioned dataset pull #14921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 242 ± 2 ms. The average import time from base is: 244 ± 3 ms. The import time difference between this PR and base is: -2.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate gary/mlob-3837 (6cf1a5a) with baseline main (24f0351) 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.499ms (SLO: <22.300ms -8.1%) vs baseline: +0.4% Memory: ✅ 65.426MB (SLO: <67.000MB -2.3%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.343ms (SLO: <1.450ms -7.4%) vs baseline: -0.7% Memory: ✅ 64.535MB (SLO: <67.000MB -3.7%) vs baseline: +4.7% ✅ iastTime: ✅ 20.544ms (SLO: <22.250ms -7.7%) vs baseline: +0.4% Memory: ✅ 65.488MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.288ms (SLO: <16.550ms -7.6%) vs baseline: +0.6% Memory: ✅ 53.674MB (SLO: <54.500MB 🟡 -1.5%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 20.519ms (SLO: <21.750ms -5.7%) vs baseline: ~same Memory: ✅ 65.392MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ span-code-originTime: ✅ 25.450ms (SLO: <28.200ms -9.8%) vs baseline: +0.3% Memory: ✅ 67.519MB (SLO: <69.500MB -2.8%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.512ms (SLO: <21.750ms -5.7%) vs baseline: +0.1% Memory: ✅ 65.471MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.107ms (SLO: <23.500ms -5.9%) vs baseline: ~same Memory: ✅ 66.547MB (SLO: <67.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ tracer-dont-create-db-spansTime: ✅ 19.347ms (SLO: <21.500ms 📉 -10.0%) vs baseline: ~same Memory: ✅ 65.488MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.624ms (SLO: <17.500ms -5.0%) vs baseline: -0.3% Memory: ✅ 65.379MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.518ms (SLO: <21.750ms -5.7%) vs baseline: +0.2% Memory: ✅ 71.468MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.452ms (SLO: <19.650ms -6.1%) vs baseline: ~same Memory: ✅ 65.411MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.789ms (SLO: <20.100ms -6.5%) vs baseline: +0.5% Memory: ✅ 65.443MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.169ms (SLO: <21.500ms -6.2%) vs baseline: +0.5% Memory: ✅ 65.456MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.280ms (SLO: <22.000ms -7.8%) vs baseline: ~same Memory: ✅ 65.460MB (SLO: <67.000MB -2.3%) vs baseline: +4.7% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.057ms (SLO: <19.850ms -9.0%) vs baseline: +0.2% Memory: ✅ 65.274MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.040ms (SLO: <19.400ms -7.0%) vs baseline: +0.4% Memory: ✅ 65.333MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.049ms (SLO: <19.450ms -7.2%) vs baseline: -0.2% Memory: ✅ 65.313MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.603ms (SLO: <4.750ms -3.1%) vs baseline: +0.4% Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.614ms (SLO: <6.750ms -2.0%) vs baseline: +0.2% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.588ms (SLO: <4.750ms -3.4%) vs baseline: +0.2% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 45.416MB (SLO: <47.000MB -3.4%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: -0.2% Memory: ✅ 42.369MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.908ms (SLO: <2.100ms -9.2%) vs baseline: -0.3% Memory: ✅ 46.498MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.367ms (SLO: <3.650ms -7.7%) vs baseline: +0.3% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.367ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 58.287MB (SLO: <60.000MB -2.9%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 41.901ms (SLO: <47.150ms 📉 -11.1%) vs baseline: +2.4% Memory: ✅ 44.177MB (SLO: <47.000MB -6.0%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 319.819ms (SLO: <344.800ms -7.2%) vs baseline: +0.3% Memory: ✅ 616.677MB (SLO: <630.000MB -2.1%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 288.376ms (SLO: <314.000ms -8.2%) vs baseline: -1.4% Memory: ✅ 618.873MB (SLO: <630.000MB 🟡 -1.8%) vs baseline: +4.7% ✅ get-contextTime: ✅ 81.354ms (SLO: <92.350ms 📉 -11.9%) vs baseline: +0.6% Memory: ✅ 39.747MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 38.501ms (SLO: <44.500ms 📉 -13.5%) vs baseline: +0.4% Memory: ✅ 43.538MB (SLO: <47.500MB -8.3%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 59.573ms (SLO: <67.650ms 📉 -11.9%) vs baseline: +2.3% Memory: ✅ 40.053MB (SLO: <47.000MB 📉 -14.8%) vs baseline: +4.6% ✅ set-statusTime: ✅ 44.819ms (SLO: <50.400ms 📉 -11.1%) vs baseline: +1.8% Memory: ✅ 43.636MB (SLO: <47.000MB -7.2%) vs baseline: +4.9% ✅ startTime: ✅ 37.952ms (SLO: <43.450ms 📉 -12.7%) vs baseline: +0.7% Memory: ✅ 43.658MB (SLO: <47.000MB -7.1%) vs baseline: +4.8% ✅ start-finishTime: ✅ 82.612ms (SLO: <88.000ms -6.1%) vs baseline: -0.3% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.171ms (SLO: <89.000ms -5.4%) vs baseline: -0.2% Memory: ✅ 34.623MB (SLO: <46.500MB 📉 -25.5%) vs baseline: +5.2% ✅ update-nameTime: ✅ 39.351ms (SLO: <45.150ms 📉 -12.8%) vs baseline: +0.6% Memory: ✅ 43.963MB (SLO: <47.000MB -6.5%) vs baseline: +4.8% 🟡 span - 26/26✅ add-eventTime: ✅ 20.291ms (SLO: <22.500ms -9.8%) vs baseline: +0.1% Memory: ✅ 49.702MB (SLO: <53.000MB -6.2%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 91.145ms (SLO: <93.500ms -2.5%) vs baseline: +0.2% Memory: ✅ 690.303MB (SLO: <961.000MB 📉 -28.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.584ms (SLO: <155.000ms -4.8%) vs baseline: ~same Memory: ✅ 690.322MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.8% ✅ get-contextTime: ✅ 18.938ms (SLO: <20.500ms -7.6%) vs baseline: +1.0% Memory: ✅ 48.373MB (SLO: <53.000MB -8.7%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 19.247ms (SLO: <20.500ms -6.1%) vs baseline: +0.9% Memory: ✅ 48.432MB (SLO: <53.000MB -8.6%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 38.875ms (SLO: <40.000ms -2.8%) vs baseline: +3.7% Memory: ✅ 42.464MB (SLO: <53.000MB 📉 -19.9%) vs baseline: +4.8% ✅ set-statusTime: ✅ 20.792ms (SLO: <22.000ms -5.5%) vs baseline: +0.4% Memory: ✅ 48.497MB (SLO: <53.000MB -8.5%) vs baseline: +4.9% ✅ startTime: ✅ 18.881ms (SLO: <20.500ms -7.9%) vs baseline: +1.0% Memory: ✅ 48.422MB (SLO: <53.000MB -8.6%) vs baseline: +4.9% ✅ start-finishTime: ✅ 51.618ms (SLO: <52.500ms 🟡 -1.7%) vs baseline: +0.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 53.713ms (SLO: <54.500ms 🟡 -1.4%) vs baseline: +2.1% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ start-finish-traceid128Time: ✅ 54.816ms (SLO: <57.000ms -3.8%) vs baseline: ~same Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ start-traceid128Time: ✅ 19.336ms (SLO: <22.500ms 📉 -14.1%) vs baseline: +1.5% Memory: ✅ 48.491MB (SLO: <53.000MB -8.5%) vs baseline: +4.7% ✅ update-nameTime: ✅ 19.445ms (SLO: <22.000ms 📉 -11.6%) vs baseline: +0.7% Memory: ✅ 49.135MB (SLO: <53.000MB -7.3%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.217µs (SLO: <20.000µs 📉 -83.9%) vs baseline: +9.1% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 203.653µs (SLO: <220.000µs -7.4%) vs baseline: +0.7% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.317µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.7% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.657µs (SLO: <220.000µs -2.4%) vs baseline: -0.4% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.211µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.3% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.236µs (SLO: <150.000µs -8.5%) vs baseline: +0.3% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.067µs (SLO: <20.000µs 📉 -84.7%) vs baseline: +0.5% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 213.973µs (SLO: <250.000µs 📉 -14.4%) vs baseline: -0.8% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.686ms (SLO: <22.000ms -6.0%) vs baseline: +1.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.261ms (SLO: <2.300ms 🟡 -1.7%) vs baseline: -0.6% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: +0.3% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.214ms (SLO: <2.550ms 📉 -13.2%) vs baseline: +0.9% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.499µs (SLO: <20.000µs 📉 -77.5%) vs baseline: +0.4% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 176.091µs (SLO: <250.000µs 📉 -29.6%) vs baseline: ~same Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.108ms (SLO: <2.500ms 📉 -15.7%) vs baseline: -1.2% Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +4.9%
|
ee5feda
to
6cf1a5a
Compare
Description
Testing
with the following script to first pull the latest version, then a specified version, and a non existent version, we get the following output:
output:
the number of entries match the different versions of the dataset: https://dddev.datadoghq.com/llm/datasets/a68e7967-9d2b-4171-a887-f55ba4dbfe5e
Risks
Additional Notes