fix(profiling): placement new for all containers post fork#18560
fix(profiling): placement new for all containers post fork#18560KowalskiThomas wants to merge 2 commits into
Conversation
Codeowners resolved as |
|
a8afc07 to
53d46ab
Compare
|
This change is marked for backport to 4.10 and it does not conflict with that branch. |
|
This change is marked for backport to 4.8 and it does not conflict with that branch. |
|
This change is marked for backport to 4.11 and it does not conflict with that branch. |
|
This change is marked for backport to 4.9 and it does not conflict with that branch. |
1067a44 to
4776cfb
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4776cfb81e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Should we add identified by crashtracker if it was ID by crash logs |
Description
This PR fixes more, even rarer post-fork crashes detected through Crash Logs (< 10 per day).
The fix is to "hard reset" with a placement-
newinstead ofclearor whatever the "usual" way to reset is. The reason (still) is that the Sampling Thread may be mid-sampling / mid heap operation when the fork happens, in which case the STL containers we use may be left in an inconsistent state in the child process where the previously-working thread doesn't exist anymore.