perf(profiling): reuse asyncio task unwind buffers#18568
Draft
taegyunkim wants to merge 3 commits into
Draft
Conversation
Codeowners resolved as |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse native stack-collector buffers while unwinding asyncio Tasks. This mirrors the greenlet buffer-reuse optimization by keeping per-thread
StackInfoslots and per-task coroutineFrameStackbuffers alive across samples, reducing allocator churn and native heap growth in asyncio services with many long-lived tasks.Testing
scripts/lint style tests/profiling/collector/test_asyncio_buffer_reuse.py && scripts/lint cformat && scripts/lint spelling releasenotes/notes/perf-profiling-unwind-asyncio-tasks-buffer-reuse-4f6e2a8b9c1d0e3f.yamlscripts/run-tests --venv 95f8b96 tests/profiling/collector/test_asyncio_buffer_reuse.py -- -- tests/profiling/collector/test_asyncio_buffer_reuse.py -k test_asyncio_unwind_tasks_rss_stablescripts/run-tests --venv 95f8b96 tests/profiling/collector/test_stack_asyncio_basic.py -- -- tests/profiling/collector/test_stack_asyncio_basic.py -k test_asyncio_basicRisks
Low. The change preserves existing stack-rendering behavior while reusing cleared buffers between samples. Potential risk is stale task stack reuse; mitigated by resetting active counts at unwind entry and erasing coroutine-stack entries for tasks that are no longer present.
Additional Notes
Release note included.